You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/01/19 10:30:02 UTC

[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2999: update metrics

StevenLuMT commented on a change in pull request #2999:
URL: https://github.com/apache/bookkeeper/pull/2999#discussion_r787599349



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieImpl.java
##########
@@ -1082,7 +1082,8 @@ public ByteBuf readEntry(long ledgerId, long entryId)
                 LOG.trace("Reading {}@{}", entryId, ledgerId);
             }
             ByteBuf entry = handle.readEntry(entryId);
-            bookieStats.getReadBytes().add(entry.readableBytes());
+            entrySize = entry.readableBytes();
+            bookieStats.getReadBytes().add(entrySize);

Review comment:
       it's necessary  for the finally using it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org