You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/20 00:49:00 UTC
[jira] [Work logged] (CAMEL-14194) Invalid JID is generated for
private chat in XMPP component
[ https://issues.apache.org/jira/browse/CAMEL-14194?focusedWorklogId=346387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-346387 ]
ASF GitHub Bot logged work on CAMEL-14194:
------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/19 00:48
Start Date: 20/Nov/19 00:48
Worklog Time Spent: 10m
Work Description: jpramming commented on pull request #3351: CAMEL-14194: Message thread name removed from JID
URL: https://github.com/apache/camel/pull/3351
A proposed fix to the issue where invalid JID's are generated for private chat messages.
I could not find any reason for the message thread to be appended to the JID and the thread is set in the message, and have removed the thread.
Tested using Openfire 4.4.3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 346387)
Remaining Estimate: 0h
Time Spent: 10m
> Invalid JID is generated for private chat in XMPP component
> -----------------------------------------------------------
>
> Key: CAMEL-14194
> URL: https://issues.apache.org/jira/browse/CAMEL-14194
> Project: Camel
> Issue Type: Bug
> Components: camel-xmpp
> Affects Versions: 2.24.2, 3.0.0.RC3
> Reporter: Johan Pramming
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> An invalid JID, containing non-LDH characters, is created for the receiver (participant) when a private chat is started. As a result it is not possible to send chat messages directly to an user.
> Group chats are not affected by the issue.
> See: [https://stackoverflow.com/questions/58168566/problem-sending-messages-from-camel-xmpp-jid-malformed]
>
> Exception seen in Openfire (4.4.3):
> {code:java}
> java.lang.IllegalArgumentException: The input 'xxxx.xxx.xx@chat:xxxxx@xxxx.xxx.xx:camel' is not a valid JID domain part: Contains non-LDH characters.
> {code}
>
> The issue can be fixed by removing the thread name when the JID is created:
> {code:java}
> diff --git a/components/camel-xmpp/src/main/java/org/apache/camel/component/xmpp/XmppPrivateChatProducer.java b/components/camel-xmpp/src/main/java/org/apache/camel/component/xmpp/XmppPrivateChatProducer.java
> index b1b30a117ed..6eb1b9cb59c 100644
> --- a/components/camel-xmpp/src/main/java/org/apache/camel/component/xmpp/XmppPrivateChatProducer.java
> +++ b/components/camel-xmpp/src/main/java/org/apache/camel/component/xmpp/XmppPrivateChatProducer.java
> @@ -97,7 +97,7 @@ public class XmppPrivateChatProducer extends DefaultProducer { private Chat getOrCreateChat(ChatManager chatManager, final String participant, String thread) throws XmppStringprepException {
> // this starts a new chat or retrieves the pre-existing one in a threadsafe manner
> - return chatManager.chatWith(JidCreate.entityBareFrom(participant + "@" + thread));
> + return chatManager.chatWith(JidCreate.entityBareFrom(participant));
> } private synchronized void reconnect() throws InterruptedException, IOException, SmackException, XMPPException {
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)