[GitHub] eiri commented on a change in pull request #474: 3364 fix view compactor unknown info

[gi...@git.apache.org]

eiri commented on a change in pull request #474: 3364 fix view compactor unknown info
URL: https://github.com/apache/couchdb/pull/474#discussion_r110991057
 
 

 ##########
 File path: src/couch_index/src/couch_index_compactor.erl
 ##########
 @@ -81,6 +85,14 @@ handle_cast(_Mesg, State) ->
 
 handle_info({'EXIT', Pid, normal}, #st{pid=Pid}=State) ->
     {noreply, State#st{pid=undefined}};
+handle_info({'EXIT', Pid, Reason}, #st{pid = Pid} = State) ->
+    #st{idx = Idx, mod = Mod} = State,
+    {ok, IdxState} = gen_server:call(Idx, {compaction_failed, Reason}),
 
 Review comment:
   we don't do that with gen_call for [`compacted`](https://github.com/cloudant/couchdb/blob/a39bfd1d0529fda9415229ff2b0698837988f332/src/couch_index/src/couch_index_compactor.erl#L126) though. I think the intent here is _not_ to expose internals of `couch_index` compactor's flow, we want public API on triggering compaction, but not on interrupting its execution except from compaction process.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services