You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/11 01:23:29 UTC
[kudu-CR] Reorganize and fill out release notes for 1.0
Hello Dan Burkert, Mike Percy, Adar Dembo, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4369
to review the following change.
Change subject: Reorganize and fill out release notes for 1.0
......................................................................
Reorganize and fill out release notes for 1.0
- moved old version release notes to a separate page
- removed verbiage about 'beta', since we are hitting 1.0
- moved all the content one level of indentation up, since we now have
just a single page for the latest version.
- reorganized the incompatible changes to be grouped into sub-sections
- added a known issue for KUDU-1508 (ext4 corruption on RHEL6)
- cleaned up other known issue and limitation text
Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
---
A docs/prior_release_notes.adoc
M docs/release_notes.adoc
2 files changed, 911 insertions(+), 752 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/4369/1
--
To view, visit http://gerrit.cloudera.org:8080/4369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Reorganize and fill out release notes for 1.0
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Reorganize and fill out release notes for 1.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4369/1//COMMIT_MSG
Commit Message:
Line 10: - removed verbiage about 'beta', since we are hitting 1.0
> Can this all this beta cleanup stuff be done in one, separate patch? For ex
The FAQ is a different branch though
--
To view, visit http://gerrit.cloudera.org:8080/4369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Reorganize and fill out release notes for 1.0
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Reorganize and fill out release notes for 1.0
......................................................................
Patch Set 1:
Will gave me a verbal +1 to move forward with this commit
--
To view, visit http://gerrit.cloudera.org:8080/4369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] Reorganize and fill out release notes for 1.0
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Reorganize and fill out release notes for 1.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4369/1//COMMIT_MSG
Commit Message:
Line 10: - removed verbiage about 'beta', since we are hitting 1.0
Can this all this beta cleanup stuff be done in one, separate patch? For example, lots of cleanup is needed in http://kudu.apache.org/faq.html
--
To view, visit http://gerrit.cloudera.org:8080/4369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Reorganize and fill out release notes for 1.0
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Reorganize and fill out release notes for 1.0
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4369/1/docs/release_notes.adoc
File docs/release_notes.adoc:
Line 121: - The `KuduScanToken::TabletServers` method in the {cpp} library has been removed.
nit: Why say {cpp} instead of just C++ here and elsewhere?
--
To view, visit http://gerrit.cloudera.org:8080/4369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Reorganize and fill out release notes for 1.0
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Reorganize and fill out release notes for 1.0
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4369/1//COMMIT_MSG
Commit Message:
Line 10: - removed verbiage about 'beta', since we are hitting 1.0
> The FAQ is a different branch though
yea, this patch already covers most of the 'beta' items except for references to Cloudera download pages (which have /beta/ in the URL, since Cloudera isn't providing official support yet). The other changes are mostly web-centric.
http://gerrit.cloudera.org:8080/#/c/4369/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 148: Type and nullability of existing columns cannot be changed by altering the table.
> Right now only the name of a column can be changed. So type, nullability, d
yea, hoping we can get to this for 1.1 or so.
PS1, Line 163: old tables
> s/tables/tablets/? This bullet is confusing. You mean one must create a new
agreed. Mind if I commit this to avoid rebase hell, and then do another patch for another round of fixups?
PS1, Line 186: decimal type
> I've had a 75% working patch for this for a long time. I need to rebase and
that'd be great!
--
To view, visit http://gerrit.cloudera.org:8080/4369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Reorganize and fill out release notes for 1.0
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Reorganize and fill out release notes for 1.0
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3344/
--
To view, visit http://gerrit.cloudera.org:8080/4369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reorganize and fill out release notes for 1.0
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Reorganize and fill out release notes for 1.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4369/1/docs/release_notes.adoc
File docs/release_notes.adoc:
Line 121: - The `KuduScanToken::TabletServers` method in the {cpp} library has been removed.
> nit: Why say {cpp} instead of just C++ here and elsewhere?
Nevermind, I found the reason. Neat. It's an alias for the text "C++": https://github.com/asciidoctor/asciidoctor/issues/1208
--
To view, visit http://gerrit.cloudera.org:8080/4369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Reorganize and fill out release notes for 1.0
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: Reorganize and fill out release notes for 1.0
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4369/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 148: Type and nullability of existing columns cannot be changed by altering the table.
Right now only the name of a column can be changed. So type, nullability, default, encoding, compression, and block size cannot be changed. I'm working on KUDU-861 for the latter 4 but I wasn't thinking I'd finish it for 1.0 since it needs a good amount of work.
PS1, Line 163: old tables
s/tables/tablets/? This bullet is confusing. You mean one must create a new table with less tablets and copy the original table's data into it in order to (effectively) merge tablets?
PS1, Line 186: decimal type
I've had a 75% working patch for this for a long time. I need to rebase and finish it and it can be done for 1.1.
--
To view, visit http://gerrit.cloudera.org:8080/4369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Reorganize and fill out release notes for 1.0
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Reorganize and fill out release notes for 1.0
......................................................................
Reorganize and fill out release notes for 1.0
- moved old version release notes to a separate page
- removed verbiage about 'beta', since we are hitting 1.0
- moved all the content one level of indentation up, since we now have
just a single page for the latest version.
- reorganized the incompatible changes to be grouped into sub-sections
- added a known issue for KUDU-1508 (ext4 corruption on RHEL6)
- cleaned up other known issue and limitation text
Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
Reviewed-on: http://gerrit.cloudera.org:8080/4369
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
A docs/prior_release_notes.adoc
M docs/release_notes.adoc
2 files changed, 911 insertions(+), 752 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f35c3284d384b88be4581bed5f952e71c4af869
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>