You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/06/07 23:01:30 UTC
[GitHub] [trafficserver] ywkaras opened a new pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
ywkaras opened a new pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925
Caching is disabled when the next hop is a peer (in the first host group).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895525584
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-868724576
@jrushford or @rob05c can you please take a look at this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895389076
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-880769428
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on a change in pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
jrushford commented on a change in pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#discussion_r669890422
##########
File path: proxy/http/remap/NextHopSelectionStrategy.cc
##########
@@ -63,6 +63,8 @@ bool
NextHopSelectionStrategy::Init(ts::Yaml::Map &n)
{
NH_Debug(NH_DEBUG_TAG, "calling Init()");
+ std::string self_host;
Review comment:
@ywkaras Consider adding this new field to the unit testing, see proxy/remap/http/unit-tests/test_NextHopConsistentHash.cc and peering-group.yaml in the same unit-tests directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-856355614
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-880294242
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-856355614
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895394851
Converted this to draft until I can get Au tests on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: For strategies.yaml, add peering_ring with go_direct, and Au tests for peering_ring.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-915251130
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras merged pull request #7925: For strategies.yaml, add peering_ring with go_direct, and Au tests for peering_ring.
Posted by GitBox <gi...@apache.org>.
ywkaras merged pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-875993296
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-896893286
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on a change in pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
jrushford commented on a change in pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#discussion_r647656261
##########
File path: iocore/utils/Machine.cc
##########
@@ -219,6 +221,9 @@ Machine::Machine(char const *the_hostname, sockaddr const *addr)
hostname = ats_strdup(localhost);
}
}
+ if (const char *test_local_host = std::getenv("TS_TEST_LOCALHOST"); test_local_host) {
Review comment:
For discussion: Instead of this, perhaps we should add a boolean in strategies.yaml say, **is_self: true/false**, that is part of the host definition. **is_self** is an optional field that defaults to **false**?
##########
File path: proxy/http/remap/NextHopSelectionStrategy.cc
##########
@@ -63,6 +63,8 @@ bool
NextHopSelectionStrategy::Init(ts::Yaml::Map &n)
{
NH_Debug(NH_DEBUG_TAG, "calling Init()");
+ std::string self_host;
Review comment:
@ywkaras Consider adding this new field to the unit testing, see proxy/remap/http/unit-tests/test_NextHopConsistentHash.cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-875993296
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895392870
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895394851
Converted this to draft until I can get Au tests on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: For strategies.yaml, add peering_ring with go_direct, and Au tests for peering_ring.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-915251130
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on a change in pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
jrushford commented on a change in pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#discussion_r669890422
##########
File path: proxy/http/remap/NextHopSelectionStrategy.cc
##########
@@ -63,6 +63,8 @@ bool
NextHopSelectionStrategy::Init(ts::Yaml::Map &n)
{
NH_Debug(NH_DEBUG_TAG, "calling Init()");
+ std::string self_host;
Review comment:
@ywkaras Consider adding this new field to the unit testing, see proxy/remap/http/unit-tests/test_NextHopConsistentHash.cc and peering.yaml in the same unit-tests directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-880294242
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on a change in pull request #7925: For strategies.yaml, add peering_ring with go_direct, and Au tests for peering_ring.
Posted by GitBox <gi...@apache.org>.
jrushford commented on a change in pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#discussion_r689793759
##########
File path: proxy/http/remap/NextHopSelectionStrategy.cc
##########
@@ -108,7 +110,12 @@ NextHopSelectionStrategy::Init(ts::Yaml::Map &n)
} else if (ring_mode_val == exhaust_rings) {
ring_mode = NH_EXHAUST_RING;
} else if (ring_mode_val == peering_rings) {
- ring_mode = NH_PEERING_RING;
+ ring_mode = NH_PEERING_RING;
+ YAML::Node self_node = failover_node["self"];
+ if (self_node) {
Review comment:
@ywkaras Is this correct, `self` is part of the failover node`. I'm not sure how this works in identifying the self host. Maybe I'm missing something. In testing, I'm looping when the self host is selected
##########
File path: proxy/http/remap/NextHopSelectionStrategy.cc
##########
@@ -214,8 +221,13 @@ NextHopSelectionStrategy::Init(ts::Yaml::Map &n)
std::shared_ptr<HostRecord> host_rec = std::make_shared<HostRecord>(hosts_list[hst].as<HostRecord>());
host_rec->group_index = grp;
host_rec->host_index = hst;
- if (mach->is_self(host_rec->hostname)) {
+ if ((self_host == host_rec->hostname) || mach->is_self(host_rec->hostname.c_str())) {
+ if (grp != 0) {
+ throw std::invalid_argument("self host (" + self_host + ") can only appear in first host group");
+ }
h_stat.setHostStatus(host_rec->hostname.c_str(), TSHostStatus::TS_HOST_STATUS_DOWN, 0, Reason::SELF_DETECT);
Review comment:
@ywkaras the self detection doesn't seem to work now. Host status no-longer has a SELF_DETECT down for the self_host. I'm using the peering ring mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: For strategies.yaml, add peering_ring with go_direct, and Au tests for peering_ring.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-915251687
[approve ci FreeBSD]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall removed a comment on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
bryancall removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895481874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895526214
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895524951
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-856335130
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-896893286
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895334125
[approve ci Clang-Analyzer]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895389076
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895334125
[approve ci Clang-Analyzer]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-866493278
This includes an addition to strategies.yaml, adding an optional **self** key to the **failover** map for a peering ring, whose value can specify a hostname from the peer group as identifying the local host.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-856330178
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-856920369
Making this a draft for now. John may be adding an option to strategies.yaml that will make the TS_TEST_LOCALHOST environment variable unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-866477650
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: For strategies.yaml, add peering_ring with go_direct, and Au tests for peering_ring.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-915251687
[approve ci FreeBSD]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895392870
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-880933146
[approve ci RAT]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-880337182
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-880337182
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895547442
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
jrushford commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-881465328
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895513203
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-880769428
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
jrushford commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-880876391
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-856335130
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-880910324
The autest failure is looks repeatable, always happens for tls_conn_timeout test case. But it passes in my development environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-866477650
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-880933146
[approve ci RAT]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895526864
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford removed a comment on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
jrushford removed a comment on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-881465328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-895481874
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on a change in pull request #7925: For strategies.yaml, add peering_ring with go_direct, and Au tests for peering_ring.
Posted by GitBox <gi...@apache.org>.
jrushford commented on a change in pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#discussion_r689793759
##########
File path: proxy/http/remap/NextHopSelectionStrategy.cc
##########
@@ -108,7 +110,12 @@ NextHopSelectionStrategy::Init(ts::Yaml::Map &n)
} else if (ring_mode_val == exhaust_rings) {
ring_mode = NH_EXHAUST_RING;
} else if (ring_mode_val == peering_rings) {
- ring_mode = NH_PEERING_RING;
+ ring_mode = NH_PEERING_RING;
+ YAML::Node self_node = failover_node["self"];
+ if (self_node) {
Review comment:
@ywkaras Is this correct, `self` is part of the failover node`. I'm not sure how this works in identifying the self host. Maybe I'm missing something. In testing, I'm looping when the self host is selected.
I used 'self: my_self_hostname.cdn.com'. This doesn't parse, no error is logged but the strategy is destroyed in the NextHopStrategyFactory:143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au test for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-856330178
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7925: Add Au tests for strategies.yaml, with consistent hashing, with peering.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#issuecomment-896417278
Using cache_key for hash_key doesn't seem to be working correctly, so keeping this as a draft for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org