You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zihao Ye (Code Review)" <ge...@cloudera.org> on 2023/10/27 06:16:41 UTC

[Impala-ASF-CR] IMPALA-12508: Update query option "enabled runtime filter types" comments

Hello Riza Suminto, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20627

to look at the new patch set (#3).

Change subject: IMPALA-12508: Update query option "enabled_runtime_filter_types" comments
......................................................................

IMPALA-12508: Update query option "enabled_runtime_filter_types" comments

The query option "enabled_runtime_filter_types" currently allows
specifying a comma-separated list of runtime filter types (including
BLOOM, MIN_MAX and IN_LIST) to enable or setting it to "all" to use all
types. But the comment for this query option does not mention IN_LIST
and states that it only applies to Kudu, which is outdated, as it also
affects HDFS scans after IMPALA-10325.

Therefore, this patch update the relevant comments to avoid any
misleading caused by the outdated comments.

Change-Id: Iecff7c655e273712d851d9ce94ef5713e579aa72
---
M common/thrift/ImpalaService.thrift
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/20627/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecff7c655e273712d851d9ce94ef5713e579aa72
Gerrit-Change-Number: 20627
Gerrit-PatchSet: 3
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>