You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/21 01:24:13 UTC
[GitHub] [flink] KarmaGYZ opened a new pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
KarmaGYZ opened a new pull request #18434:
URL: https://github.com/apache/flink/pull/18434
…nk side.
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1021948494
Sorry for nitpicking. Could we please pay more attention to PRs description? We should serve as an example if we require contributors to fill it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1021955008
@dawidwys I'll fill that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033503027",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"triggerType" : "PUSH"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "1034329303",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6408af3118bf294fdb704e36af7568756f3bd1c5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ removed a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ removed a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1033442692
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018079234
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 123918f917a1e4fbea09c64c97c88b20f9a18792 (Fri Jan 21 01:28:41 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1021956202
Thanks @KarmaGYZ ! I know from personal experience it might be daunting at times :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1022775069
@zentol This PR is an improvement of the job execution for Flink OLAP. In our internal benchmark, the serialization of the `RemoteRpcInvocation` at the Flink side will increase the end-to-end latency of a 1000*1000 `WordCount` for about 100ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033503027",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"triggerType" : "PUSH"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "1034329303",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6408af3118bf294fdb704e36af7568756f3bd1c5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033503027",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"triggerType" : "PUSH"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "1034329303",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "1034493244",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6408af3118bf294fdb704e36af7568756f3bd1c5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 123918f917a1e4fbea09c64c97c88b20f9a18792 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033503027",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"triggerType" : "PUSH"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "1034329303",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "1034493244",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6408af3118bf294fdb704e36af7568756f3bd1c5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9cb1fddc375c0b7583b529ebd83faa0ee700a983 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267)
* 972db53783b183c8f0f829b0510e599f140787af Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1033503027
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18434:
URL: https://github.com/apache/flink/pull/18434#discussion_r794364073
##########
File path: flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/MessageSerializationTest.java
##########
@@ -139,32 +139,6 @@ public void testSerializableRemoteMessageTransfer() throws Exception {
assertThat(linkedBlockingQueue.take(), Is.<Object>is(expected));
}
- /**
- * Tests that a message which exceeds the maximum frame size is detected and a corresponding
- * exception is thrown.
- */
- @Test(expected = IOException.class)
- public void testMaximumFramesizeRemoteMessageTransfer() throws Exception {
Review comment:
There should still be a test that checks the behavior if this error case occurs. E.g., that the response future is completed exceptionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033503027",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 972db53783b183c8f0f829b0510e599f140787af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962)
* 6408af3118bf294fdb704e36af7568756f3bd1c5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1034329303
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1033442692
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033503027",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 972db53783b183c8f0f829b0510e599f140787af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ closed pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ closed pull request #18434:
URL: https://github.com/apache/flink/pull/18434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033503027",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"triggerType" : "PUSH"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "1034329303",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6408af3118bf294fdb704e36af7568756f3bd1c5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 123918f917a1e4fbea09c64c97c88b20f9a18792 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9cb1fddc375c0b7583b529ebd83faa0ee700a983 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1024061854
> Without this serialization
But things are serialized _anyway_ because of Akka; it just happens later. So where is this performance gain coming from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1034493244
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 972db53783b183c8f0f829b0510e599f140787af Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033503027",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6408af3118bf294fdb704e36af7568756f3bd1c5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1022775069
@zentol This PR is an improvement of the job execution for Flink OLAP. In the OLAP scenario, most jobs can be finished within 1s(in our internal benchmark, a 1000*1000 WordCount will take nearly 700ms). The serialization of the `RemoteRpcInvocation` at the Flink side will place a heavy burden on JobManager. Without this serialization, We will gain a 20% increase in throughput.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 123918f917a1e4fbea09c64c97c88b20f9a18792 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843)
* 9cb1fddc375c0b7583b529ebd83faa0ee700a983 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1030999706
@zentol Now, the `RemoteRpcInvocation` are serialized twice, first in Flink and second in Akka. This PR removes the first serialization in Flink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033503027",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 972db53783b183c8f0f829b0510e599f140787af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962)
* 6408af3118bf294fdb704e36af7568756f3bd1c5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033503027",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"triggerType" : "PUSH"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "1034329303",
"triggerType" : "MANUAL"
}, {
"hash" : "6408af3118bf294fdb704e36af7568756f3bd1c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009",
"triggerID" : "1034493244",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6408af3118bf294fdb704e36af7568756f3bd1c5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31009)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033503027",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 972db53783b183c8f0f829b0510e599f140787af Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9cb1fddc375c0b7583b529ebd83faa0ee700a983 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267)
* 972db53783b183c8f0f829b0510e599f140787af UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 123918f917a1e4fbea09c64c97c88b20f9a18792 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18434:
URL: https://github.com/apache/flink/pull/18434#discussion_r792578144
##########
File path: flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/messages/RemoteRpcInvocation.java
##########
@@ -35,13 +34,12 @@
* contains a non-serializable object, then an {@link IOException} is thrown.
*/
public class RemoteRpcInvocation implements RpcInvocation, Serializable {
Review comment:
javadocs are outdated
##########
File path: flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/MessageSerializationTest.java
##########
@@ -139,32 +139,6 @@ public void testSerializableRemoteMessageTransfer() throws Exception {
assertThat(linkedBlockingQueue.take(), Is.<Object>is(expected));
}
- /**
- * Tests that a message which exceeds the maximum frame size is detected and a corresponding
- * exception is thrown.
- */
- @Test(expected = IOException.class)
- public void testMaximumFramesizeRemoteMessageTransfer() throws Exception {
Review comment:
Which tests now covers the case of oversized messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #18434:
URL: https://github.com/apache/flink/pull/18434#discussion_r793223927
##########
File path: flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/MessageSerializationTest.java
##########
@@ -139,32 +139,6 @@ public void testSerializableRemoteMessageTransfer() throws Exception {
assertThat(linkedBlockingQueue.take(), Is.<Object>is(expected));
}
- /**
- * Tests that a message which exceeds the maximum frame size is detected and a corresponding
- * exception is thrown.
- */
- @Test(expected = IOException.class)
- public void testMaximumFramesizeRemoteMessageTransfer() throws Exception {
Review comment:
Before this PR, Flink will eagerly check the oversized messages. Now, when there is an oversized message, the job will fail with Akka's `AskTimeoutException` and there will be an error log from Akka which indicates the exact size of that message. As Flink does not take the responsibility to detect oversized messages, I think we don't need such tests anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 123918f917a1e4fbea09c64c97c88b20f9a18792 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843)
* 9cb1fddc375c0b7583b529ebd83faa0ee700a983 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18434:
URL: https://github.com/apache/flink/pull/18434#issuecomment-1018078894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29843",
"triggerID" : "123918f917a1e4fbea09c64c97c88b20f9a18792",
"triggerType" : "PUSH"
}, {
"hash" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267",
"triggerID" : "9cb1fddc375c0b7583b529ebd83faa0ee700a983",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "972db53783b183c8f0f829b0510e599f140787af",
"triggerType" : "PUSH"
}, {
"hash" : "972db53783b183c8f0f829b0510e599f140787af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962",
"triggerID" : "1033442692",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 9cb1fddc375c0b7583b529ebd83faa0ee700a983 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30267)
* 972db53783b183c8f0f829b0510e599f140787af Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30962)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org