You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/05/02 17:28:28 UTC
Review Request 58925: Updated runtime isolators to use new
task_environment member.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58925/
-----------------------------------------------------------
Review request for mesos, Adam B, Gilbert Song, and Jie Yu.
Bugs: MESOS-7429
https://issues.apache.org/jira/browse/MESOS-7429
Repository: mesos
Description
-------
see summary.
Diffs
-----
src/slave/containerizer/mesos/isolators/appc/runtime.cpp ffaec5a0112db36c1e9123e361ada63a4aedf0ad
src/slave/containerizer/mesos/isolators/docker/runtime.cpp 08350e638a0f20746e369cdc78c96126f2e1df3f
Diff: https://reviews.apache.org/r/58925/diff/1/
Testing
-------
make check and functional testing on chain end.
Thanks,
Till Toenshoff
Re: Review Request 58925: Updated runtime isolators to use new
task_environment member.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58925/#review173686
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58923, 58924, 58925]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 2, 2017, 5:28 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58925/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 5:28 p.m.)
>
>
> Review request for mesos, Adam B, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-7429
> https://issues.apache.org/jira/browse/MESOS-7429
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/appc/runtime.cpp ffaec5a0112db36c1e9123e361ada63a4aedf0ad
> src/slave/containerizer/mesos/isolators/docker/runtime.cpp 08350e638a0f20746e369cdc78c96126f2e1df3f
>
>
> Diff: https://reviews.apache.org/r/58925/diff/1/
>
>
> Testing
> -------
>
> make check and functional testing on chain end.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 58925: Updated runtime isolators to use new
task_environment member.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58925/#review174127
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On May 2, 2017, 10:28 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58925/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 10:28 a.m.)
>
>
> Review request for mesos, Adam B, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-7429
> https://issues.apache.org/jira/browse/MESOS-7429
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/appc/runtime.cpp ffaec5a0112db36c1e9123e361ada63a4aedf0ad
> src/slave/containerizer/mesos/isolators/docker/runtime.cpp 08350e638a0f20746e369cdc78c96126f2e1df3f
>
>
> Diff: https://reviews.apache.org/r/58925/diff/1/
>
>
> Testing
> -------
>
> make check and functional testing on chain end.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 58925: Updated runtime isolators to use new
task_environment member.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58925/#review173851
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On May 2, 2017, 1:28 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58925/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 1:28 p.m.)
>
>
> Review request for mesos, Adam B, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-7429
> https://issues.apache.org/jira/browse/MESOS-7429
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/appc/runtime.cpp ffaec5a0112db36c1e9123e361ada63a4aedf0ad
> src/slave/containerizer/mesos/isolators/docker/runtime.cpp 08350e638a0f20746e369cdc78c96126f2e1df3f
>
>
> Diff: https://reviews.apache.org/r/58925/diff/1/
>
>
> Testing
> -------
>
> make check and functional testing on chain end.
>
>
> Thanks,
>
> Till Toenshoff
>
>