You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "rickyma (via GitHub)" <gi...@apache.org> on 2024/01/15 18:06:14 UTC
[PR] [#1456] improvement(client): Better exception handling when calling requireBuffer using GRPC [incubator-uniffle]
rickyma opened a new pull request, #1457:
URL: https://github.com/apache/incubator-uniffle/pull/1457
### What changes were proposed in this pull request?
1、Refactor the method `ShuffleServerGrpcClient.requirePreAllocation`, calling `getBlockingStub().requireBuffer` only once.
2、Try-catch `getBlockingStub().requireBuffer`'s exception, log the error, and return `FAILED_REQUIRE_ID`.
3、Refactor the log to make it more appropriate.
### Why are the changes needed?
For [#1456](https://github.com/apache/incubator-uniffle/issues/1456)
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1456] improvement(client): Better exception handling when calling requireBuffer using GRPC [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1457:
URL: https://github.com/apache/incubator-uniffle/pull/1457#issuecomment-1895234343
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1457?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `18 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`3180501`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/318050144b62c0256c151a278bb04ac73c6e544b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 54.19% compared to head [(`ef84ef9`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1457?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 54.58%.
> Report is 3 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1457?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ffle/client/impl/grpc/ShuffleServerGrpcClient.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1457?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL2dycGMvU2h1ZmZsZVNlcnZlckdycGNDbGllbnQuamF2YQ==) | 0.00% | [18 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1457?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1457 +/- ##
============================================
+ Coverage 54.19% 54.58% +0.38%
+ Complexity 2775 2237 -538
============================================
Files 423 346 -77
Lines 24185 15617 -8568
Branches 2058 1432 -626
============================================
- Hits 13108 8524 -4584
+ Misses 10266 6614 -3652
+ Partials 811 479 -332
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1457?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1456] improvement(client): Better exception handling when calling requireBuffer using GRPC [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1457:
URL: https://github.com/apache/incubator-uniffle/pull/1457#issuecomment-1893047619
It seems some tests failed. I don't know why the code below returns `INTERNAL_ERROR`. Can I get any detailed log messages responded by server?
```
RssSendShuffleDataResponse response =
shuffleServerClient.sendShuffleData(sendShuffleDataRequest);
assertSame(StatusCode.SUCCESS, response.getStatusCode());
```
@jerqi @zuston
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1456] improvement(client): Better exception handling when calling requireBuffer using GRPC [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1457:
URL: https://github.com/apache/incubator-uniffle/pull/1457#issuecomment-1892600548
PTAL @jerqi @zuston
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1456] improvement(client): Better exception handling when calling requireBuffer using GRPC [incubator-uniffle]
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng merged PR #1457:
URL: https://github.com/apache/incubator-uniffle/pull/1457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1456] improvement(client): Better exception handling when calling requireBuffer using GRPC [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1457:
URL: https://github.com/apache/incubator-uniffle/pull/1457#issuecomment-1895251564
PTAL. @xianjingfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org