You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/21 23:08:11 UTC
[GitHub] [superset] codyml opened a new pull request, #21915: fix: Fix Cypress test broken by extra dashboards
codyml opened a new pull request, #21915:
URL: https://github.com/apache/superset/pull/21915
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The Cypress test **`chart_list/list.test.ts` > Charts list > Cross-referenced dashboards** adds new dashboards but doesn't remove them, causing `dashboard_list/list.test.ts` to fail. This PR adds an `after` clause that removes those dashboards, and also adds a `wait` that I think should help a source of flakiness.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #21915: fix: Fix Cypress test broken by extra dashboards
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #21915:
URL: https://github.com/apache/superset/pull/21915#issuecomment-1289096609
> We shouldn't be doing cleanup work in afterEach. I think there is an approach that would work for every test and not just this one. Let me get back to you. Thanks for pointing this out!
Sounds good, closing in favor of https://github.com/apache/superset/pull/21921!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21915: fix: Fix Cypress test broken by extra dashboards
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21915:
URL: https://github.com/apache/superset/pull/21915#issuecomment-1287542433
# [Codecov](https://codecov.io/gh/apache/superset/pull/21915?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21915](https://codecov.io/gh/apache/superset/pull/21915?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc2f0ba) into [master](https://codecov.io/gh/apache/superset/commit/3da9687328cdcc390876498a734547cf58dc2613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3da9687) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #21915 +/- ##
=======================================
Coverage 65.50% 65.50%
=======================================
Files 1807 1807
Lines 69141 69141
Branches 7394 7394
=======================================
Hits 45291 45291
Misses 21940 21940
Partials 1910 1910
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.33% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml closed pull request #21915: fix: Fix Cypress test broken by extra dashboards
Posted by GitBox <gi...@apache.org>.
codyml closed pull request #21915: fix: Fix Cypress test broken by extra dashboards
URL: https://github.com/apache/superset/pull/21915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21915: fix: Fix Cypress test broken by extra dashboards
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #21915:
URL: https://github.com/apache/superset/pull/21915#discussion_r1002625453
##########
superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts:
##########
@@ -68,6 +68,20 @@ describe('Charts list', () => {
cy.createSampleCharts([0]);
});
+ after(() => {
+ cy.visit(DASHBOARD_LIST);
+ cy.wait(1000);
+ toggleBulkSelect();
+ cy.wait(1000);
+ cy.getBySel('table-row').each($row => {
+ if ($row.text().indexOf('Sample dashboard') > -1) {
+ cy.wrap($row).find('input[type="checkbox"]').click();
+ }
+ });
+ cy.getBySel('bulk-select-action').eq(0).contains('Delete').click();
+ confirmDelete();
+ });
+
Review Comment:
@codyml There is a utils that it seems to do this is `cy.deleteDashboard(id: number, failOnStatusCode: boolean)` or `deleteDashboardByName(dashboardName: string, failOnStatusCode: boolean)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org