You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "jojochuang (via GitHub)" <gi...@apache.org> on 2024/06/17 17:58:20 UTC
[PR] HDDS-10943. Freon DN Echo should skip writing payload to ratis log [ozone]
jojochuang opened a new pull request, #6825:
URL: https://github.com/apache/ozone/pull/6825
## What changes were proposed in this pull request?
HDDS-10943. Freon DN Echo should skip writing payload to ratis log
Please describe your PR in detail:
Echo request transaction payload is saved into ratis log. The payload isn't used and causes rapid ratis log rotation
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10943
## How was this patch tested?
This is an optimization; no functional change. Plus, it doesn't look easy to write a unit test around ContainerStateMachine within the current framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10943. Freon DN Echo should skip writing payload to ratis log [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #6825:
URL: https://github.com/apache/ozone/pull/6825#issuecomment-2419935546
@jojochuang , thanks for working on this! Sorry that I missed this pr earlier. The change looks good. Some minor suggestions
- It is better to not building the intermediate protos since it may lead to more buffer copying.
- Combine the short lines.
```java
} else if (proto.getCmdType() == Type.Echo) {
final EchoRequestProto echo = proto.getEcho();
// skipping the payload field so it doesn't get written to the ratis log
protoBuilder.setEcho(EchoRequestProto.newBuilder(echo).clearPayload()).build();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10943. Freon DN Echo should skip writing payload to ratis log [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6825:
URL: https://github.com/apache/ozone/pull/6825#issuecomment-2475089422
Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author.
It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.
If you need ANY help to finish this PR, please [contact the community](https://github.com/apache/hadoop-ozone#contact) on the mailing list or the slack channel."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10943. Freon DN Echo should skip writing payload to ratis log [ozone]
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #6825:
URL: https://github.com/apache/ozone/pull/6825#issuecomment-2174361771
Maybe the right solution is to have 2 payloads, one that gets written to the log which presents the size of the request proto but serialized and another the data payload which does not get replication via the log? Not sure what will get measure this way when the payload is dropped entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10943. Freon DN Echo should skip writing payload to ratis log [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #6825: HDDS-10943. Freon DN Echo should skip writing payload to ratis log
URL: https://github.com/apache/ozone/pull/6825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10943. Freon DN Echo should skip writing payload to ratis log [ozone]
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #6825:
URL: https://github.com/apache/ozone/pull/6825#issuecomment-2176599563
> @kerneltime i want to do something similar to WriteChunk where the payload got sent to follower too.
Makes sense. Do you want this PR to still go forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10943. Freon DN Echo should skip writing payload to ratis log [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6825:
URL: https://github.com/apache/ozone/pull/6825#issuecomment-2419036724
/pending conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10943. Freon DN Echo should skip writing payload to ratis log [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #6825:
URL: https://github.com/apache/ozone/pull/6825#issuecomment-2433486854
Hm I think this PR is wrong. It should do what's similar to WriteChunk, do not remove data at startTransaction() because that way, follower don't get the data. Instead, ContainerStateMachine should remove data in write() and put back data in read()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10943. Freon DN Echo should skip writing payload to ratis log [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #6825:
URL: https://github.com/apache/ozone/pull/6825#issuecomment-2176594486
@kerneltime i want to do something similar to WriteChunk where the payload got sent to follower too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org