Re: [PR] Implementing `log_url` on RuntimeTaskInstance in task sdk [airflow]

["kacpermuda (via GitHub)" <gi...@apache.org>]

kacpermuda commented on code in PR #50376:
URL: https://github.com/apache/airflow/pull/50376#discussion_r2083996702


##########
providers/openlineage/src/airflow/providers/openlineage/utils/utils.py:
##########
@@ -444,6 +444,7 @@ class TaskInstanceInfo(InfoJsonEncodable):
 
     includes = ["duration", "try_number", "pool", "queued_dttm", "log_url"]
     casts = {
+        "log_url": lambda ti: getattr(ti, "log_url", None),

Review Comment:
   I'm not sure if it needs to be here. It's already present in `includes` above, so it should work exactly like `getattr(ti, "log_url", None)`. Can you remove it ant see?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org