[GitHub] [netbeans] jtulach commented on issue #1241: [NETBEANS-2506] Added OpenJFX Samples module to JavaFX cluster.

[GitBox <gi...@apache.org>]

jtulach commented on issue #1241: [NETBEANS-2506] Added OpenJFX Samples module to JavaFX cluster.
URL: https://github.com/apache/netbeans/pull/1241#issuecomment-491357016
 
 
   > Makes sense to me, and many thanks for this contribution from Gluon, may there be more!
   
   @geertjanw, I understand that you are excited seeing new contributor. Actually I am as well. Welcome José. 
   
   That however doesn't mean that the contribution make sense to me.
   
   > ... just the application of the [JavaFX Maven archetypes](https://github.com/openjfx/javafx-maven-archetypes), 
   
   Good. There is an archetype. 
   
   > via `New Project -> Java with Maven -> Project from Archetype`, 
   
   I see. This is not the most straightforward way to integrate a technology into NetBeans. JavaFX indeed deserves a better wizard!
   
   > However, the purpose of this PR is to "bundle the Open JFX NetBeans samples", so while these two samples are the same anyone could generate via archetypes or via the [OpenJFX samples repository](https://github.com/openjfx/samples/blob/master/IDE/NetBeans/Modular/Maven), the user will get them ready to use from `New Project -> Samples`.
   
   There already is "New Project/Java with Maven/JavaFX Application" - why don't you rather fix/modify that one to be a nice UI over the archetypes? NetBeans has a nice support for creating wizards over Maven archetypes. I suggest to use it.
   
   > What's more, these samples are a little bit more integrated with NetBeans (they contain custom nbactions that override `run` and `debug` default actions).
   
   I'd suggest to put those files into the archetypes. Unless I am mistaken @eppleton does that for the DukeScript archetypes. Unacceptable? Even if hidden by a archetype property?
   
   José, please don't let me discourage you. We need Gluon to polish the JavaFX integration in NetBeans. I just want to do it the right "Maven (UI) way". I'd like NetBeans to be the _UI for Maven_ - e.g. just a wizard that harnesses Maven and its archetypes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists