[GitHub] [incubator-tvm] comaniac commented on issue #4771: [Relay] Added Merge Composite pass

[GitBox <gi...@apache.org>]

comaniac commented on issue #4771: [Relay] Added Merge Composite pass
URL: https://github.com/apache/incubator-tvm/pull/4771#issuecomment-579014540
 
 
   So you want the flow to be:
   ```
   CompositeMerge -> Annotation -> Partitioning. 
   ```
   I agree that this would make annotation generic and straightforward, although it seems like we don't need annotation anymore if we specify all patterns including single ops. While there are lots of approaches to do so, maybe we could accept this solution first and consider the further steps. What you do think? @zhiics 
   
   Also, please help clarify the question asked by @masahi and me about multiple matching. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services