You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by li...@apache.org on 2021/12/11 10:46:11 UTC
[dubbo] 02/02: fix shared metadata info being deleted unexpectedly
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch 3.0-metadata-refactor
in repository https://gitbox.apache.org/repos/asf/dubbo.git
commit 94cd246e694312f7d0826e90d2f0ce3e7372cf1b
Author: ken.lj <ke...@gmail.com>
AuthorDate: Sat Dec 11 18:45:13 2021 +0800
fix shared metadata info being deleted unexpectedly
---
.../org/apache/dubbo/registry/client/AbstractServiceDiscovery.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/AbstractServiceDiscovery.java b/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/AbstractServiceDiscovery.java
index dab0e03..51532f9 100644
--- a/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/AbstractServiceDiscovery.java
+++ b/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/AbstractServiceDiscovery.java
@@ -124,7 +124,8 @@ public abstract class AbstractServiceDiscovery implements ServiceDiscovery {
@Override
public synchronized void unregister() throws RuntimeException {
- unReportMetadata(this.metadataInfo);
+ // fixme, this metadata info may still being shared by other instances
+// unReportMetadata(this.metadataInfo);
doUnregister(this.serviceInstance);
}