You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "lizhimins (via GitHub)" <gi...@apache.org> on 2023/09/16 07:35:53 UTC
[GitHub] [rocketmq] lizhimins opened a new pull request, #7365: [ISSUE #7363] Fix get message from tiered storage return incorrect next begin offset
lizhimins opened a new pull request, #7365:
URL: https://github.com/apache/rocketmq/pull/7365
…xt pull offset
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7363
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #7365: [ISSUE #7363] Fix get message from tiered storage return incorrect next begin offset
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7365:
URL: https://github.com/apache/rocketmq/pull/7365#issuecomment-1722169546
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7365](https://app.codecov.io/gh/apache/rocketmq/pull/7365?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6a08f1f) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/4a8e0d5b851d1f9573cda79b7d2e42ee498809da?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4a8e0d5) will **decrease** coverage by `0.14%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## develop #7365 +/- ##
=============================================
- Coverage 42.68% 42.54% -0.14%
+ Complexity 9482 9443 -39
=============================================
Files 1150 1150
Lines 82729 82727 -2
Branches 10777 10775 -2
=============================================
- Hits 35311 35195 -116
- Misses 43012 43125 +113
- Partials 4406 4407 +1
```
| [Files Changed](https://app.codecov.io/gh/apache/rocketmq/pull/7365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/rocketmq/tieredstore/TieredMessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL1RpZXJlZE1lc3NhZ2VTdG9yZS5qYXZh) | `70.42% <66.66%> (-3.07%)` | :arrow_down: |
| [...che/rocketmq/tieredstore/TieredMessageFetcher.java](https://app.codecov.io/gh/apache/rocketmq/pull/7365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL1RpZXJlZE1lc3NhZ2VGZXRjaGVyLmphdmE=) | `59.20% <100.00%> (ø)` | |
... and [45 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7365/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lollipopjin merged pull request #7365: [ISSUE #7363] Fix get message from tiered storage return incorrect next begin offset
Posted by "lollipopjin (via GitHub)" <gi...@apache.org>.
lollipopjin merged PR #7365:
URL: https://github.com/apache/rocketmq/pull/7365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org