[GitHub] [hbase] HorizonNet commented on a change in pull request #1723: HBASE-24381 The Size metrics in Master Webui is wrong if the size is 0

[GitBox <gi...@apache.org>]

HorizonNet commented on a change in pull request #1723:
URL: https://github.com/apache/hbase/pull/1723#discussion_r426174769



##########
File path: hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
##########
@@ -162,10 +162,10 @@ Arrays.sort(serverNames);
 <tbody>
 <%java>
 final String ZEROMB = "0 MB";
-String usedHeapStr = ZEROMB;
-String maxHeapStr = ZEROMB;
-String memStoreSizeMBStr = ZEROMB;
 for (ServerName serverName: serverNames) {
+    String usedHeapStr = ZEROMB;

Review comment:
       Indentation seems to be different here compared to the other changes.

##########
File path: hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
##########
@@ -276,12 +276,12 @@ if (sl != null) {
 <%java>
 final String ZEROKB = "0 KB";
 final String ZEROMB = "0 MB";
+for (ServerName serverName: serverNames) {
+
 String storeUncompressedSizeMBStr = ZEROMB;

Review comment:
       Ditto.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org