You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org> on 2010/04/20 18:18:49 UTC
[jira] Created: (PORTLETBRIDGE-140) Ensure invocation of
buildView() in PortletJspViewDeclarationLanguageImpl
Ensure invocation of buildView() in PortletJspViewDeclarationLanguageImpl
-------------------------------------------------------------------------
Key: PORTLETBRIDGE-140
URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-140
Project: MyFaces Portlet Bridge
Issue Type: Task
Components: Impl
Environment: sobryan_portlet-bridge-3.0.0 branch
Reporter: Jakob Korherr
Assignee: Scott O'Bryan
On MYFACES-2665 we got an error report that JSPs are not working with legacy ViewHandler implementations. After some digging on the issue I found out that VDL.buildView() is never called, because getViewDeclarationLanguage() returns null on a legacy ViewHandler. However this has to be called in order to work properly, so I committed a solution that memorizes if VDL.buildView() has been called and if not, it calls it from VDL.renderView() before the real rendering happens (see [1] for details). This solves the problem.
However some code I had to change is from shared and is also used by the Portlet Bridge (JspViewDeclarationLanguageBase). So in order to work properly, PortletJspViewDeclarationLanguageImpl has to call super.buildView() in its buildView() method to do the "memorizing" (just as JspViewDeclarationLanguage does). Otherwise buildView() will be called twice on PortletJspViewDeclarationLanguageImpl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PORTLETBRIDGE-140) Ensure invocation of
buildView() in PortletJspViewDeclarationLanguageImpl
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr updated PORTLETBRIDGE-140:
----------------------------------------
Status: Patch Available (was: Open)
> Ensure invocation of buildView() in PortletJspViewDeclarationLanguageImpl
> -------------------------------------------------------------------------
>
> Key: PORTLETBRIDGE-140
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-140
> Project: MyFaces Portlet Bridge
> Issue Type: Task
> Components: Impl
> Environment: sobryan_portlet-bridge-3.0.0 branch
> Reporter: Jakob Korherr
> Assignee: Scott O'Bryan
> Attachments: PORTLETBRIDGE-140.patch
>
>
> On MYFACES-2665 we got an error report that JSPs are not working with legacy ViewHandler implementations. After some digging on the issue I found out that VDL.buildView() is never called, because getViewDeclarationLanguage() returns null on a legacy ViewHandler. However this has to be called in order to work properly, so I committed a solution that memorizes if VDL.buildView() has been called and if not, it calls it from VDL.renderView() before the real rendering happens (see [1] for details). This solves the problem.
> However some code I had to change is from shared and is also used by the Portlet Bridge (JspViewDeclarationLanguageBase). So in order to work properly, PortletJspViewDeclarationLanguageImpl has to call super.buildView() in its buildView() method to do the "memorizing" (just as JspViewDeclarationLanguage does). Otherwise buildView() will be called twice on PortletJspViewDeclarationLanguageImpl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PORTLETBRIDGE-140) Ensure invocation of
buildView() in PortletJspViewDeclarationLanguageImpl
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859318#action_12859318 ]
Jakob Korherr commented on PORTLETBRIDGE-140:
---------------------------------------------
I forgot to append the link to the description..
[1] http://svn.apache.org/viewvc?view=revision&revision=935971
> Ensure invocation of buildView() in PortletJspViewDeclarationLanguageImpl
> -------------------------------------------------------------------------
>
> Key: PORTLETBRIDGE-140
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-140
> Project: MyFaces Portlet Bridge
> Issue Type: Task
> Components: Impl
> Environment: sobryan_portlet-bridge-3.0.0 branch
> Reporter: Jakob Korherr
> Assignee: Scott O'Bryan
> Attachments: PORTLETBRIDGE-140.patch
>
>
> On MYFACES-2665 we got an error report that JSPs are not working with legacy ViewHandler implementations. After some digging on the issue I found out that VDL.buildView() is never called, because getViewDeclarationLanguage() returns null on a legacy ViewHandler. However this has to be called in order to work properly, so I committed a solution that memorizes if VDL.buildView() has been called and if not, it calls it from VDL.renderView() before the real rendering happens (see [1] for details). This solves the problem.
> However some code I had to change is from shared and is also used by the Portlet Bridge (JspViewDeclarationLanguageBase). So in order to work properly, PortletJspViewDeclarationLanguageImpl has to call super.buildView() in its buildView() method to do the "memorizing" (just as JspViewDeclarationLanguage does). Otherwise buildView() will be called twice on PortletJspViewDeclarationLanguageImpl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.