You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Dennis Lundberg <de...@apache.org> on 2015/01/08 15:51:57 UTC
Releasing the Checkstyle Plugin
Hi,
I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
motive for 2.14 is the ability to check Java 8 source code.
According to the road map there are 5 unresolved issues scheduled for 2.14.
https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jira.plugin.system.project%3Aroadmap-panel
If anyone is interested in fixing one or more of these for 2.14 now
would be a good time to do it. Just reply here with an estimated time
frame. If noone has the time for this now, I'll reschedule those
issues for 2.15, which will require Java 6.
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Henning Schmiedehausen <he...@schmiedehausen.org>.
On Wed, Jan 21, 2015 at 11:49 PM, Dennis Lundberg <de...@apache.org> wrote:
> On Thu, Jan 22, 2015 at 5:29 AM, Hervé BOUTEMY <he...@free.fr> wrote:
>> Le mercredi 21 janvier 2015 14:44:27 Dennis Lundberg a écrit :
>>> There is some piece of code in Checkstyle 5.9 that uses Java 6+
>>> classes/methods. I don't remember where, but it isn't covered by our
>>> integration tests.
>> since our ITs use the 3 integrated rulesets, I suppose this is in a rule that
>> isn't used by these rulesets
>> Notice: the animalsniffer check you added doesn't check dependency jars full
>> content?
>
> No, and I don't think we can get that from our end. We had newer Java
> versions leaking into Apache Rat, and I solved those by adding a
> combination of animal-sniffer and enforcer plugin. But I don't think
> that can check the sources of the dependencies. It's a mystery to me
> how they managed to build Checkstyle 5.9 at all. When I check out the
> 5.9 tag from git and try to build it using Java 1.5 I get these
> errors:
Java 6 or 7 compiler with java6 rt.jar and -source 1.5 -target 1.5
Unfortunately the result does not actually work on JDK5. :-/
-h
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Dennis Lundberg <de...@apache.org>.
On Thu, Jan 22, 2015 at 5:29 AM, Hervé BOUTEMY <he...@free.fr> wrote:
> Le mercredi 21 janvier 2015 14:44:27 Dennis Lundberg a écrit :
>> There is some piece of code in Checkstyle 5.9 that uses Java 6+
>> classes/methods. I don't remember where, but it isn't covered by our
>> integration tests.
> since our ITs use the 3 integrated rulesets, I suppose this is in a rule that
> isn't used by these rulesets
> Notice: the animalsniffer check you added doesn't check dependency jars full
> content?
No, and I don't think we can get that from our end. We had newer Java
versions leaking into Apache Rat, and I solved those by adding a
combination of animal-sniffer and enforcer plugin. But I don't think
that can check the sources of the dependencies. It's a mystery to me
how they managed to build Checkstyle 5.9 at all. When I check out the
5.9 tag from git and try to build it using Java 1.5 I get these
errors:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile
(default-compile) on project checkstyle: Compilation failure:
Compilation failure:
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\DeclarationCollector.java:[29,17]
cannot find symbol
[ERROR] symbol : class Deque
[ERROR] location: package java.util
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\DeclarationCollector.java:[99,37]
cannot find symbol
[ERROR] symbol : class Deque
[ERROR] location: class
com.puppycrawl.tools.checkstyle.checks.DeclarationCollector
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\coding\VariableDeclarationUsageDistanceCheck.java:[21,29]
java.util.AbstractMap.SimpleEntry is not public in
java.util.AbstractMap; cannot be accessed from outside package
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\indentation\LineWrappingHandler.java:[23,17]
cannot find symbol
[ERROR] symbol : class NavigableMap
[ERROR] location: package java.util
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\indentation\LineWrappingHandler.java:[188,12]
cannot find symbol
[ERROR] symbol : class NavigableMap
[ERROR] location: class
com.puppycrawl.tools.checkstyle.checks.indentation.LineWrappingHandler
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\indentation\LineWrappingHandler.java:[244,12]
cannot find symbol
[ERROR] symbol : class NavigableMap
[ERROR] location: class
com.puppycrawl.tools.checkstyle.checks.indentation.LineWrappingHandler
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\whitespace\EmptyLineSeparatorCheck.java:[208,30]
cannot find symbol
[ERROR] symbol : method isEmpty()
[ERROR] location: class java.lang.String
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\indentation\LineWrappingHandler.java:[119,14]
cannot find symbol
[ERROR] symbol : class NavigableMap
[ERROR] location: class
com.puppycrawl.tools.checkstyle.checks.indentation.LineWrappingHandler
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\indentation\LineWrappingHandler.java:[190,14]
cannot find symbol
[ERROR] symbol : class NavigableMap
[ERROR] location: class
com.puppycrawl.tools.checkstyle.checks.indentation.LineWrappingHandler
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\DeclarationCollector.java:[55,14]
cannot find symbol
[ERROR] symbol : class Deque
[ERROR] location: class
com.puppycrawl.tools.checkstyle.checks.DeclarationCollector
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\coding\VariableDeclarationUsageDistanceCheck.java:[348,36]
cannot find symbol
[ERROR] symbol : method isEmpty()
[ERROR] location: class java.lang.String
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\coding\VariableDeclarationUsageDistanceCheck.java:[353,45]
cannot find symbol
[ERROR] symbol : method isEmpty()
[ERROR] location: class java.lang.String
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\coding\VariableDeclarationUsageDistanceCheck.java:[453,19]
cannot find symbol
[ERROR] symbol : class SimpleEntry
[ERROR] location: class
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\coding\VariableDeclarationUsageDistanceCheck.java:[544,19]
cannot find symbol
[ERROR] symbol : class SimpleEntry
[ERROR] location: class
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck
[ERROR] \Users\dlg01\git\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\checks\imports\CustomImportOrderCheck.java:[616,30]
cannot find symbol
[ERROR] symbol : method isEmpty()
[ERROR] location: class java.lang.String
>
>> I'll have a look at it tomorrow evening, and see if
>> I can produce an IT that catches it.
> yes, and if we find it, we'll open an issue to Checkstyle since that was not
> supposed to happen: that's what's told on release notes for Checkstyle 6.0
There's not much they can do about it at this time.
>>
>> Another thing that I have been thinking about is whether we should
>> move maven_checks.xml out of maven-checkstyle-plugin and into a
>> separate resource jar. The rationale being that we (the Maven project)
>> will probably be stuck using maven-checkstyle-plugin 2.14 (for Java 5
>> projects) and 2.15 (for Java 6 projects)
> just for sake of discussion about minimum Maven and Java requirements, I'd say
> it as:
> - maven-checkstyle-plugin 2.14 for projects built with Maven 2.2.1+Java 5
> requirements
> - maven-checkstyle-plugin 2.15 (or 3.0) for projects built with Maven 3+Java 6
> requirement, which is our next plugin requirement level (and associated
> numbering)
Sounds good
>> . What happens when 2.16 is
>> released and we want to change maven_checks.xml?
> I don't like the idea to have a plugin forcing Java requirement upgrade,
> especially when mostly a reporting plugin (since not everybody do Checkstyle
> checked builds)
> But that's another discussion: to be done later
I agree, let's have that discussion later on.
> yes, moving maven_checks.xml out of the plugin would be a solution.
> For our Maven projects, moving the file to Maven parent POM would be IMHO a
> good target: that's what others are supposed to do when they write their own
> ruleset, then why don't we do the same?
> Since Checkstyle 6.2 provides Sun (and Google) rulesets (see MCHECKSTYLE-268),
> removing maven_checks while removing sun_checks would fit, IMHO
Yes I see those fitting together nicely.
> And this could even fix my previous comment on 2.16: IMHO, our plugin should
> stay with Checkstyle 6.1 as default since it is the last with Java 6
> requirement, and end-users can upgrade Checkstyle independently as they want
I'm starting to lean towards this as well.
> then definitely, yes, moving maven_checks.xml out of maven-checkstyle-plugin is
> definitely a good plan to me
> Just avoid a new resource jar: just use Maven parent POM.
But Maven parent POM has type=pom so we cannot add any files to it...
I was thinking of putting it into
http://maven.apache.org/shared/maven-shared-resources/
which is an existing resource project used for this purpose.
> Regards,
>
> Hervé
>
>>
>> On Wed, Jan 21, 2015 at 9:04 AM, Hervé BOUTEMY <he...@free.fr>
> wrote:
>> > Le vendredi 9 janvier 2015 13:29:06 Dennis Lundberg a écrit :
>> >> I've started going through the open issues and have found a problem
>> >> that I need som help with. It turns out that Checkstyle 5.9 uses Java
>> >> 6 classes, even though it is not mentioned in the release notes. How
>> >> do we want to handle this? I see two possible options:
>> >>
>> >> 1. Make version 2.14 of the plugin require Java 6, and update it to
>> >> use the latest available version of Checkstyle that runs on Java 6.
>> >>
>> >> 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>> >> plugin with a Java 5 requirement. After that release 2.15 of the
>> >> plugin fairly straight away with a Java 6 requirement, and using the
>> >> latest available version of Checkstyle that runs on Java 6. It should
>> >> be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>> >>
>> >> Perhaps there are other alternatives? What do you think?
>> >
>> > I just built and ran ITs with Checkstyle 5.9 on JDK5 without any issue:
>> > can
>> > you check too? Since Checkstyle 5.9 supports Java 8 syntax, upgrading
>> > would be really great while keeping our plan for minimum Java version
>> > This is key before releasing
>> >
>> > Everyting else I wanted to fix/improve for the next release is done
>> > I'll be happy to vote on a release I'm not managing myself :)
>> >
>> > Regards,
>> >
>> > Hervé
>> >
>> >> On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
> wrote:
>> >> > Hi,
>> >> >
>> >> > I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>> >> > motive for 2.14 is the ability to check Java 8 source code.
>> >> >
>> >> > According to the road map there are 5 unresolved issues scheduled for
>> >> > 2.14.
>> >> >
>> >> > https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.
>> >> > jir
>> >> > a.plugin.system.project%3Aroadmap-panel
>> >> >
>> >> > If anyone is interested in fixing one or more of these for 2.14 now
>> >> > would be a good time to do it. Just reply here with an estimated time
>> >> > frame. If noone has the time for this now, I'll reschedule those
>> >> > issues for 2.15, which will require Java 6.
>> >> >
>> >> > --
>> >> > Dennis Lundberg
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Hervé BOUTEMY <he...@free.fr>.
Le mercredi 21 janvier 2015 14:44:27 Dennis Lundberg a écrit :
> There is some piece of code in Checkstyle 5.9 that uses Java 6+
> classes/methods. I don't remember where, but it isn't covered by our
> integration tests.
since our ITs use the 3 integrated rulesets, I suppose this is in a rule that
isn't used by these rulesets
Notice: the animalsniffer check you added doesn't check dependency jars full
content?
> I'll have a look at it tomorrow evening, and see if
> I can produce an IT that catches it.
yes, and if we find it, we'll open an issue to Checkstyle since that was not
supposed to happen: that's what's told on release notes for Checkstyle 6.0
>
> Another thing that I have been thinking about is whether we should
> move maven_checks.xml out of maven-checkstyle-plugin and into a
> separate resource jar. The rationale being that we (the Maven project)
> will probably be stuck using maven-checkstyle-plugin 2.14 (for Java 5
> projects) and 2.15 (for Java 6 projects)
just for sake of discussion about minimum Maven and Java requirements, I'd say
it as:
- maven-checkstyle-plugin 2.14 for projects built with Maven 2.2.1+Java 5
requirements
- maven-checkstyle-plugin 2.15 (or 3.0) for projects built with Maven 3+Java 6
requirement, which is our next plugin requirement level (and associated
numbering)
> . What happens when 2.16 is
> released and we want to change maven_checks.xml?
I don't like the idea to have a plugin forcing Java requirement upgrade,
especially when mostly a reporting plugin (since not everybody do Checkstyle
checked builds)
But that's another discussion: to be done later
yes, moving maven_checks.xml out of the plugin would be a solution.
For our Maven projects, moving the file to Maven parent POM would be IMHO a
good target: that's what others are supposed to do when they write their own
ruleset, then why don't we do the same?
Since Checkstyle 6.2 provides Sun (and Google) rulesets (see MCHECKSTYLE-268),
removing maven_checks while removing sun_checks would fit, IMHO
And this could even fix my previous comment on 2.16: IMHO, our plugin should
stay with Checkstyle 6.1 as default since it is the last with Java 6
requirement, and end-users can upgrade Checkstyle independently as they want
then definitely, yes, moving maven_checks.xml out of maven-checkstyle-plugin is
definitely a good plan to me
Just avoid a new resource jar: just use Maven parent POM.
Regards,
Hervé
>
> On Wed, Jan 21, 2015 at 9:04 AM, Hervé BOUTEMY <he...@free.fr>
wrote:
> > Le vendredi 9 janvier 2015 13:29:06 Dennis Lundberg a écrit :
> >> I've started going through the open issues and have found a problem
> >> that I need som help with. It turns out that Checkstyle 5.9 uses Java
> >> 6 classes, even though it is not mentioned in the release notes. How
> >> do we want to handle this? I see two possible options:
> >>
> >> 1. Make version 2.14 of the plugin require Java 6, and update it to
> >> use the latest available version of Checkstyle that runs on Java 6.
> >>
> >> 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
> >> plugin with a Java 5 requirement. After that release 2.15 of the
> >> plugin fairly straight away with a Java 6 requirement, and using the
> >> latest available version of Checkstyle that runs on Java 6. It should
> >> be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
> >>
> >> Perhaps there are other alternatives? What do you think?
> >
> > I just built and ran ITs with Checkstyle 5.9 on JDK5 without any issue:
> > can
> > you check too? Since Checkstyle 5.9 supports Java 8 syntax, upgrading
> > would be really great while keeping our plan for minimum Java version
> > This is key before releasing
> >
> > Everyting else I wanted to fix/improve for the next release is done
> > I'll be happy to vote on a release I'm not managing myself :)
> >
> > Regards,
> >
> > Hervé
> >
> >> On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
wrote:
> >> > Hi,
> >> >
> >> > I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
> >> > motive for 2.14 is the ability to check Java 8 source code.
> >> >
> >> > According to the road map there are 5 unresolved issues scheduled for
> >> > 2.14.
> >> >
> >> > https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.
> >> > jir
> >> > a.plugin.system.project%3Aroadmap-panel
> >> >
> >> > If anyone is interested in fixing one or more of these for 2.14 now
> >> > would be a good time to do it. Just reply here with an estimated time
> >> > frame. If noone has the time for this now, I'll reschedule those
> >> > issues for 2.15, which will require Java 6.
> >> >
> >> > --
> >> > Dennis Lundberg
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Dennis Lundberg <de...@apache.org>.
Benson, please have a look at the road map in JIRA.
The talk about Checkstyle 5.9 regards the 2.14 release that we have
been preparing for during the last couple of weeks.
On Wed, Jan 21, 2015 at 2:52 PM, Benson Margulies <bi...@gmail.com> wrote:
> I'm confused. The current version of checkstyle is 6.2. Why is this
> discussion about 5.9? Should we make a branch that requires java
> whatever and is actually current?
>
> On Wed, Jan 21, 2015 at 8:44 AM, Dennis Lundberg <de...@apache.org> wrote:
>> There is some piece of code in Checkstyle 5.9 that uses Java 6+
>> classes/methods. I don't remember where, but it isn't covered by our
>> integration tests. I'll have a look at it tomorrow evening, and see if
>> I can produce an IT that catches it.
>>
>> Another thing that I have been thinking about is whether we should
>> move maven_checks.xml out of maven-checkstyle-plugin and into a
>> separate resource jar. The rationale being that we (the Maven project)
>> will probably be stuck using maven-checkstyle-plugin 2.14 (for Java 5
>> projects) and 2.15 (for Java 6 projects). What happens when 2.16 is
>> released and we want to change maven_checks.xml?
>>
>>
>> On Wed, Jan 21, 2015 at 9:04 AM, Hervé BOUTEMY <he...@free.fr> wrote:
>>> Le vendredi 9 janvier 2015 13:29:06 Dennis Lundberg a écrit :
>>>> I've started going through the open issues and have found a problem
>>>> that I need som help with. It turns out that Checkstyle 5.9 uses Java
>>>> 6 classes, even though it is not mentioned in the release notes. How
>>>> do we want to handle this? I see two possible options:
>>>>
>>>> 1. Make version 2.14 of the plugin require Java 6, and update it to
>>>> use the latest available version of Checkstyle that runs on Java 6.
>>>>
>>>> 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>>>> plugin with a Java 5 requirement. After that release 2.15 of the
>>>> plugin fairly straight away with a Java 6 requirement, and using the
>>>> latest available version of Checkstyle that runs on Java 6. It should
>>>> be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>>>>
>>>> Perhaps there are other alternatives? What do you think?
>>> I just built and ran ITs with Checkstyle 5.9 on JDK5 without any issue: can
>>> you check too? Since Checkstyle 5.9 supports Java 8 syntax, upgrading would be
>>> really great while keeping our plan for minimum Java version
>>> This is key before releasing
>>>
>>> Everyting else I wanted to fix/improve for the next release is done
>>> I'll be happy to vote on a release I'm not managing myself :)
>>>
>>> Regards,
>>>
>>> Hervé
>>>>
>>>> On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org> wrote:
>>>> > Hi,
>>>> >
>>>> > I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>>>> > motive for 2.14 is the ability to check Java 8 source code.
>>>> >
>>>> > According to the road map there are 5 unresolved issues scheduled for
>>>> > 2.14.
>>>> >
>>>> > https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jir
>>>> > a.plugin.system.project%3Aroadmap-panel
>>>> >
>>>> > If anyone is interested in fixing one or more of these for 2.14 now
>>>> > would be a good time to do it. Just reply here with an estimated time
>>>> > frame. If noone has the time for this now, I'll reschedule those
>>>> > issues for 2.15, which will require Java 6.
>>>> >
>>>> > --
>>>> > Dennis Lundberg
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>>
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Benson Margulies <bi...@gmail.com>.
I'm confused. The current version of checkstyle is 6.2. Why is this
discussion about 5.9? Should we make a branch that requires java
whatever and is actually current?
On Wed, Jan 21, 2015 at 8:44 AM, Dennis Lundberg <de...@apache.org> wrote:
> There is some piece of code in Checkstyle 5.9 that uses Java 6+
> classes/methods. I don't remember where, but it isn't covered by our
> integration tests. I'll have a look at it tomorrow evening, and see if
> I can produce an IT that catches it.
>
> Another thing that I have been thinking about is whether we should
> move maven_checks.xml out of maven-checkstyle-plugin and into a
> separate resource jar. The rationale being that we (the Maven project)
> will probably be stuck using maven-checkstyle-plugin 2.14 (for Java 5
> projects) and 2.15 (for Java 6 projects). What happens when 2.16 is
> released and we want to change maven_checks.xml?
>
>
> On Wed, Jan 21, 2015 at 9:04 AM, Hervé BOUTEMY <he...@free.fr> wrote:
>> Le vendredi 9 janvier 2015 13:29:06 Dennis Lundberg a écrit :
>>> I've started going through the open issues and have found a problem
>>> that I need som help with. It turns out that Checkstyle 5.9 uses Java
>>> 6 classes, even though it is not mentioned in the release notes. How
>>> do we want to handle this? I see two possible options:
>>>
>>> 1. Make version 2.14 of the plugin require Java 6, and update it to
>>> use the latest available version of Checkstyle that runs on Java 6.
>>>
>>> 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>>> plugin with a Java 5 requirement. After that release 2.15 of the
>>> plugin fairly straight away with a Java 6 requirement, and using the
>>> latest available version of Checkstyle that runs on Java 6. It should
>>> be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>>>
>>> Perhaps there are other alternatives? What do you think?
>> I just built and ran ITs with Checkstyle 5.9 on JDK5 without any issue: can
>> you check too? Since Checkstyle 5.9 supports Java 8 syntax, upgrading would be
>> really great while keeping our plan for minimum Java version
>> This is key before releasing
>>
>> Everyting else I wanted to fix/improve for the next release is done
>> I'll be happy to vote on a release I'm not managing myself :)
>>
>> Regards,
>>
>> Hervé
>>>
>>> On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org> wrote:
>>> > Hi,
>>> >
>>> > I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>>> > motive for 2.14 is the ability to check Java 8 source code.
>>> >
>>> > According to the road map there are 5 unresolved issues scheduled for
>>> > 2.14.
>>> >
>>> > https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jir
>>> > a.plugin.system.project%3Aroadmap-panel
>>> >
>>> > If anyone is interested in fixing one or more of these for 2.14 now
>>> > would be a good time to do it. Just reply here with an estimated time
>>> > frame. If noone has the time for this now, I'll reschedule those
>>> > issues for 2.15, which will require Java 6.
>>> >
>>> > --
>>> > Dennis Lundberg
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Dennis Lundberg <de...@apache.org>.
There is some piece of code in Checkstyle 5.9 that uses Java 6+
classes/methods. I don't remember where, but it isn't covered by our
integration tests. I'll have a look at it tomorrow evening, and see if
I can produce an IT that catches it.
Another thing that I have been thinking about is whether we should
move maven_checks.xml out of maven-checkstyle-plugin and into a
separate resource jar. The rationale being that we (the Maven project)
will probably be stuck using maven-checkstyle-plugin 2.14 (for Java 5
projects) and 2.15 (for Java 6 projects). What happens when 2.16 is
released and we want to change maven_checks.xml?
On Wed, Jan 21, 2015 at 9:04 AM, Hervé BOUTEMY <he...@free.fr> wrote:
> Le vendredi 9 janvier 2015 13:29:06 Dennis Lundberg a écrit :
>> I've started going through the open issues and have found a problem
>> that I need som help with. It turns out that Checkstyle 5.9 uses Java
>> 6 classes, even though it is not mentioned in the release notes. How
>> do we want to handle this? I see two possible options:
>>
>> 1. Make version 2.14 of the plugin require Java 6, and update it to
>> use the latest available version of Checkstyle that runs on Java 6.
>>
>> 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>> plugin with a Java 5 requirement. After that release 2.15 of the
>> plugin fairly straight away with a Java 6 requirement, and using the
>> latest available version of Checkstyle that runs on Java 6. It should
>> be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>>
>> Perhaps there are other alternatives? What do you think?
> I just built and ran ITs with Checkstyle 5.9 on JDK5 without any issue: can
> you check too? Since Checkstyle 5.9 supports Java 8 syntax, upgrading would be
> really great while keeping our plan for minimum Java version
> This is key before releasing
>
> Everyting else I wanted to fix/improve for the next release is done
> I'll be happy to vote on a release I'm not managing myself :)
>
> Regards,
>
> Hervé
>>
>> On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org> wrote:
>> > Hi,
>> >
>> > I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>> > motive for 2.14 is the ability to check Java 8 source code.
>> >
>> > According to the road map there are 5 unresolved issues scheduled for
>> > 2.14.
>> >
>> > https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jir
>> > a.plugin.system.project%3Aroadmap-panel
>> >
>> > If anyone is interested in fixing one or more of these for 2.14 now
>> > would be a good time to do it. Just reply here with an estimated time
>> > frame. If noone has the time for this now, I'll reschedule those
>> > issues for 2.15, which will require Java 6.
>> >
>> > --
>> > Dennis Lundberg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Hervé BOUTEMY <he...@free.fr>.
Le vendredi 9 janvier 2015 13:29:06 Dennis Lundberg a écrit :
> I've started going through the open issues and have found a problem
> that I need som help with. It turns out that Checkstyle 5.9 uses Java
> 6 classes, even though it is not mentioned in the release notes. How
> do we want to handle this? I see two possible options:
>
> 1. Make version 2.14 of the plugin require Java 6, and update it to
> use the latest available version of Checkstyle that runs on Java 6.
>
> 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
> plugin with a Java 5 requirement. After that release 2.15 of the
> plugin fairly straight away with a Java 6 requirement, and using the
> latest available version of Checkstyle that runs on Java 6. It should
> be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>
> Perhaps there are other alternatives? What do you think?
I just built and ran ITs with Checkstyle 5.9 on JDK5 without any issue: can
you check too? Since Checkstyle 5.9 supports Java 8 syntax, upgrading would be
really great while keeping our plan for minimum Java version
This is key before releasing
Everyting else I wanted to fix/improve for the next release is done
I'll be happy to vote on a release I'm not managing myself :)
Regards,
Hervé
>
> On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org> wrote:
> > Hi,
> >
> > I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
> > motive for 2.14 is the ability to check Java 8 source code.
> >
> > According to the road map there are 5 unresolved issues scheduled for
> > 2.14.
> >
> > https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jir
> > a.plugin.system.project%3Aroadmap-panel
> >
> > If anyone is interested in fixing one or more of these for 2.14 now
> > would be a good time to do it. Just reply here with an estimated time
> > frame. If noone has the time for this now, I'll reschedule those
> > issues for 2.15, which will require Java 6.
> >
> > --
> > Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Hervé BOUTEMY <he...@free.fr>.
the changes are at canonical repo, ie ASF svn
see http://jira.codehaus.org/browse/MCHECKSTYLE-276
I suppose github mirror is a little bit behind
Regards,
Hervé
Le samedi 17 janvier 2015 09:39:16 Henning Schmiedehausen a écrit :
> As long as I can just drop in 6.2 and the plugin does not break (as it
> does today), I am fine.
>
> We are running our own checkstyle ruleset anyway, it is just the
> default that does not work well.
>
> Where are your changes, I haven't seen them on the trunk @ github.
>
> -h
>
> On Sat, Jan 17, 2015 at 9:30 AM, Hervé BOUTEMY <he...@free.fr>
wrote:
> > yes, i know you did that in the branch to test upgrade for a release with
> > Checkstyle 6.2 as default version
> >
> > I did it in trunk, even without changing Checkstyle version: even if
> > maven-
> > checkstyle-plugin ships with an older Checkstyle version as default
> > dependency, end-users can now upgrade the dependency when using the plugin
> >
> > Regards,
> >
> > Hervé
> >
> > Le samedi 17 janvier 2015 09:17:08 Henning Schmiedehausen a écrit :
> >> I already did that. See https://github.com/apache/maven-plugins/pull/42
> >>
> >> -h
> >>
> >> On Sat, Jan 17, 2015 at 9:02 AM, Hervé BOUTEMY <he...@free.fr>
> >
> > wrote:
> >> > Le mercredi 14 janvier 2015 11:08:40 Henning Schmiedehausen a écrit :
> >> >> The 6.2 checkstyle requires java 7 and it also removes (!) at least
> >> >> one of the checks (RedundantThrows) which is used in all shipped
> >> >> checkstyle sets and one of the integration tests. So you can no longer
> >> >> use any of the builtin styles but have to use a custom style which has
> >> >> the RedundantThrows check removed.
> >> >
> >> > the RedundantThrows check causes a lot of false positives: it is maked
> >> > as
> >> > "ingore" in Maven parent pom
> >> > I'll remove it from default configs for next release: see
> >> > MCHECKSTYLE-276
> >> >
> >> >> Having code that can dynamically discover whether a given check exists
> >> >> or not and change the configuration accordingly is something that
> >> >> probably would need to be done inside checkstyle proper, not the
> >> >> plugin driving it.
> >> >>
> >> >> I have a pull request prepared (not pushed yet) which would upgrade
> >> >> checkstyle and the build to java 7 for a possible 2.16 release. One of
> >> >> the problems here is that at least one integration test will not pass
> >> >> until the patch was applied to trunk (because it remote-loads the rule
> >> >> set from the svn repo which in turn currently still has the bad rule).
> >> >>
> >> >> It is all a mess and prolonging it to accomodate the one hold-out on
> >> >> Java 5 (which is EOLed for > 5 years now) and the few that insist on
> >> >> using Java 6 (which is EOLed for ~ 2 years) makes no sense to me. We
> >> >> should lead, not lag behind.
> >> >>
> >> >> -h
> >> >>
> >> >> On Tue, Jan 13, 2015 at 11:09 PM, Hervé BOUTEMY
> >> >> <he...@free.fr>
> >> >
> >> > wrote:
> >> >> > question: is upgrading only a question of changing dependency
> >> >> > version?
> >> >> > or
> >> >> > does it require code change?
> >> >> > and if it requires code change, can we do it with reasonable
> >> >> > reflection
> >> >> > or
> >> >> > is it really too much change?
> >> >> >
> >> >> > because if we can let the end user upgrade his config (and better
> >> >> > document), we would get the best of every choice
> >> >> >
> >> >> > Regards,
> >> >> >
> >> >> > Hervé
> >> >> >
> >> >> > Le mardi 13 janvier 2015 19:52:35 Henning Schmiedehausen a écrit :
> >> >> >> I would pretty much abandon anything pre-Java 6 at this point and
> >> >> >> start moving towards Java 7 soon. The checkstyle plugin right now
> >> >> >> has
> >> >> >> three open releases with only the third being really useful
> >> >> >> ("upgrade
> >> >> >> to latest checkstyle") and given the previous release cadence it
> >> >> >> makes
> >> >> >> me fear that this release will not show before Mid-2015.
> >> >> >>
> >> >> >> -h
> >> >> >>
> >> >> >> On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg
> >> >> >> <de...@apache.org>
> >> >
> >> > wrote:
> >> >> >> > I've started going through the open issues and have found a
> >> >> >> > problem
> >> >> >> > that I need som help with. It turns out that Checkstyle 5.9 uses
> >> >> >> > Java
> >> >> >> > 6 classes, even though it is not mentioned in the release notes.
> >> >> >> > How
> >> >> >> > do we want to handle this? I see two possible options:
> >> >> >> >
> >> >> >> > 1. Make version 2.14 of the plugin require Java 6, and update it
> >> >> >> > to
> >> >> >> > use the latest available version of Checkstyle that runs on Java
> >> >> >> > 6.
> >> >> >> >
> >> >> >> > 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of
> >> >> >> > the
> >> >> >> > plugin with a Java 5 requirement. After that release 2.15 of the
> >> >> >> > plugin fairly straight away with a Java 6 requirement, and using
> >> >> >> > the
> >> >> >> > latest available version of Checkstyle that runs on Java 6. It
> >> >> >> > should
> >> >> >> > be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
> >> >> >> >
> >> >> >> > Perhaps there are other alternatives? What do you think?
> >> >> >> >
> >> >> >> > On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg
> >> >> >> > <de...@apache.org>
> >> >> >
> >> >> > wrote:
> >> >> >> >> Hi,
> >> >> >> >>
> >> >> >> >> I'd like to release version 2.14 of Maven Checkstyle Plugin. The
> >> >> >> >> main
> >> >> >> >> motive for 2.14 is the ability to check Java 8 source code.
> >> >> >> >>
> >> >> >> >> According to the road map there are 5 unresolved issues
> >> >> >> >> scheduled
> >> >> >> >> for
> >> >> >> >> 2.14.
> >> >> >> >>
> >> >> >> >> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atl
> >> >> >> >> ass
> >> >> >> >> ian
> >> >> >> >> .ji
> >> >> >> >> ra.plugin.system.project%3Aroadmap-panel
> >> >> >> >>
> >> >> >> >> If anyone is interested in fixing one or more of these for 2.14
> >> >> >> >> now
> >> >> >> >> would be a good time to do it. Just reply here with an estimated
> >> >> >> >> time
> >> >> >> >> frame. If noone has the time for this now, I'll reschedule those
> >> >> >> >> issues for 2.15, which will require Java 6.
> >> >> >> >>
> >> >> >> >> --
> >> >> >> >> Dennis Lundberg
> >> >> >> >
> >> >> >> > --
> >> >> >> > Dennis Lundberg
> >> >> >> >
> >> >> >> > -----------------------------------------------------------------
> >> >> >> > ---
> >> >> >> > -
> >> >> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> >> >> > For additional commands, e-mail: dev-help@maven.apache.org
> >> >> >>
> >> >> >> -------------------------------------------------------------------
> >> >> >> --
> >> >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> >> >> For additional commands, e-mail: dev-help@maven.apache.org
> >> >> >
> >> >> > --------------------------------------------------------------------
> >> >> > -
> >> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> >> > For additional commands, e-mail: dev-help@maven.apache.org
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> >> For additional commands, e-mail: dev-help@maven.apache.org
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> > For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Henning Schmiedehausen <he...@schmiedehausen.org>.
Thanks, will do.
On Sun, Jan 18, 2015 at 8:12 AM, Dennis Lundberg <de...@apache.org> wrote:
> Henning,
>
> Please try the latest 2.14-SNAPSHOT version from the ASF repository.
> You should be able to just override the Checkstyle version by adding a
> dependency on Checkstyle 6.2 to the Maven Checkstyle Plugin in your
> project's POM.
>
> On Sat, Jan 17, 2015 at 6:39 PM, Henning Schmiedehausen
> <he...@schmiedehausen.org> wrote:
>> As long as I can just drop in 6.2 and the plugin does not break (as it
>> does today), I am fine.
>>
>> We are running our own checkstyle ruleset anyway, it is just the
>> default that does not work well.
>>
>> Where are your changes, I haven't seen them on the trunk @ github.
>>
>> -h
>>
>>
>> On Sat, Jan 17, 2015 at 9:30 AM, Hervé BOUTEMY <he...@free.fr> wrote:
>>> yes, i know you did that in the branch to test upgrade for a release with
>>> Checkstyle 6.2 as default version
>>>
>>> I did it in trunk, even without changing Checkstyle version: even if maven-
>>> checkstyle-plugin ships with an older Checkstyle version as default
>>> dependency, end-users can now upgrade the dependency when using the plugin
>>>
>>> Regards,
>>>
>>> Hervé
>>>
>>>
>>> Le samedi 17 janvier 2015 09:17:08 Henning Schmiedehausen a écrit :
>>>> I already did that. See https://github.com/apache/maven-plugins/pull/42
>>>>
>>>> -h
>>>>
>>>> On Sat, Jan 17, 2015 at 9:02 AM, Hervé BOUTEMY <he...@free.fr>
>>> wrote:
>>>> > Le mercredi 14 janvier 2015 11:08:40 Henning Schmiedehausen a écrit :
>>>> >> The 6.2 checkstyle requires java 7 and it also removes (!) at least
>>>> >> one of the checks (RedundantThrows) which is used in all shipped
>>>> >> checkstyle sets and one of the integration tests. So you can no longer
>>>> >> use any of the builtin styles but have to use a custom style which has
>>>> >> the RedundantThrows check removed.
>>>> >
>>>> > the RedundantThrows check causes a lot of false positives: it is maked as
>>>> > "ingore" in Maven parent pom
>>>> > I'll remove it from default configs for next release: see MCHECKSTYLE-276
>>>> >
>>>> >> Having code that can dynamically discover whether a given check exists
>>>> >> or not and change the configuration accordingly is something that
>>>> >> probably would need to be done inside checkstyle proper, not the
>>>> >> plugin driving it.
>>>> >>
>>>> >> I have a pull request prepared (not pushed yet) which would upgrade
>>>> >> checkstyle and the build to java 7 for a possible 2.16 release. One of
>>>> >> the problems here is that at least one integration test will not pass
>>>> >> until the patch was applied to trunk (because it remote-loads the rule
>>>> >> set from the svn repo which in turn currently still has the bad rule).
>>>> >>
>>>> >> It is all a mess and prolonging it to accomodate the one hold-out on
>>>> >> Java 5 (which is EOLed for > 5 years now) and the few that insist on
>>>> >> using Java 6 (which is EOLed for ~ 2 years) makes no sense to me. We
>>>> >> should lead, not lag behind.
>>>> >>
>>>> >> -h
>>>> >>
>>>> >> On Tue, Jan 13, 2015 at 11:09 PM, Hervé BOUTEMY <he...@free.fr>
>>>> >
>>>> > wrote:
>>>> >> > question: is upgrading only a question of changing dependency version?
>>>> >> > or
>>>> >> > does it require code change?
>>>> >> > and if it requires code change, can we do it with reasonable reflection
>>>> >> > or
>>>> >> > is it really too much change?
>>>> >> >
>>>> >> > because if we can let the end user upgrade his config (and better
>>>> >> > document), we would get the best of every choice
>>>> >> >
>>>> >> > Regards,
>>>> >> >
>>>> >> > Hervé
>>>> >> >
>>>> >> > Le mardi 13 janvier 2015 19:52:35 Henning Schmiedehausen a écrit :
>>>> >> >> I would pretty much abandon anything pre-Java 6 at this point and
>>>> >> >> start moving towards Java 7 soon. The checkstyle plugin right now has
>>>> >> >> three open releases with only the third being really useful ("upgrade
>>>> >> >> to latest checkstyle") and given the previous release cadence it makes
>>>> >> >> me fear that this release will not show before Mid-2015.
>>>> >> >>
>>>> >> >> -h
>>>> >> >>
>>>> >> >> On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg <de...@apache.org>
>>>> >
>>>> > wrote:
>>>> >> >> > I've started going through the open issues and have found a problem
>>>> >> >> > that I need som help with. It turns out that Checkstyle 5.9 uses
>>>> >> >> > Java
>>>> >> >> > 6 classes, even though it is not mentioned in the release notes. How
>>>> >> >> > do we want to handle this? I see two possible options:
>>>> >> >> >
>>>> >> >> > 1. Make version 2.14 of the plugin require Java 6, and update it to
>>>> >> >> > use the latest available version of Checkstyle that runs on Java 6.
>>>> >> >> >
>>>> >> >> > 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>>>> >> >> > plugin with a Java 5 requirement. After that release 2.15 of the
>>>> >> >> > plugin fairly straight away with a Java 6 requirement, and using the
>>>> >> >> > latest available version of Checkstyle that runs on Java 6. It
>>>> >> >> > should
>>>> >> >> > be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>>>> >> >> >
>>>> >> >> > Perhaps there are other alternatives? What do you think?
>>>> >> >> >
>>>> >> >> > On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
>>>> >> >
>>>> >> > wrote:
>>>> >> >> >> Hi,
>>>> >> >> >>
>>>> >> >> >> I'd like to release version 2.14 of Maven Checkstyle Plugin. The
>>>> >> >> >> main
>>>> >> >> >> motive for 2.14 is the ability to check Java 8 source code.
>>>> >> >> >>
>>>> >> >> >> According to the road map there are 5 unresolved issues scheduled
>>>> >> >> >> for
>>>> >> >> >> 2.14.
>>>> >> >> >>
>>>> >> >> >> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlass
>>>> >> >> >> ian
>>>> >> >> >> .ji
>>>> >> >> >> ra.plugin.system.project%3Aroadmap-panel
>>>> >> >> >>
>>>> >> >> >> If anyone is interested in fixing one or more of these for 2.14 now
>>>> >> >> >> would be a good time to do it. Just reply here with an estimated
>>>> >> >> >> time
>>>> >> >> >> frame. If noone has the time for this now, I'll reschedule those
>>>> >> >> >> issues for 2.15, which will require Java 6.
>>>> >> >> >>
>>>> >> >> >> --
>>>> >> >> >> Dennis Lundberg
>>>> >> >> >
>>>> >> >> > --
>>>> >> >> > Dennis Lundberg
>>>> >> >> >
>>>> >> >> > --------------------------------------------------------------------
>>>> >> >> > -
>>>> >> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> >> >> > For additional commands, e-mail: dev-help@maven.apache.org
>>>> >> >>
>>>> >> >> ---------------------------------------------------------------------
>>>> >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> >> >> For additional commands, e-mail: dev-help@maven.apache.org
>>>> >> >
>>>> >> > ---------------------------------------------------------------------
>>>> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> >> > For additional commands, e-mail: dev-help@maven.apache.org
>>>> >>
>>>> >> ---------------------------------------------------------------------
>>>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> >> For additional commands, e-mail: dev-help@maven.apache.org
>>>> >
>>>> > ---------------------------------------------------------------------
>>>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> > For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Dennis Lundberg <de...@apache.org>.
Henning,
Please try the latest 2.14-SNAPSHOT version from the ASF repository.
You should be able to just override the Checkstyle version by adding a
dependency on Checkstyle 6.2 to the Maven Checkstyle Plugin in your
project's POM.
On Sat, Jan 17, 2015 at 6:39 PM, Henning Schmiedehausen
<he...@schmiedehausen.org> wrote:
> As long as I can just drop in 6.2 and the plugin does not break (as it
> does today), I am fine.
>
> We are running our own checkstyle ruleset anyway, it is just the
> default that does not work well.
>
> Where are your changes, I haven't seen them on the trunk @ github.
>
> -h
>
>
> On Sat, Jan 17, 2015 at 9:30 AM, Hervé BOUTEMY <he...@free.fr> wrote:
>> yes, i know you did that in the branch to test upgrade for a release with
>> Checkstyle 6.2 as default version
>>
>> I did it in trunk, even without changing Checkstyle version: even if maven-
>> checkstyle-plugin ships with an older Checkstyle version as default
>> dependency, end-users can now upgrade the dependency when using the plugin
>>
>> Regards,
>>
>> Hervé
>>
>>
>> Le samedi 17 janvier 2015 09:17:08 Henning Schmiedehausen a écrit :
>>> I already did that. See https://github.com/apache/maven-plugins/pull/42
>>>
>>> -h
>>>
>>> On Sat, Jan 17, 2015 at 9:02 AM, Hervé BOUTEMY <he...@free.fr>
>> wrote:
>>> > Le mercredi 14 janvier 2015 11:08:40 Henning Schmiedehausen a écrit :
>>> >> The 6.2 checkstyle requires java 7 and it also removes (!) at least
>>> >> one of the checks (RedundantThrows) which is used in all shipped
>>> >> checkstyle sets and one of the integration tests. So you can no longer
>>> >> use any of the builtin styles but have to use a custom style which has
>>> >> the RedundantThrows check removed.
>>> >
>>> > the RedundantThrows check causes a lot of false positives: it is maked as
>>> > "ingore" in Maven parent pom
>>> > I'll remove it from default configs for next release: see MCHECKSTYLE-276
>>> >
>>> >> Having code that can dynamically discover whether a given check exists
>>> >> or not and change the configuration accordingly is something that
>>> >> probably would need to be done inside checkstyle proper, not the
>>> >> plugin driving it.
>>> >>
>>> >> I have a pull request prepared (not pushed yet) which would upgrade
>>> >> checkstyle and the build to java 7 for a possible 2.16 release. One of
>>> >> the problems here is that at least one integration test will not pass
>>> >> until the patch was applied to trunk (because it remote-loads the rule
>>> >> set from the svn repo which in turn currently still has the bad rule).
>>> >>
>>> >> It is all a mess and prolonging it to accomodate the one hold-out on
>>> >> Java 5 (which is EOLed for > 5 years now) and the few that insist on
>>> >> using Java 6 (which is EOLed for ~ 2 years) makes no sense to me. We
>>> >> should lead, not lag behind.
>>> >>
>>> >> -h
>>> >>
>>> >> On Tue, Jan 13, 2015 at 11:09 PM, Hervé BOUTEMY <he...@free.fr>
>>> >
>>> > wrote:
>>> >> > question: is upgrading only a question of changing dependency version?
>>> >> > or
>>> >> > does it require code change?
>>> >> > and if it requires code change, can we do it with reasonable reflection
>>> >> > or
>>> >> > is it really too much change?
>>> >> >
>>> >> > because if we can let the end user upgrade his config (and better
>>> >> > document), we would get the best of every choice
>>> >> >
>>> >> > Regards,
>>> >> >
>>> >> > Hervé
>>> >> >
>>> >> > Le mardi 13 janvier 2015 19:52:35 Henning Schmiedehausen a écrit :
>>> >> >> I would pretty much abandon anything pre-Java 6 at this point and
>>> >> >> start moving towards Java 7 soon. The checkstyle plugin right now has
>>> >> >> three open releases with only the third being really useful ("upgrade
>>> >> >> to latest checkstyle") and given the previous release cadence it makes
>>> >> >> me fear that this release will not show before Mid-2015.
>>> >> >>
>>> >> >> -h
>>> >> >>
>>> >> >> On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg <de...@apache.org>
>>> >
>>> > wrote:
>>> >> >> > I've started going through the open issues and have found a problem
>>> >> >> > that I need som help with. It turns out that Checkstyle 5.9 uses
>>> >> >> > Java
>>> >> >> > 6 classes, even though it is not mentioned in the release notes. How
>>> >> >> > do we want to handle this? I see two possible options:
>>> >> >> >
>>> >> >> > 1. Make version 2.14 of the plugin require Java 6, and update it to
>>> >> >> > use the latest available version of Checkstyle that runs on Java 6.
>>> >> >> >
>>> >> >> > 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>>> >> >> > plugin with a Java 5 requirement. After that release 2.15 of the
>>> >> >> > plugin fairly straight away with a Java 6 requirement, and using the
>>> >> >> > latest available version of Checkstyle that runs on Java 6. It
>>> >> >> > should
>>> >> >> > be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>>> >> >> >
>>> >> >> > Perhaps there are other alternatives? What do you think?
>>> >> >> >
>>> >> >> > On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
>>> >> >
>>> >> > wrote:
>>> >> >> >> Hi,
>>> >> >> >>
>>> >> >> >> I'd like to release version 2.14 of Maven Checkstyle Plugin. The
>>> >> >> >> main
>>> >> >> >> motive for 2.14 is the ability to check Java 8 source code.
>>> >> >> >>
>>> >> >> >> According to the road map there are 5 unresolved issues scheduled
>>> >> >> >> for
>>> >> >> >> 2.14.
>>> >> >> >>
>>> >> >> >> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlass
>>> >> >> >> ian
>>> >> >> >> .ji
>>> >> >> >> ra.plugin.system.project%3Aroadmap-panel
>>> >> >> >>
>>> >> >> >> If anyone is interested in fixing one or more of these for 2.14 now
>>> >> >> >> would be a good time to do it. Just reply here with an estimated
>>> >> >> >> time
>>> >> >> >> frame. If noone has the time for this now, I'll reschedule those
>>> >> >> >> issues for 2.15, which will require Java 6.
>>> >> >> >>
>>> >> >> >> --
>>> >> >> >> Dennis Lundberg
>>> >> >> >
>>> >> >> > --
>>> >> >> > Dennis Lundberg
>>> >> >> >
>>> >> >> > --------------------------------------------------------------------
>>> >> >> > -
>>> >> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> >> >> > For additional commands, e-mail: dev-help@maven.apache.org
>>> >> >>
>>> >> >> ---------------------------------------------------------------------
>>> >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> >> >> For additional commands, e-mail: dev-help@maven.apache.org
>>> >> >
>>> >> > ---------------------------------------------------------------------
>>> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> >> > For additional commands, e-mail: dev-help@maven.apache.org
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> >> For additional commands, e-mail: dev-help@maven.apache.org
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> > For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Henning Schmiedehausen <he...@schmiedehausen.org>.
As long as I can just drop in 6.2 and the plugin does not break (as it
does today), I am fine.
We are running our own checkstyle ruleset anyway, it is just the
default that does not work well.
Where are your changes, I haven't seen them on the trunk @ github.
-h
On Sat, Jan 17, 2015 at 9:30 AM, Hervé BOUTEMY <he...@free.fr> wrote:
> yes, i know you did that in the branch to test upgrade for a release with
> Checkstyle 6.2 as default version
>
> I did it in trunk, even without changing Checkstyle version: even if maven-
> checkstyle-plugin ships with an older Checkstyle version as default
> dependency, end-users can now upgrade the dependency when using the plugin
>
> Regards,
>
> Hervé
>
>
> Le samedi 17 janvier 2015 09:17:08 Henning Schmiedehausen a écrit :
>> I already did that. See https://github.com/apache/maven-plugins/pull/42
>>
>> -h
>>
>> On Sat, Jan 17, 2015 at 9:02 AM, Hervé BOUTEMY <he...@free.fr>
> wrote:
>> > Le mercredi 14 janvier 2015 11:08:40 Henning Schmiedehausen a écrit :
>> >> The 6.2 checkstyle requires java 7 and it also removes (!) at least
>> >> one of the checks (RedundantThrows) which is used in all shipped
>> >> checkstyle sets and one of the integration tests. So you can no longer
>> >> use any of the builtin styles but have to use a custom style which has
>> >> the RedundantThrows check removed.
>> >
>> > the RedundantThrows check causes a lot of false positives: it is maked as
>> > "ingore" in Maven parent pom
>> > I'll remove it from default configs for next release: see MCHECKSTYLE-276
>> >
>> >> Having code that can dynamically discover whether a given check exists
>> >> or not and change the configuration accordingly is something that
>> >> probably would need to be done inside checkstyle proper, not the
>> >> plugin driving it.
>> >>
>> >> I have a pull request prepared (not pushed yet) which would upgrade
>> >> checkstyle and the build to java 7 for a possible 2.16 release. One of
>> >> the problems here is that at least one integration test will not pass
>> >> until the patch was applied to trunk (because it remote-loads the rule
>> >> set from the svn repo which in turn currently still has the bad rule).
>> >>
>> >> It is all a mess and prolonging it to accomodate the one hold-out on
>> >> Java 5 (which is EOLed for > 5 years now) and the few that insist on
>> >> using Java 6 (which is EOLed for ~ 2 years) makes no sense to me. We
>> >> should lead, not lag behind.
>> >>
>> >> -h
>> >>
>> >> On Tue, Jan 13, 2015 at 11:09 PM, Hervé BOUTEMY <he...@free.fr>
>> >
>> > wrote:
>> >> > question: is upgrading only a question of changing dependency version?
>> >> > or
>> >> > does it require code change?
>> >> > and if it requires code change, can we do it with reasonable reflection
>> >> > or
>> >> > is it really too much change?
>> >> >
>> >> > because if we can let the end user upgrade his config (and better
>> >> > document), we would get the best of every choice
>> >> >
>> >> > Regards,
>> >> >
>> >> > Hervé
>> >> >
>> >> > Le mardi 13 janvier 2015 19:52:35 Henning Schmiedehausen a écrit :
>> >> >> I would pretty much abandon anything pre-Java 6 at this point and
>> >> >> start moving towards Java 7 soon. The checkstyle plugin right now has
>> >> >> three open releases with only the third being really useful ("upgrade
>> >> >> to latest checkstyle") and given the previous release cadence it makes
>> >> >> me fear that this release will not show before Mid-2015.
>> >> >>
>> >> >> -h
>> >> >>
>> >> >> On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg <de...@apache.org>
>> >
>> > wrote:
>> >> >> > I've started going through the open issues and have found a problem
>> >> >> > that I need som help with. It turns out that Checkstyle 5.9 uses
>> >> >> > Java
>> >> >> > 6 classes, even though it is not mentioned in the release notes. How
>> >> >> > do we want to handle this? I see two possible options:
>> >> >> >
>> >> >> > 1. Make version 2.14 of the plugin require Java 6, and update it to
>> >> >> > use the latest available version of Checkstyle that runs on Java 6.
>> >> >> >
>> >> >> > 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>> >> >> > plugin with a Java 5 requirement. After that release 2.15 of the
>> >> >> > plugin fairly straight away with a Java 6 requirement, and using the
>> >> >> > latest available version of Checkstyle that runs on Java 6. It
>> >> >> > should
>> >> >> > be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>> >> >> >
>> >> >> > Perhaps there are other alternatives? What do you think?
>> >> >> >
>> >> >> > On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
>> >> >
>> >> > wrote:
>> >> >> >> Hi,
>> >> >> >>
>> >> >> >> I'd like to release version 2.14 of Maven Checkstyle Plugin. The
>> >> >> >> main
>> >> >> >> motive for 2.14 is the ability to check Java 8 source code.
>> >> >> >>
>> >> >> >> According to the road map there are 5 unresolved issues scheduled
>> >> >> >> for
>> >> >> >> 2.14.
>> >> >> >>
>> >> >> >> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlass
>> >> >> >> ian
>> >> >> >> .ji
>> >> >> >> ra.plugin.system.project%3Aroadmap-panel
>> >> >> >>
>> >> >> >> If anyone is interested in fixing one or more of these for 2.14 now
>> >> >> >> would be a good time to do it. Just reply here with an estimated
>> >> >> >> time
>> >> >> >> frame. If noone has the time for this now, I'll reschedule those
>> >> >> >> issues for 2.15, which will require Java 6.
>> >> >> >>
>> >> >> >> --
>> >> >> >> Dennis Lundberg
>> >> >> >
>> >> >> > --
>> >> >> > Dennis Lundberg
>> >> >> >
>> >> >> > --------------------------------------------------------------------
>> >> >> > -
>> >> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> >> > For additional commands, e-mail: dev-help@maven.apache.org
>> >> >>
>> >> >> ---------------------------------------------------------------------
>> >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> >> For additional commands, e-mail: dev-help@maven.apache.org
>> >> >
>> >> > ---------------------------------------------------------------------
>> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> > For additional commands, e-mail: dev-help@maven.apache.org
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Hervé BOUTEMY <he...@free.fr>.
yes, i know you did that in the branch to test upgrade for a release with
Checkstyle 6.2 as default version
I did it in trunk, even without changing Checkstyle version: even if maven-
checkstyle-plugin ships with an older Checkstyle version as default
dependency, end-users can now upgrade the dependency when using the plugin
Regards,
Hervé
Le samedi 17 janvier 2015 09:17:08 Henning Schmiedehausen a écrit :
> I already did that. See https://github.com/apache/maven-plugins/pull/42
>
> -h
>
> On Sat, Jan 17, 2015 at 9:02 AM, Hervé BOUTEMY <he...@free.fr>
wrote:
> > Le mercredi 14 janvier 2015 11:08:40 Henning Schmiedehausen a écrit :
> >> The 6.2 checkstyle requires java 7 and it also removes (!) at least
> >> one of the checks (RedundantThrows) which is used in all shipped
> >> checkstyle sets and one of the integration tests. So you can no longer
> >> use any of the builtin styles but have to use a custom style which has
> >> the RedundantThrows check removed.
> >
> > the RedundantThrows check causes a lot of false positives: it is maked as
> > "ingore" in Maven parent pom
> > I'll remove it from default configs for next release: see MCHECKSTYLE-276
> >
> >> Having code that can dynamically discover whether a given check exists
> >> or not and change the configuration accordingly is something that
> >> probably would need to be done inside checkstyle proper, not the
> >> plugin driving it.
> >>
> >> I have a pull request prepared (not pushed yet) which would upgrade
> >> checkstyle and the build to java 7 for a possible 2.16 release. One of
> >> the problems here is that at least one integration test will not pass
> >> until the patch was applied to trunk (because it remote-loads the rule
> >> set from the svn repo which in turn currently still has the bad rule).
> >>
> >> It is all a mess and prolonging it to accomodate the one hold-out on
> >> Java 5 (which is EOLed for > 5 years now) and the few that insist on
> >> using Java 6 (which is EOLed for ~ 2 years) makes no sense to me. We
> >> should lead, not lag behind.
> >>
> >> -h
> >>
> >> On Tue, Jan 13, 2015 at 11:09 PM, Hervé BOUTEMY <he...@free.fr>
> >
> > wrote:
> >> > question: is upgrading only a question of changing dependency version?
> >> > or
> >> > does it require code change?
> >> > and if it requires code change, can we do it with reasonable reflection
> >> > or
> >> > is it really too much change?
> >> >
> >> > because if we can let the end user upgrade his config (and better
> >> > document), we would get the best of every choice
> >> >
> >> > Regards,
> >> >
> >> > Hervé
> >> >
> >> > Le mardi 13 janvier 2015 19:52:35 Henning Schmiedehausen a écrit :
> >> >> I would pretty much abandon anything pre-Java 6 at this point and
> >> >> start moving towards Java 7 soon. The checkstyle plugin right now has
> >> >> three open releases with only the third being really useful ("upgrade
> >> >> to latest checkstyle") and given the previous release cadence it makes
> >> >> me fear that this release will not show before Mid-2015.
> >> >>
> >> >> -h
> >> >>
> >> >> On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg <de...@apache.org>
> >
> > wrote:
> >> >> > I've started going through the open issues and have found a problem
> >> >> > that I need som help with. It turns out that Checkstyle 5.9 uses
> >> >> > Java
> >> >> > 6 classes, even though it is not mentioned in the release notes. How
> >> >> > do we want to handle this? I see two possible options:
> >> >> >
> >> >> > 1. Make version 2.14 of the plugin require Java 6, and update it to
> >> >> > use the latest available version of Checkstyle that runs on Java 6.
> >> >> >
> >> >> > 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
> >> >> > plugin with a Java 5 requirement. After that release 2.15 of the
> >> >> > plugin fairly straight away with a Java 6 requirement, and using the
> >> >> > latest available version of Checkstyle that runs on Java 6. It
> >> >> > should
> >> >> > be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
> >> >> >
> >> >> > Perhaps there are other alternatives? What do you think?
> >> >> >
> >> >> > On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
> >> >
> >> > wrote:
> >> >> >> Hi,
> >> >> >>
> >> >> >> I'd like to release version 2.14 of Maven Checkstyle Plugin. The
> >> >> >> main
> >> >> >> motive for 2.14 is the ability to check Java 8 source code.
> >> >> >>
> >> >> >> According to the road map there are 5 unresolved issues scheduled
> >> >> >> for
> >> >> >> 2.14.
> >> >> >>
> >> >> >> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlass
> >> >> >> ian
> >> >> >> .ji
> >> >> >> ra.plugin.system.project%3Aroadmap-panel
> >> >> >>
> >> >> >> If anyone is interested in fixing one or more of these for 2.14 now
> >> >> >> would be a good time to do it. Just reply here with an estimated
> >> >> >> time
> >> >> >> frame. If noone has the time for this now, I'll reschedule those
> >> >> >> issues for 2.15, which will require Java 6.
> >> >> >>
> >> >> >> --
> >> >> >> Dennis Lundberg
> >> >> >
> >> >> > --
> >> >> > Dennis Lundberg
> >> >> >
> >> >> > --------------------------------------------------------------------
> >> >> > -
> >> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> >> > For additional commands, e-mail: dev-help@maven.apache.org
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> >> For additional commands, e-mail: dev-help@maven.apache.org
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> > For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Henning Schmiedehausen <he...@schmiedehausen.org>.
I already did that. See https://github.com/apache/maven-plugins/pull/42
-h
On Sat, Jan 17, 2015 at 9:02 AM, Hervé BOUTEMY <he...@free.fr> wrote:
> Le mercredi 14 janvier 2015 11:08:40 Henning Schmiedehausen a écrit :
>> The 6.2 checkstyle requires java 7 and it also removes (!) at least
>> one of the checks (RedundantThrows) which is used in all shipped
>> checkstyle sets and one of the integration tests. So you can no longer
>> use any of the builtin styles but have to use a custom style which has
>> the RedundantThrows check removed.
> the RedundantThrows check causes a lot of false positives: it is maked as
> "ingore" in Maven parent pom
> I'll remove it from default configs for next release: see MCHECKSTYLE-276
>
>>
>> Having code that can dynamically discover whether a given check exists
>> or not and change the configuration accordingly is something that
>> probably would need to be done inside checkstyle proper, not the
>> plugin driving it.
>>
>> I have a pull request prepared (not pushed yet) which would upgrade
>> checkstyle and the build to java 7 for a possible 2.16 release. One of
>> the problems here is that at least one integration test will not pass
>> until the patch was applied to trunk (because it remote-loads the rule
>> set from the svn repo which in turn currently still has the bad rule).
>>
>> It is all a mess and prolonging it to accomodate the one hold-out on
>> Java 5 (which is EOLed for > 5 years now) and the few that insist on
>> using Java 6 (which is EOLed for ~ 2 years) makes no sense to me. We
>> should lead, not lag behind.
>>
>> -h
>>
>> On Tue, Jan 13, 2015 at 11:09 PM, Hervé BOUTEMY <he...@free.fr>
> wrote:
>> > question: is upgrading only a question of changing dependency version? or
>> > does it require code change?
>> > and if it requires code change, can we do it with reasonable reflection or
>> > is it really too much change?
>> >
>> > because if we can let the end user upgrade his config (and better
>> > document), we would get the best of every choice
>> >
>> > Regards,
>> >
>> > Hervé
>> >
>> > Le mardi 13 janvier 2015 19:52:35 Henning Schmiedehausen a écrit :
>> >> I would pretty much abandon anything pre-Java 6 at this point and
>> >> start moving towards Java 7 soon. The checkstyle plugin right now has
>> >> three open releases with only the third being really useful ("upgrade
>> >> to latest checkstyle") and given the previous release cadence it makes
>> >> me fear that this release will not show before Mid-2015.
>> >>
>> >> -h
>> >>
>> >> On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg <de...@apache.org>
> wrote:
>> >> > I've started going through the open issues and have found a problem
>> >> > that I need som help with. It turns out that Checkstyle 5.9 uses Java
>> >> > 6 classes, even though it is not mentioned in the release notes. How
>> >> > do we want to handle this? I see two possible options:
>> >> >
>> >> > 1. Make version 2.14 of the plugin require Java 6, and update it to
>> >> > use the latest available version of Checkstyle that runs on Java 6.
>> >> >
>> >> > 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>> >> > plugin with a Java 5 requirement. After that release 2.15 of the
>> >> > plugin fairly straight away with a Java 6 requirement, and using the
>> >> > latest available version of Checkstyle that runs on Java 6. It should
>> >> > be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>> >> >
>> >> > Perhaps there are other alternatives? What do you think?
>> >> >
>> >> > On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
>> >
>> > wrote:
>> >> >> Hi,
>> >> >>
>> >> >> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>> >> >> motive for 2.14 is the ability to check Java 8 source code.
>> >> >>
>> >> >> According to the road map there are 5 unresolved issues scheduled for
>> >> >> 2.14.
>> >> >>
>> >> >> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian
>> >> >> .ji
>> >> >> ra.plugin.system.project%3Aroadmap-panel
>> >> >>
>> >> >> If anyone is interested in fixing one or more of these for 2.14 now
>> >> >> would be a good time to do it. Just reply here with an estimated time
>> >> >> frame. If noone has the time for this now, I'll reschedule those
>> >> >> issues for 2.15, which will require Java 6.
>> >> >>
>> >> >> --
>> >> >> Dennis Lundberg
>> >> >
>> >> > --
>> >> > Dennis Lundberg
>> >> >
>> >> > ---------------------------------------------------------------------
>> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> > For additional commands, e-mail: dev-help@maven.apache.org
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Hervé BOUTEMY <he...@free.fr>.
Le mercredi 14 janvier 2015 11:08:40 Henning Schmiedehausen a écrit :
> The 6.2 checkstyle requires java 7 and it also removes (!) at least
> one of the checks (RedundantThrows) which is used in all shipped
> checkstyle sets and one of the integration tests. So you can no longer
> use any of the builtin styles but have to use a custom style which has
> the RedundantThrows check removed.
the RedundantThrows check causes a lot of false positives: it is maked as
"ingore" in Maven parent pom
I'll remove it from default configs for next release: see MCHECKSTYLE-276
>
> Having code that can dynamically discover whether a given check exists
> or not and change the configuration accordingly is something that
> probably would need to be done inside checkstyle proper, not the
> plugin driving it.
>
> I have a pull request prepared (not pushed yet) which would upgrade
> checkstyle and the build to java 7 for a possible 2.16 release. One of
> the problems here is that at least one integration test will not pass
> until the patch was applied to trunk (because it remote-loads the rule
> set from the svn repo which in turn currently still has the bad rule).
>
> It is all a mess and prolonging it to accomodate the one hold-out on
> Java 5 (which is EOLed for > 5 years now) and the few that insist on
> using Java 6 (which is EOLed for ~ 2 years) makes no sense to me. We
> should lead, not lag behind.
>
> -h
>
> On Tue, Jan 13, 2015 at 11:09 PM, Hervé BOUTEMY <he...@free.fr>
wrote:
> > question: is upgrading only a question of changing dependency version? or
> > does it require code change?
> > and if it requires code change, can we do it with reasonable reflection or
> > is it really too much change?
> >
> > because if we can let the end user upgrade his config (and better
> > document), we would get the best of every choice
> >
> > Regards,
> >
> > Hervé
> >
> > Le mardi 13 janvier 2015 19:52:35 Henning Schmiedehausen a écrit :
> >> I would pretty much abandon anything pre-Java 6 at this point and
> >> start moving towards Java 7 soon. The checkstyle plugin right now has
> >> three open releases with only the third being really useful ("upgrade
> >> to latest checkstyle") and given the previous release cadence it makes
> >> me fear that this release will not show before Mid-2015.
> >>
> >> -h
> >>
> >> On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg <de...@apache.org>
wrote:
> >> > I've started going through the open issues and have found a problem
> >> > that I need som help with. It turns out that Checkstyle 5.9 uses Java
> >> > 6 classes, even though it is not mentioned in the release notes. How
> >> > do we want to handle this? I see two possible options:
> >> >
> >> > 1. Make version 2.14 of the plugin require Java 6, and update it to
> >> > use the latest available version of Checkstyle that runs on Java 6.
> >> >
> >> > 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
> >> > plugin with a Java 5 requirement. After that release 2.15 of the
> >> > plugin fairly straight away with a Java 6 requirement, and using the
> >> > latest available version of Checkstyle that runs on Java 6. It should
> >> > be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
> >> >
> >> > Perhaps there are other alternatives? What do you think?
> >> >
> >> > On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
> >
> > wrote:
> >> >> Hi,
> >> >>
> >> >> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
> >> >> motive for 2.14 is the ability to check Java 8 source code.
> >> >>
> >> >> According to the road map there are 5 unresolved issues scheduled for
> >> >> 2.14.
> >> >>
> >> >> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian
> >> >> .ji
> >> >> ra.plugin.system.project%3Aroadmap-panel
> >> >>
> >> >> If anyone is interested in fixing one or more of these for 2.14 now
> >> >> would be a good time to do it. Just reply here with an estimated time
> >> >> frame. If noone has the time for this now, I'll reschedule those
> >> >> issues for 2.15, which will require Java 6.
> >> >>
> >> >> --
> >> >> Dennis Lundberg
> >> >
> >> > --
> >> > Dennis Lundberg
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> > For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Henning Schmiedehausen <he...@schmiedehausen.org>.
I made all the necessary changes to run out-of-the-box with 6.2 (and
have all the integration tests etc. pass) at
https://github.com/apache/maven-plugins/pull/42
Getting this out quickly would IMHO be a benefit to the whole apache
community (compared to, say lovingly maintain backwards compat to 5+
years EOLed versions of Java).
-h
On Wed, Jan 14, 2015 at 11:08 AM, Henning Schmiedehausen
<he...@schmiedehausen.org> wrote:
> The 6.2 checkstyle requires java 7 and it also removes (!) at least
> one of the checks (RedundantThrows) which is used in all shipped
> checkstyle sets and one of the integration tests. So you can no longer
> use any of the builtin styles but have to use a custom style which has
> the RedundantThrows check removed.
>
> Having code that can dynamically discover whether a given check exists
> or not and change the configuration accordingly is something that
> probably would need to be done inside checkstyle proper, not the
> plugin driving it.
>
> I have a pull request prepared (not pushed yet) which would upgrade
> checkstyle and the build to java 7 for a possible 2.16 release. One of
> the problems here is that at least one integration test will not pass
> until the patch was applied to trunk (because it remote-loads the rule
> set from the svn repo which in turn currently still has the bad rule).
>
> It is all a mess and prolonging it to accomodate the one hold-out on
> Java 5 (which is EOLed for > 5 years now) and the few that insist on
> using Java 6 (which is EOLed for ~ 2 years) makes no sense to me. We
> should lead, not lag behind.
>
> -h
>
> On Tue, Jan 13, 2015 at 11:09 PM, Hervé BOUTEMY <he...@free.fr> wrote:
>> question: is upgrading only a question of changing dependency version? or does
>> it require code change?
>> and if it requires code change, can we do it with reasonable reflection or is
>> it really too much change?
>>
>> because if we can let the end user upgrade his config (and better document), we
>> would get the best of every choice
>>
>> Regards,
>>
>> Hervé
>>
>> Le mardi 13 janvier 2015 19:52:35 Henning Schmiedehausen a écrit :
>>> I would pretty much abandon anything pre-Java 6 at this point and
>>> start moving towards Java 7 soon. The checkstyle plugin right now has
>>> three open releases with only the third being really useful ("upgrade
>>> to latest checkstyle") and given the previous release cadence it makes
>>> me fear that this release will not show before Mid-2015.
>>>
>>> -h
>>>
>>> On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg <de...@apache.org> wrote:
>>> > I've started going through the open issues and have found a problem
>>> > that I need som help with. It turns out that Checkstyle 5.9 uses Java
>>> > 6 classes, even though it is not mentioned in the release notes. How
>>> > do we want to handle this? I see two possible options:
>>> >
>>> > 1. Make version 2.14 of the plugin require Java 6, and update it to
>>> > use the latest available version of Checkstyle that runs on Java 6.
>>> >
>>> > 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>>> > plugin with a Java 5 requirement. After that release 2.15 of the
>>> > plugin fairly straight away with a Java 6 requirement, and using the
>>> > latest available version of Checkstyle that runs on Java 6. It should
>>> > be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>>> >
>>> > Perhaps there are other alternatives? What do you think?
>>> >
>>> > On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
>> wrote:
>>> >> Hi,
>>> >>
>>> >> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>>> >> motive for 2.14 is the ability to check Java 8 source code.
>>> >>
>>> >> According to the road map there are 5 unresolved issues scheduled for
>>> >> 2.14.
>>> >>
>>> >> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.ji
>>> >> ra.plugin.system.project%3Aroadmap-panel
>>> >>
>>> >> If anyone is interested in fixing one or more of these for 2.14 now
>>> >> would be a good time to do it. Just reply here with an estimated time
>>> >> frame. If noone has the time for this now, I'll reschedule those
>>> >> issues for 2.15, which will require Java 6.
>>> >>
>>> >> --
>>> >> Dennis Lundberg
>>> >
>>> > --
>>> > Dennis Lundberg
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> > For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Henning Schmiedehausen <he...@schmiedehausen.org>.
The 6.2 checkstyle requires java 7 and it also removes (!) at least
one of the checks (RedundantThrows) which is used in all shipped
checkstyle sets and one of the integration tests. So you can no longer
use any of the builtin styles but have to use a custom style which has
the RedundantThrows check removed.
Having code that can dynamically discover whether a given check exists
or not and change the configuration accordingly is something that
probably would need to be done inside checkstyle proper, not the
plugin driving it.
I have a pull request prepared (not pushed yet) which would upgrade
checkstyle and the build to java 7 for a possible 2.16 release. One of
the problems here is that at least one integration test will not pass
until the patch was applied to trunk (because it remote-loads the rule
set from the svn repo which in turn currently still has the bad rule).
It is all a mess and prolonging it to accomodate the one hold-out on
Java 5 (which is EOLed for > 5 years now) and the few that insist on
using Java 6 (which is EOLed for ~ 2 years) makes no sense to me. We
should lead, not lag behind.
-h
On Tue, Jan 13, 2015 at 11:09 PM, Hervé BOUTEMY <he...@free.fr> wrote:
> question: is upgrading only a question of changing dependency version? or does
> it require code change?
> and if it requires code change, can we do it with reasonable reflection or is
> it really too much change?
>
> because if we can let the end user upgrade his config (and better document), we
> would get the best of every choice
>
> Regards,
>
> Hervé
>
> Le mardi 13 janvier 2015 19:52:35 Henning Schmiedehausen a écrit :
>> I would pretty much abandon anything pre-Java 6 at this point and
>> start moving towards Java 7 soon. The checkstyle plugin right now has
>> three open releases with only the third being really useful ("upgrade
>> to latest checkstyle") and given the previous release cadence it makes
>> me fear that this release will not show before Mid-2015.
>>
>> -h
>>
>> On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg <de...@apache.org> wrote:
>> > I've started going through the open issues and have found a problem
>> > that I need som help with. It turns out that Checkstyle 5.9 uses Java
>> > 6 classes, even though it is not mentioned in the release notes. How
>> > do we want to handle this? I see two possible options:
>> >
>> > 1. Make version 2.14 of the plugin require Java 6, and update it to
>> > use the latest available version of Checkstyle that runs on Java 6.
>> >
>> > 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>> > plugin with a Java 5 requirement. After that release 2.15 of the
>> > plugin fairly straight away with a Java 6 requirement, and using the
>> > latest available version of Checkstyle that runs on Java 6. It should
>> > be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>> >
>> > Perhaps there are other alternatives? What do you think?
>> >
>> > On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
> wrote:
>> >> Hi,
>> >>
>> >> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>> >> motive for 2.14 is the ability to check Java 8 source code.
>> >>
>> >> According to the road map there are 5 unresolved issues scheduled for
>> >> 2.14.
>> >>
>> >> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.ji
>> >> ra.plugin.system.project%3Aroadmap-panel
>> >>
>> >> If anyone is interested in fixing one or more of these for 2.14 now
>> >> would be a good time to do it. Just reply here with an estimated time
>> >> frame. If noone has the time for this now, I'll reschedule those
>> >> issues for 2.15, which will require Java 6.
>> >>
>> >> --
>> >> Dennis Lundberg
>> >
>> > --
>> > Dennis Lundberg
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Hervé BOUTEMY <he...@free.fr>.
question: is upgrading only a question of changing dependency version? or does
it require code change?
and if it requires code change, can we do it with reasonable reflection or is
it really too much change?
because if we can let the end user upgrade his config (and better document), we
would get the best of every choice
Regards,
Hervé
Le mardi 13 janvier 2015 19:52:35 Henning Schmiedehausen a écrit :
> I would pretty much abandon anything pre-Java 6 at this point and
> start moving towards Java 7 soon. The checkstyle plugin right now has
> three open releases with only the third being really useful ("upgrade
> to latest checkstyle") and given the previous release cadence it makes
> me fear that this release will not show before Mid-2015.
>
> -h
>
> On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg <de...@apache.org> wrote:
> > I've started going through the open issues and have found a problem
> > that I need som help with. It turns out that Checkstyle 5.9 uses Java
> > 6 classes, even though it is not mentioned in the release notes. How
> > do we want to handle this? I see two possible options:
> >
> > 1. Make version 2.14 of the plugin require Java 6, and update it to
> > use the latest available version of Checkstyle that runs on Java 6.
> >
> > 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
> > plugin with a Java 5 requirement. After that release 2.15 of the
> > plugin fairly straight away with a Java 6 requirement, and using the
> > latest available version of Checkstyle that runs on Java 6. It should
> > be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
> >
> > Perhaps there are other alternatives? What do you think?
> >
> > On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
wrote:
> >> Hi,
> >>
> >> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
> >> motive for 2.14 is the ability to check Java 8 source code.
> >>
> >> According to the road map there are 5 unresolved issues scheduled for
> >> 2.14.
> >>
> >> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.ji
> >> ra.plugin.system.project%3Aroadmap-panel
> >>
> >> If anyone is interested in fixing one or more of these for 2.14 now
> >> would be a good time to do it. Just reply here with an estimated time
> >> frame. If noone has the time for this now, I'll reschedule those
> >> issues for 2.15, which will require Java 6.
> >>
> >> --
> >> Dennis Lundberg
> >
> > --
> > Dennis Lundberg
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Henning Schmiedehausen <he...@schmiedehausen.org>.
I would pretty much abandon anything pre-Java 6 at this point and
start moving towards Java 7 soon. The checkstyle plugin right now has
three open releases with only the third being really useful ("upgrade
to latest checkstyle") and given the previous release cadence it makes
me fear that this release will not show before Mid-2015.
-h
On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg <de...@apache.org> wrote:
> I've started going through the open issues and have found a problem
> that I need som help with. It turns out that Checkstyle 5.9 uses Java
> 6 classes, even though it is not mentioned in the release notes. How
> do we want to handle this? I see two possible options:
>
> 1. Make version 2.14 of the plugin require Java 6, and update it to
> use the latest available version of Checkstyle that runs on Java 6.
>
> 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
> plugin with a Java 5 requirement. After that release 2.15 of the
> plugin fairly straight away with a Java 6 requirement, and using the
> latest available version of Checkstyle that runs on Java 6. It should
> be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>
> Perhaps there are other alternatives? What do you think?
>
> On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org> wrote:
>> Hi,
>>
>> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>> motive for 2.14 is the ability to check Java 8 source code.
>>
>> According to the road map there are 5 unresolved issues scheduled for 2.14.
>>
>> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jira.plugin.system.project%3Aroadmap-panel
>>
>> If anyone is interested in fixing one or more of these for 2.14 now
>> would be a good time to do it. Just reply here with an estimated time
>> frame. If noone has the time for this now, I'll reschedule those
>> issues for 2.15, which will require Java 6.
>>
>> --
>> Dennis Lundberg
>
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Jason van Zyl <ja...@takari.io>.
+1
On Jan 9, 2015, at 8:13 AM, Kristian Rosenvold <kr...@gmail.com> wrote:
> As long as we're not regressed on the latest version I'd say that's
> your call right now.
>
> Kristian
>
>
> 2015-01-09 13:29 GMT+01:00 Dennis Lundberg <de...@apache.org>:
>> I've started going through the open issues and have found a problem
>> that I need som help with. It turns out that Checkstyle 5.9 uses Java
>> 6 classes, even though it is not mentioned in the release notes. How
>> do we want to handle this? I see two possible options:
>>
>> 1. Make version 2.14 of the plugin require Java 6, and update it to
>> use the latest available version of Checkstyle that runs on Java 6.
>>
>> 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>> plugin with a Java 5 requirement. After that release 2.15 of the
>> plugin fairly straight away with a Java 6 requirement, and using the
>> latest available version of Checkstyle that runs on Java 6. It should
>> be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>>
>> Perhaps there are other alternatives? What do you think?
>>
>> On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org> wrote:
>>> Hi,
>>>
>>> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>>> motive for 2.14 is the ability to check Java 8 source code.
>>>
>>> According to the road map there are 5 unresolved issues scheduled for 2.14.
>>>
>>> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jira.plugin.system.project%3Aroadmap-panel
>>>
>>> If anyone is interested in fixing one or more of these for 2.14 now
>>> would be a good time to do it. Just reply here with an estimated time
>>> frame. If noone has the time for this now, I'll reschedule those
>>> issues for 2.15, which will require Java 6.
>>>
>>> --
>>> Dennis Lundberg
>>
>>
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
We all have problems. How we deal with them is a measure of our worth.
-- Unknown
Re: Releasing the Checkstyle Plugin
Posted by Kristian Rosenvold <kr...@zenior.no>.
Definitely does not count as a regression, although like all fixed bugs it
has end user value.
You call, I say go for 1.6 and use the extra time & energy elsewhere :)
K
The only fixed issue that could I see that could have a direct benefit
to end users is:
http://jira.codehaus.org/browse/MCHECKSTYLE-254
Update plexus-interpolation to avoid thread safety issues
But I don't know if anyone has had any problems with this specifically
regarding the Checkstyle Plugin, or if it is just a part of the
regular "use the latest version to be on the safe side" maintenance.
On Fri, Jan 9, 2015 at 2:13 PM, Kristian Rosenvold
<kr...@gmail.com> wrote:
> As long as we're not regressed on the latest version I'd say that's
> your call right now.
>
> Kristian
>
>
> 2015-01-09 13:29 GMT+01:00 Dennis Lundberg <de...@apache.org>:
>> I've started going through the open issues and have found a problem
>> that I need som help with. It turns out that Checkstyle 5.9 uses Java
>> 6 classes, even though it is not mentioned in the release notes. How
>> do we want to handle this? I see two possible options:
>>
>> 1. Make version 2.14 of the plugin require Java 6, and update it to
>> use the latest available version of Checkstyle that runs on Java 6.
>>
>> 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>> plugin with a Java 5 requirement. After that release 2.15 of the
>> plugin fairly straight away with a Java 6 requirement, and using the
>> latest available version of Checkstyle that runs on Java 6. It should
>> be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>>
>> Perhaps there are other alternatives? What do you think?
>>
>> On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org>
wrote:
>>> Hi,
>>>
>>> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>>> motive for 2.14 is the ability to check Java 8 source code.
>>>
>>> According to the road map there are 5 unresolved issues scheduled for
2.14.
>>>
>>>
https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jira.plugin.system.project%3Aroadmap-panel
>>>
>>> If anyone is interested in fixing one or more of these for 2.14 now
>>> would be a good time to do it. Just reply here with an estimated time
>>> frame. If noone has the time for this now, I'll reschedule those
>>> issues for 2.15, which will require Java 6.
>>>
>>> --
>>> Dennis Lundberg
>>
>>
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Dennis Lundberg <de...@apache.org>.
The only fixed issue that could I see that could have a direct benefit
to end users is:
http://jira.codehaus.org/browse/MCHECKSTYLE-254
Update plexus-interpolation to avoid thread safety issues
But I don't know if anyone has had any problems with this specifically
regarding the Checkstyle Plugin, or if it is just a part of the
regular "use the latest version to be on the safe side" maintenance.
On Fri, Jan 9, 2015 at 2:13 PM, Kristian Rosenvold
<kr...@gmail.com> wrote:
> As long as we're not regressed on the latest version I'd say that's
> your call right now.
>
> Kristian
>
>
> 2015-01-09 13:29 GMT+01:00 Dennis Lundberg <de...@apache.org>:
>> I've started going through the open issues and have found a problem
>> that I need som help with. It turns out that Checkstyle 5.9 uses Java
>> 6 classes, even though it is not mentioned in the release notes. How
>> do we want to handle this? I see two possible options:
>>
>> 1. Make version 2.14 of the plugin require Java 6, and update it to
>> use the latest available version of Checkstyle that runs on Java 6.
>>
>> 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
>> plugin with a Java 5 requirement. After that release 2.15 of the
>> plugin fairly straight away with a Java 6 requirement, and using the
>> latest available version of Checkstyle that runs on Java 6. It should
>> be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>>
>> Perhaps there are other alternatives? What do you think?
>>
>> On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org> wrote:
>>> Hi,
>>>
>>> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>>> motive for 2.14 is the ability to check Java 8 source code.
>>>
>>> According to the road map there are 5 unresolved issues scheduled for 2.14.
>>>
>>> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jira.plugin.system.project%3Aroadmap-panel
>>>
>>> If anyone is interested in fixing one or more of these for 2.14 now
>>> would be a good time to do it. Just reply here with an estimated time
>>> frame. If noone has the time for this now, I'll reschedule those
>>> issues for 2.15, which will require Java 6.
>>>
>>> --
>>> Dennis Lundberg
>>
>>
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Kristian Rosenvold <kr...@gmail.com>.
As long as we're not regressed on the latest version I'd say that's
your call right now.
Kristian
2015-01-09 13:29 GMT+01:00 Dennis Lundberg <de...@apache.org>:
> I've started going through the open issues and have found a problem
> that I need som help with. It turns out that Checkstyle 5.9 uses Java
> 6 classes, even though it is not mentioned in the release notes. How
> do we want to handle this? I see two possible options:
>
> 1. Make version 2.14 of the plugin require Java 6, and update it to
> use the latest available version of Checkstyle that runs on Java 6.
>
> 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
> plugin with a Java 5 requirement. After that release 2.15 of the
> plugin fairly straight away with a Java 6 requirement, and using the
> latest available version of Checkstyle that runs on Java 6. It should
> be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
>
> Perhaps there are other alternatives? What do you think?
>
> On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org> wrote:
>> Hi,
>>
>> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>> motive for 2.14 is the ability to check Java 8 source code.
>>
>> According to the road map there are 5 unresolved issues scheduled for 2.14.
>>
>> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jira.plugin.system.project%3Aroadmap-panel
>>
>> If anyone is interested in fixing one or more of these for 2.14 now
>> would be a good time to do it. Just reply here with an estimated time
>> frame. If noone has the time for this now, I'll reschedule those
>> issues for 2.15, which will require Java 6.
>>
>> --
>> Dennis Lundberg
>
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Dennis Lundberg <de...@apache.org>.
I've started going through the open issues and have found a problem
that I need som help with. It turns out that Checkstyle 5.9 uses Java
6 classes, even though it is not mentioned in the release notes. How
do we want to handle this? I see two possible options:
1. Make version 2.14 of the plugin require Java 6, and update it to
use the latest available version of Checkstyle that runs on Java 6.
2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the
plugin with a Java 5 requirement. After that release 2.15 of the
plugin fairly straight away with a Java 6 requirement, and using the
latest available version of Checkstyle that runs on Java 6. It should
be noted that Checkstyle 5.8 does NOT work on Java 8 source code.
Perhaps there are other alternatives? What do you think?
On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <de...@apache.org> wrote:
> Hi,
>
> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
> motive for 2.14 is the ability to check Java 8 source code.
>
> According to the road map there are 5 unresolved issues scheduled for 2.14.
>
> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jira.plugin.system.project%3Aroadmap-panel
>
> If anyone is interested in fixing one or more of these for 2.14 now
> would be a good time to do it. Just reply here with an estimated time
> frame. If noone has the time for this now, I'll reschedule those
> issues for 2.15, which will require Java 6.
>
> --
> Dennis Lundberg
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Dennis Lundberg <de...@apache.org>.
There are now 3 issues left for the 2.14 version in JIRA. I've
commented on two of them. Unless someone wants to include them (and
are willing to do the work shortly) I will move them to the backlog.
After that I will start the release of 2.14.
Then I plan to do 2.15 (Java 6) and 2.16 (Java 7) in quick succession.
So if you have issues you want to add to those versions that are not
already in the road map, please add them now.
The road map is here:
http://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jira.plugin.system.project%3Aroadmap-panel
On Thu, Jan 8, 2015 at 8:12 PM, Hervé BOUTEMY <he...@free.fr> wrote:
> if nobody beats me at it, I'll work on it in 1 or 2 weeks: nothing really
> complex, just "to do"
>
> Regards,
>
> Hervé
>
> Le jeudi 8 janvier 2015 15:51:57 Dennis Lundberg a écrit :
>> Hi,
>>
>> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
>> motive for 2.14 is the ability to check Java 8 source code.
>>
>> According to the road map there are 5 unresolved issues scheduled for 2.14.
>>
>> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jira.
>> plugin.system.project%3Aroadmap-panel
>>
>> If anyone is interested in fixing one or more of these for 2.14 now
>> would be a good time to do it. Just reply here with an estimated time
>> frame. If noone has the time for this now, I'll reschedule those
>> issues for 2.15, which will require Java 6.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing the Checkstyle Plugin
Posted by Hervé BOUTEMY <he...@free.fr>.
if nobody beats me at it, I'll work on it in 1 or 2 weeks: nothing really
complex, just "to do"
Regards,
Hervé
Le jeudi 8 janvier 2015 15:51:57 Dennis Lundberg a écrit :
> Hi,
>
> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
> motive for 2.14 is the ability to check Java 8 source code.
>
> According to the road map there are 5 unresolved issues scheduled for 2.14.
>
> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jira.
> plugin.system.project%3Aroadmap-panel
>
> If anyone is interested in fixing one or more of these for 2.14 now
> would be a good time to do it. Just reply here with an estimated time
> frame. If noone has the time for this now, I'll reschedule those
> issues for 2.15, which will require Java 6.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org