You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "BasPH (via GitHub)" <gi...@apache.org> on 2023/03/01 11:58:42 UTC

[GitHub] [airflow] BasPH opened a new issue, #29836: Restrict allowed characters in connection ids

BasPH opened a new issue, #29836:
URL: https://github.com/apache/airflow/issues/29836

   ### Description
   
   I bumped into a bug where a customer suffixed a connection id with a whitespace e.g. "myconn ". When referencing the connection id "myconn" (without whitespace), you get a connection not found error.
   
   I avoid such human errors, I suggest restricting the characters allowed for connection ids.
   
   Some suggestions:
   - There's an `airflow.utils.helpers.validate_key` function for validating the DAG id. Probably a good idea to reuse this.
   - I believe variable ids are also not validated, would be good to check those too.
   
   ### Use case/motivation
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #29836: Restrict allowed characters in connection ids

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #29836:
URL: https://github.com/apache/airflow/issues/29836#issuecomment-1451464521

   Yep.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal closed issue #29836: Restrict allowed characters in connection ids

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal closed issue #29836: Restrict allowed characters in connection ids
URL: https://github.com/apache/airflow/issues/29836


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] josh-fell commented on issue #29836: Restrict allowed characters in connection ids

Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on issue #29836:
URL: https://github.com/apache/airflow/issues/29836#issuecomment-1451197555

   Good idea! All yours @BasPH!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org