[Impala-ASF-CR] Bump Postgres JDBC driver version to 9.4, update connection strings

["Fredy Wijaya (Code Review)" <ge...@cloudera.org>]

Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 )

Change subject: Bump Postgres JDBC driver version to 9.4, update connection strings
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/12894/1/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/12894/1/bin/impala-config.sh@567
PS1, Line 567: jre7
I'm curious why we chose the one with jre7 instead of the default one.


http://gerrit.cloudera.org:8080/#/c/12894/1/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/12894/1/fe/pom.xml@451
PS1, Line 451: <!-- https://mvnrepository.com/artifact/org.postgresql/postgresql -->
nit: this comment is not necessary


http://gerrit.cloudera.org:8080/#/c/12894/1/fe/pom.xml@453
PS1, Line 453:   
nit: use 2 spaces


http://gerrit.cloudera.org:8080/#/c/12894/1/fe/pom.xml@455
PS1, Line 455: 9.4.1212.jre7
shouldn't we be getting it from the IMPALA_POSTGRES_JDBC_DRIVER_VERSION environment variable?



-- 
To view, visit http://gerrit.cloudera.org:8080/12894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5423c18a9f8346dda7dae617b1764638b57b6c
Gerrit-Change-Number: 12894
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 19:55:09 +0000
Gerrit-HasComments: Yes