You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by jl...@apache.org on 2021/03/02 21:16:36 UTC
[incubator-pinot] branch
remove-methods-in-PinotMetricsRegistryListener created (now beb588e)
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch remove-methods-in-PinotMetricsRegistryListener
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at beb588e Remove methods in PinotMetricsRegistryListener
This branch includes the following new commits:
new beb588e Remove methods in PinotMetricsRegistryListener
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[incubator-pinot] 01/01: Remove methods in
PinotMetricsRegistryListener
Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch remove-methods-in-PinotMetricsRegistryListener
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit beb588e3ea789f59cf2d2d3beeb66daf36c5fb42
Author: Jack Li(Analytics Engineering) <jl...@jlli-mn1.linkedin.biz>
AuthorDate: Tue Mar 2 13:16:07 2021 -0800
Remove methods in PinotMetricsRegistryListener
---
.../metrics/yammer/YammerMetricsRegistryListener.java | 14 --------------
.../pinot/spi/metrics/PinotMetricsRegistryListener.java | 14 --------------
2 files changed, 28 deletions(-)
diff --git a/pinot-common/src/main/java/org/apache/pinot/common/metrics/yammer/YammerMetricsRegistryListener.java b/pinot-common/src/main/java/org/apache/pinot/common/metrics/yammer/YammerMetricsRegistryListener.java
index b449057..20646ae 100644
--- a/pinot-common/src/main/java/org/apache/pinot/common/metrics/yammer/YammerMetricsRegistryListener.java
+++ b/pinot-common/src/main/java/org/apache/pinot/common/metrics/yammer/YammerMetricsRegistryListener.java
@@ -18,11 +18,7 @@
*/
package org.apache.pinot.common.metrics.yammer;
-import com.yammer.metrics.core.Metric;
-import com.yammer.metrics.core.MetricName;
import com.yammer.metrics.core.MetricsRegistryListener;
-import org.apache.pinot.spi.metrics.PinotMetric;
-import org.apache.pinot.spi.metrics.PinotMetricName;
import org.apache.pinot.spi.metrics.PinotMetricsRegistryListener;
@@ -34,16 +30,6 @@ public class YammerMetricsRegistryListener implements PinotMetricsRegistryListen
}
@Override
- public void onMetricAdded(PinotMetricName name, PinotMetric metric) {
- _metricsRegistryListener.onMetricAdded((MetricName) name.getMetricName(), (Metric) metric.getMetric());
- }
-
- @Override
- public void onMetricRemoved(PinotMetricName name) {
- _metricsRegistryListener.onMetricRemoved((MetricName) name.getMetricName());
- }
-
- @Override
public Object getMetricsRegistryListener() {
return _metricsRegistryListener;
}
diff --git a/pinot-spi/src/main/java/org/apache/pinot/spi/metrics/PinotMetricsRegistryListener.java b/pinot-spi/src/main/java/org/apache/pinot/spi/metrics/PinotMetricsRegistryListener.java
index d3237ce..f0ec9d9 100644
--- a/pinot-spi/src/main/java/org/apache/pinot/spi/metrics/PinotMetricsRegistryListener.java
+++ b/pinot-spi/src/main/java/org/apache/pinot/spi/metrics/PinotMetricsRegistryListener.java
@@ -22,20 +22,6 @@ package org.apache.pinot.spi.metrics;
* Listeners for events from the registry. Listeners must be thread-safe.
*/
public interface PinotMetricsRegistryListener {
- /**
- * Called when a metric has been added to the {@link PinotMetricsRegistry}.
- *
- * @param name the name of the {@link PinotMetric}
- * @param metric the {@link PinotMetric}
- */
- void onMetricAdded(PinotMetricName name, PinotMetric metric);
-
- /**
- * Called when a metric has been removed from the {@link PinotMetricsRegistry}.
- *
- * @param name the name of the {@link PinotMetric}
- */
- void onMetricRemoved(PinotMetricName name);
/**
* Returned the actual object of MetricsRegistryListener.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org