You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/31 10:06:08 UTC

[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2890: Issues/2888-2 move local var connectionsList to the local scope

e2corporation commented on code in PR #2890:
URL: https://github.com/apache/incubator-devlake/pull/2890#discussion_r959401795


##########
config-ui/src/hooks/useConnectionManager.jsx:
##########
@@ -393,38 +393,32 @@ function useConnectionManager (
           )
           console.log('>> ALL SOURCE CONNECTIONS: ', aC)
         } else {
-          c = await request.get(
+          const c = await request.get(

Review Comment:
   A variable declaration should not be done inside an IF block, I think this will get hoisted anyway. The definition I had on `Ln 362` is correct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org