[jira] [Created] (SOLR-17256) Remove SolrRequest.getBasePath setBasePath

["David Smiley (Jira)" <ji...@apache.org>]

David Smiley created SOLR-17256:
-----------------------------------

             Summary: Remove SolrRequest.getBasePath setBasePath
                 Key: SOLR-17256
                 URL: https://issues.apache.org/jira/browse/SOLR-17256
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
          Components: SolrJ
            Reporter: David Smiley


SolrRequest has a getBasePath & setBasePath.  The naming is poor; it's the URL base to the Solr node like "http://localhost:8983/solr".  It's only recognized by HttpSolrClient; LBSolrClient (used by CloudSolrClient) ignores it and will in fact mutate the passed in request to its liking, which is rather ugly because it means a request cannot be used concurrently if the user wants to.  But moreover I think there's a conceptual discordance of placing this concept on SolrRequest given that some clients want to route requests to nodes *they* choose.  I propose removing this from SolrRequest and instead adding a method specific to HttpSolrClient.  Almost all existing usages of setBasePath immediately execute the request on an HttpSolrClient, so should be easy to change.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org