You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/10/16 17:12:07 UTC
[GitHub] [couchdb] jaydoane opened a new pull request, #4210: Make test prometheus port explicit
jaydoane opened a new pull request, #4210:
URL: https://github.com/apache/couchdb/pull/4210
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
These tests currently pass without this config parameter being set because it gets that configuration from a test template. However, this is fragile, and it's better practice to keep everything in one place.
This makes the configuration explicit.
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
```
make eunit apps=couch_prometheus suites=couch_prometheus_e2e_tests
```
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [x] Code is written and works correctly
- [x] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] Documentation changes were made in the `src/docs` folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jaydoane merged pull request #4210: Make test prometheus port explicit
Posted by GitBox <gi...@apache.org>.
jaydoane merged PR #4210:
URL: https://github.com/apache/couchdb/pull/4210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4210: Make test prometheus port explicit
Posted by GitBox <gi...@apache.org>.
nickva commented on code in PR #4210:
URL: https://github.com/apache/couchdb/pull/4210#discussion_r996470012
##########
src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl:
##########
@@ -81,6 +81,7 @@ setup_prometheus(WithAdditionalPort) ->
WithAdditionalPort,
Persist
),
+ ok = config:set("prometheus", "port", ?PROM_PORT),
Review Comment:
Should we set `Persist=false`? Or we specifically want to set it and keep at in the config file across restarts here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jaydoane commented on a diff in pull request #4210: Make test prometheus port explicit
Posted by GitBox <gi...@apache.org>.
jaydoane commented on code in PR #4210:
URL: https://github.com/apache/couchdb/pull/4210#discussion_r996602540
##########
src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl:
##########
@@ -81,6 +81,7 @@ setup_prometheus(WithAdditionalPort) ->
WithAdditionalPort,
Persist
),
+ ok = config:set("prometheus", "port", ?PROM_PORT),
Review Comment:
Ah yes of course. Thanks for catching that! Fixed in https://github.com/apache/couchdb/commit/ef2fcbc1f22d8e98ed76595efc155e4eca3f9467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org