[GitHub] [orc] dongjoon-hyun commented on a change in pull request #557: ORC-677: Add a deprecated legacy constructor SargApplier back

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #557:
URL: https://github.com/apache/orc/pull/557#discussion_r513979311



##########
File path: java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java
##########
@@ -2296,7 +2298,7 @@ public void testPositionalEvolutionAddColumnPPD() throws IOException {
 
     boolean[] rows = applier.pickRowGroups(new ReaderImpl.StripeInformationImpl(stripe,  1, -1, null),
         indexes, null, encodings, null, false);
-    assertEquals(SargApplier.READ_ALL_RGS, rows); //cannot filter for new column, return all rows
+    assertEquals(true, Arrays.equals(SargApplier.READ_ALL_RGS, rows)); //cannot filter for new column, return all rows

Review comment:
       This is irrelevant but satisfies the Travis CI's `EC_BAD_ARRAY_COMPARE` error detection. We can make this as a separate PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org