You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/09 17:57:52 UTC
[GitHub] [superset] zuzana-vej opened a new issue #14056: [Reporting] Solution for dashboards with multiple tabs
zuzana-vej opened a new issue #14056:
URL: https://github.com/apache/superset/issues/14056
Current Reporting solution only sends out the 1st dashboard tab. Dashboards can have multiple tabs as well as nested tabs.
The only workaround for users currently would be to either put all the charts they want emailed out to 1st tab, or create multiple dashboards just for the email report purpose. The later can cause clutter and make maintenance harder.
Proposed solution:
Let's discuss in this Issue. The major challenge is dealing with nested tabs.
**Option 1: User can specify which tabs to send out**
MVP
- Define 1 (or more) top level tabs (limited to a top level tabs only (since nested tabs can have many combinations); it would by default pick the first of the nested tabs if they exist)
Post MVP
- Discuss how to handle multiple tabs (a) user can define any tab and report will send that tab only or (b) user can define any combination of tabs regardless how many layers nested they are
pros:
- gives user flexibility to chose what to send out; ensuring only the important tabs of the dashboard gets emailed out;
cons:
- maintenance? what happens if tabs are renamed/removed/reshuffled?
**Option 2: User can send "entire dashboard"** which would result in multiple screenshots (or multiple-page PDF) including all the tabs.
pros:
- user doesn't have to define which tabs to send out; regardless of any changes to the dashboard, the full dashboard gets send out
cons:
- some dashboards are large, include less important charts, and it might be unnecessary to be sending out the entire dashboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-947328737
Would love some design inputs on how to enable users to select multiple tabs which can then be attached to a single email report. Options we thought about:
1. multiple drop down boxes
-- OK for one tab, but might be complicated for multiple tabs)
2. tabs combinations can be fully spelled out in a single dropdown and user can select 1+ items from the dropdown
Example (sample dashboard):
<img width="671" alt="Screen Shot 2021-10-18 at 1 17 42 PM" src="https://user-images.githubusercontent.com/61221714/138030398-22b88ac3-f0e5-43e3-9dde-72d5f4270f99.png">
Dropdown would have values:
> 1. Summary
> 2. Deep Dive | Summary
> 2. Deep Dive | Page Load Duration
> 2. Deep Dive | Usage Details
> 2. Deep Dive | Error Details
> 2. Deep Dive | Cache and Query Time
>
Would love some inputs from @jess-dillard / @mihir174 / @yousoph
(Cc @graceguo-supercat, @m-ajay)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
yousoph commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961452069
This is great! The proposal makes sense to me, @zuzana-vej and I like @graceguo-supercat 's suggestion of giving the user more information and choice when setting up a report.
I'd also suggest allowing users from the dashboard to select multiple tabs for their report. Maybe by default the report is for the current tab but they can select the default dashboard or additional tabs as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-959914058
There are two ways how user can get to Email report modal configuration - user has 2 ways to enter into the "editing report" flow.
**1. From dashboard:**
- User is on dashboard and clicks on the icon in top right corner. User might are viewing dashbord in this moment and are seeing **specific tabs combination** when they click on the report icon.
- The report will get configured for the **current tabs** user is viewing.
- User will see an information `configuring report for currently selected tabs` --> the proposal is to add this text above "REPORT NAME" textbox on the modal
- There is no need to add tab selector into the modal, because user will be configuring for the currently visible tabs
<img width="379" alt="modal-1" src="https://user-images.githubusercontent.com/61221714/140182897-0071467c-1358-49fb-8873-f35c70e5f7bf.png">
**2. From "Settings > Alerts&Reports"**
- User can enter the report configuration from "Settings > Alerts&Reports" and click "+Alert" button.
- The complex new report modal shows up and in this modal, user will be able to select the tabs to be sent out
<img width="1155" alt="modal-2" src="https://user-images.githubusercontent.com/61221714/140181734-0bbd23d2-286b-4cbe-b724-e0c361c2188b.png">
The experience to select tabs will be like tree style check boxes to display the tabs hierarchy, similarly like filter scopes:
<img width="139" alt="Screen Shot 2021-11-03 at 10 16 08 AM" src="https://user-images.githubusercontent.com/61221714/140182268-77b9bc0d-047a-452c-888e-2345008f214b.png">
- User can select any number of child tabs
- Is user selects a top level tab (or a tab which still has child tabs), by default only the child top level tab will get selected. (reason (1) mimic experience of viewing dashboard; (2) to prevent too many screenshots of dashboard unless needed as indicated by user)
- If user wants to send all child level tabs of a specific top level tab, they can manually check all the child checkboxes.
**Limits:**
Currently no plans to limit how many tabs user can select; if there are performance issues, we will revisit this area and add a warning or config variable to limit the tabs user can send.
Please share if you have any feedback to the plan. @jess-dillard @yousoph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-947326209
**Few data points from Airbnb Email Report users:**
~50 users; 11 responded a survey; 65% of users would use this feature immediately; 75% plan to only send multiple top level tab; 25% would use it for specifying a nested tabs to be send out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
yousoph commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961452069
This is great! The proposal makes sense to me, @zuzana-vej and I like @graceguo-supercat 's suggestion of giving the user more information and choice when setting up a report.
I'd also suggest allowing users from the dashboard to select multiple tabs for their report. Maybe by default the report is for the current tab but they can select the default dashboard or additional tabs as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej edited a comment on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
zuzana-vej edited a comment on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-947326209
**Few data points from Airbnb Email Report users:**
~50 users; 11 responded a survey; 65% of users would use this feature immediately; 75% plan to only send multiple top level tab; 25% would use it for specifying a nested tabs to be send out.
Users would like to send different tabs to different recipients (= can be satisfied as multiple report configurations).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961995296
@yousoph thanks for the suggestions; it can be done.
Different question - what was the initial thinking behind having tow different modals based on user entry point? The one from Settings is much more details which is why we though the multiple tabs is a detail setting and therefore can be on the details modal.
I am unsure how many users know that exists and whether a note on the modal they get when entering from Dashboard, saying something like `More detailed settings, like multiple owners, conditional alert, or multiple tabs, is available from Settings > Alerts & Reports.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-959914058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961286428
I agree @zuzana-vej's proposal, just 1 small suggestion:
For case 1 **From dashboard:**
instead of enforcing report on the current selected tab, give user an option: report default dashboard (by default), or report current selected tab. The UI could be similar to filter component scope configuration:
<img width="423" alt="Screen Shot 2021-11-04 at 10 11 44 AM" src="https://user-images.githubusercontent.com/27990562/140391976-82c2e54d-a4c0-451c-b2ec-a13cac6cffd2.png">
This is be consistent with current dashboard report behavior: by default, report the first tab (and its first children tabs).
Similarly for case 2 **From "Settings > Alerts&Reports"**
Also add an option: report default dashboard (by default), or select a tab. If user choose select a dashboard tab, then show the dashboard tabs tree.
cc @zuzana-vej
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jess-dillard commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
jess-dillard commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-948078921
Have you considered checkboxes? Nested tabs could be represented as indented checkboxes, where the top-level checkbox could control all beneath it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
yousoph commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961452069
This is great! The proposal makes sense to me, @zuzana-vej and I like @graceguo-supercat 's suggestion of giving the user more information and choice when setting up a report.
I'd also suggest allowing users from the dashboard to select multiple tabs for their report. Maybe by default the report is for the current tab but they can select the default dashboard or additional tabs as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961995296
@yousoph thanks for the suggestions; it can be done.
Different question - what was the initial thinking behind having tow different modals based on user entry point? The one from Settings is much more details which is why we though the multiple tabs is a detail setting and therefore can be on the details modal.
I am unsure how many users know that exists and whether a note on the modal they get when entering from Dashboard, saying something like `More detailed settings, like multiple owners, conditional alert, or multiple tabs, is available from Settings > Alerts & Reports.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961286428
I agree @zuzana-vej's proposal, just 1 small suggestion:
For case 1 **From dashboard:**
instead of enforcing report on the current selected tab, give user an option: report default dashboard (by default), or report current selected tab. The UI could be similar to filter component scope configuration:
<img width="423" alt="Screen Shot 2021-11-04 at 10 11 44 AM" src="https://user-images.githubusercontent.com/27990562/140391976-82c2e54d-a4c0-451c-b2ec-a13cac6cffd2.png">
This behavior will be consistent with current dashboard report behavior: by default, report the first tab (and its first children tabs).
Similarly for case 2 **From "Settings > Alerts&Reports"**
Also add an option: report default dashboard (by default), or select a tab. If user choose select a dashboard tab, then show the dashboard tabs tree.
cc @zuzana-vej
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961286428
I agree @zuzana-vej's proposal, just 1 small suggestion:
For case 1 **From dashboard:**
instead of enforcing report on the current selected tab, give user an option: report default dashboard (by default), or report current selected tab. The UI could be similar to filter component scope configuration:
<img width="423" alt="Screen Shot 2021-11-04 at 10 11 44 AM" src="https://user-images.githubusercontent.com/27990562/140391976-82c2e54d-a4c0-451c-b2ec-a13cac6cffd2.png">
This behavior will be consistent with current dashboard report behavior: by default, report the first tab (and its first children tabs).
Similarly for case 2 **From "Settings > Alerts&Reports"**
Also add an option: report default dashboard (by default), or select a tab. If user choose select a dashboard tab, then show the dashboard tabs tree.
cc @zuzana-vej
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-959914058
There are two ways how user can get to Email report modal configuration - user has 2 ways to enter into the "editing report" flow.
**1. From dashboard:**
- User is on dashboard and clicks on the icon in top right corner. User might are viewing dashbord in this moment and are seeing **specific tabs combination** when they click on the report icon.
- The report will get configured for the **current tabs** user is viewing.
- User will see an information `configuring report for currently selected tabs` --> the proposal is to add this text above "REPORT NAME" textbox on the modal
- There is no need to add tab selector into the modal, because user will be configuring for the currently visible tabs
<img width="379" alt="modal-1" src="https://user-images.githubusercontent.com/61221714/140182897-0071467c-1358-49fb-8873-f35c70e5f7bf.png">
**2. From "Settings > Alerts&Reports"**
- User can enter the report configuration from "Settings > Alerts&Reports" and click "+Alert" button.
- The complex new report modal shows up and in this modal, user will be able to select the tabs to be sent out
<img width="1155" alt="modal-2" src="https://user-images.githubusercontent.com/61221714/140181734-0bbd23d2-286b-4cbe-b724-e0c361c2188b.png">
The experience to select tabs will be like tree style check boxes to display the tabs hierarchy, similarly like filter scopes:
<img width="139" alt="Screen Shot 2021-11-03 at 10 16 08 AM" src="https://user-images.githubusercontent.com/61221714/140182268-77b9bc0d-047a-452c-888e-2345008f214b.png">
- User can select any number of child tabs
- Is user selects a top level tab (or a tab which still has child tabs), by default only the child top level tab will get selected. (reason (1) mimic experience of viewing dashboard; (2) to prevent too many screenshots of dashboard unless needed as indicated by user)
- If user wants to send all child level tabs of a specific top level tab, they can manually check all the child checkboxes.
**Limits:**
Currently no plans to limit how many tabs user can select; if there are performance issues, we will revisit this area and add a warning or config variable to limit the tabs user can send.
Please share if you have any feedback to the plan. @jess-dillard @yousoph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961286428
I agree @zuzana-vej's proposal, just 1 small suggestion:
For case 1 **From dashboard:**
instead of enforcing report on the current selected tab, give user an option: report default dashboard (by default), or report current selected tab. The UI could be similar to filter component scope configuration:
<img width="423" alt="Screen Shot 2021-11-04 at 10 11 44 AM" src="https://user-images.githubusercontent.com/27990562/140391976-82c2e54d-a4c0-451c-b2ec-a13cac6cffd2.png">
This is be consistent with current dashboard report behavior: by default, report the first tab (and its first children tabs).
Similarly for case 2 **From "Settings > Alerts&Reports"**
Also add an option: report default dashboard (by default), or select a tab. If user choose select a dashboard tab, then show the dashboard tabs tree.
cc @zuzana-vej
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961286428
I agree @zuzana-vej's proposal, just 1 small suggestion:
For case 1 **From dashboard:**
instead of enforcing report on the current selected tab, give user an option: report default dashboard (by default), or report current selected tab. The UI could be similar to filter component scope configuration:
<img width="423" alt="Screen Shot 2021-11-04 at 10 11 44 AM" src="https://user-images.githubusercontent.com/27990562/140391976-82c2e54d-a4c0-451c-b2ec-a13cac6cffd2.png">
This behavior will be consistent with current dashboard report behavior: by default, report the first tab (and its first children tabs).
Similarly for case 2 **From "Settings > Alerts&Reports"**
Also add an option: report default dashboard (by default), or select a tab. If user choose select a dashboard tab, then show the dashboard tabs tree.
cc @zuzana-vej
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961286428
I agree @zuzana-vej's proposal, just 1 small suggestion:
For case 1 **From dashboard:**
instead of enforcing report on the current selected tab, give user an option: report default dashboard (by default), or report current selected tab. The UI could be similar to filter component scope configuration:
<img width="423" alt="Screen Shot 2021-11-04 at 10 11 44 AM" src="https://user-images.githubusercontent.com/27990562/140391976-82c2e54d-a4c0-451c-b2ec-a13cac6cffd2.png">
This is be consistent with current dashboard report behavior: by default, report the first tab (and its first children tabs).
Similarly for case 2 **From "Settings > Alerts&Reports"**
Also add an option: report default dashboard (by default), or select a tab. If user choose select a dashboard tab, then show the dashboard tabs tree.
cc @zuzana-vej
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-961995296
@yousoph thanks for the suggestions; it can be done.
Different question - what was the initial thinking behind having tow different modals based on user entry point? The one from Settings is much more details which is why we though the multiple tabs is a detail setting and therefore can be on the details modal.
I am unsure how many users know that exists and whether a note on the modal they get when entering from Dashboard, saying something like `More detailed settings, like multiple owners, conditional alert, or multiple tabs, is available from Settings > Alerts & Reports.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #14056: [alert/report] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-964476668
Hi @yousoph I also prefer Zuzana's proposal: set default or selected tab as _selected report tab_ inside a dashboard's report menu, and show tab selector in the report detail menu.
When setup report schedule, I feel people want to make sure they are sending out the right tab, so they want to verify it in the dashboard during the setup schedule.
- In dashboard, users are easy to navigate to the right place, and set. So inside dashboard, create a new selector and ask user to choose a tab to report, seems not necessary.
- In report detail page, preview dashboard is a little harder, so ppl probably to open a dashboard in other browser and check it. But probably we don't have better way for user to preview selected tab inside report menu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #14056: [Reporting] Solution for dashboards with multiple tabs
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #14056:
URL: https://github.com/apache/superset/issues/14056#issuecomment-824302115
Update: We are planning to prioritize this feature at some point late Q2/earlyQ3, but keeping this GH# open as a space for discussion (to enable this tab specific discussion separately from the #13954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org