You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/19 22:17:24 UTC

[GitHub] mseth10 commented on a change in pull request #12884: adding unittest for MKLDNN Softmax operator

mseth10 commented on a change in pull request #12884: adding unittest for MKLDNN Softmax operator
URL: https://github.com/apache/incubator-mxnet/pull/12884#discussion_r234803007
 
 

 ##########
 File path: tests/cpp/include/test_mkldnn.h
 ##########
 @@ -227,6 +227,7 @@ struct OpAttrs {
   nnvm::NodeAttrs attrs;
   std::vector<DispatchMode> dispatches;
   std::set<OpReqType> requests;
+  std::set<int> accept_dims;
 
 Review comment:
   No, it need not be sorted. Updating to use unordered_set. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services