You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Randy Abernethy (JIRA)" <ji...@apache.org> on 2015/02/02 15:41:34 UTC

[jira] [Commented] (THRIFT-2963) nodejs - add test coverage

    [ https://issues.apache.org/jira/browse/THRIFT-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301335#comment-14301335 ] 

Randy Abernethy commented on THRIFT-2963:
-----------------------------------------

Hey [~andrewdeandrade],

Nice addition, however as configured the report describes the coverage of the test files rather than the thrift files. While finding slack in the tests is interesting and  useful, the coverage we really care about is lib/nodejs/lib/thrift/*. Thoughts?

-Randy 

> nodejs - add test coverage
> --------------------------
>
>                 Key: THRIFT-2963
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2963
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>         Environment: Trusty64 Vagrant Box
>            Reporter: Andrew de Andrade
>            Priority: Trivial
>         Attachments: 0001-nodejs-Add-test-coverage.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)