[GitHub] [flink] pnowojski commented on a change in pull request #18845: [FLINK-25958][runtime] Report completed checkpoint to statistic only after the completed checkpoint is added to the store.

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #18845:
URL: https://github.com/apache/flink/pull/18845#discussion_r815735885



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -351,4 +276,81 @@ public String toString() {
                 "%s %d @ %d for %s located at %s",
                 props.getCheckpointType().getName(), checkpointID, timestamp, job, externalPointer);
     }
+
+    /** Implementation of {@link org.apache.flink.runtime.checkpoint.Checkpoint.DiscardObject}. */
+    @NotThreadSafe
+    public class CompletedCheckpointDiscardObject implements DiscardObject {

Review comment:
       What I had in mind was to move all of the logic except of the `discard()` call to the `CheckpointCoordinator` "thread". For example `shouldBeDiscardedOnSubsume()`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org