You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by ptzianos <gi...@git.apache.org> on 2016/10/20 13:59:44 UTC

[GitHub] libcloud pull request #918: [LIBCLOUD-864] Fix Docker Driver install_image r...

GitHub user ptzianos opened a pull request:

    https://github.com/apache/libcloud/pull/918

    [LIBCLOUD-864] Fix Docker Driver install_image response parsing

    ## Changes Title (replace this with a logical title for your changes)
    
    ### Description
    
    As reported in the corresponding bug, the docker daemon will respond in an install_image call with all the messages produced during the procedure parsed as json docs. In that case the response headers also contain the value 'transfer-encoding':'chunked'. That kind of response can now be parsed properly by the DockerResponse parse_body method. Also, another small change is that previously the id of the new image was marked in the json document as id, but now it's marked as sha256, so the regex used to discover the id has been updated. Finally the test data have been updated both for linux and for mac for install_image tests where this behavior has been observed and the version of the test fixtures has been bumped up to 124 to show the change more clearly.
    
    ### Status
    
    Done and ready for review.
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ptzianos/libcloud libcloud_864_docker_driver_response_parsing_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/918.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #918
    
----
commit 2f9c3a3aa1b6654ede67a2a6e63dd3e59437c6de
Author: ptzianos <pa...@gmail.com>
Date:   2016-10-20T13:49:20Z

    [LIBCLOUD-864] Fix Docker Driver install_image response parsing and update test fixtures

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #918: [LIBCLOUD-864] Fix Docker Driver install_image r...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/918


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---