You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/03/20 20:01:09 UTC
Re: Review Request 45088: Edited master's flag help strings to match
the agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45088/
-----------------------------------------------------------
(Updated March 20, 2016, 7:01 p.m.)
Review request for mesos, Adam B and Joerg Schad.
Summary (updated)
-----------------
Edited master's flag help strings to match the agent.
Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849
Repository: mesos
Description (updated)
-------
Edited master's flag help strings to match the agent.
With the addition of the `--authenticate_http` and `--http_credentials` flags for the agent, the flag help strings have been improved slightly. This patch edits the master's help string to match that of the agent.
Diffs (updated)
-----
docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404
src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
Diff: https://reviews.apache.org/r/45088/diff/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 45088: Edited master's flag help strings to match
the agent.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45088/#review124466
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44678, 44703, 44515, 44523, 44553, 44554, 45088]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 20, 2016, 7:01 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45088/
> -----------------------------------------------------------
>
> (Updated March 20, 2016, 7:01 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Edited master's flag help strings to match the agent.
>
> With the addition of the `--authenticate_http` and `--http_credentials` flags for the agent, the flag help strings have been improved slightly. This patch edits the master's help string to match that of the agent.
>
>
> Diffs
> -----
>
> docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
>
> Diff: https://reviews.apache.org/r/45088/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 45088: Edited master's flag help strings to match
the agent.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45088/#review124524
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On March 20, 2016, 12:01 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45088/
> -----------------------------------------------------------
>
> (Updated March 20, 2016, 12:01 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Edited master's flag help strings to match the agent.
>
> With the addition of the `--authenticate_http` and `--http_credentials` flags for the agent, the flag help strings have been improved slightly. This patch edits the master's help string to match that of the agent.
>
>
> Diffs
> -----
>
> docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
>
> Diff: https://reviews.apache.org/r/45088/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 45088: Edited master's flag help strings to match
the agent.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45088/#review124530
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On March 20, 2016, 7:01 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45088/
> -----------------------------------------------------------
>
> (Updated March 20, 2016, 7:01 p.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Edited master's flag help strings to match the agent.
>
> With the addition of the `--authenticate_http` and `--http_credentials` flags for the agent, the flag help strings have been improved slightly. This patch edits the master's help string to match that of the agent.
>
>
> Diffs
> -----
>
> docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
>
> Diff: https://reviews.apache.org/r/45088/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>