You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/04/14 19:24:26 UTC

[GitHub] [camel-k] fshaikh-vgs edited a comment on issue #2205: Expose gRPC endpoint with Knative serving

fshaikh-vgs edited a comment on issue #2205:
URL: https://github.com/apache/camel-k/issues/2205#issuecomment-819772494


   Hi @astefanutti .  Thank you for all your help so far.
   
   As @moehajj said, we are trying to work without knative and even using `--profile=kubernetes` is not working.  After some analysis of camel-k code, we found [this](https://github.com/apache/camel-k/blob/5f8bd10de70a5e8e7b1179f1d8521e2263fd678e/pkg/trait/service.go#L94):
   
   ```
   if !meta.ExposesHTTPServices {
   	e.Integration.Status.SetCondition(
   		v1.IntegrationConditionServiceAvailable,
   		corev1.ConditionFalse,
   		v1.IntegrationConditionServiceNotAvailableReason,
   		"no http service required",
   	)
   
   	return false, nil
   }
   ```
   
   Having a check that a service must be HTTP is pretty restrictive given that a Camel integration could support any protocol.  I understand why this restriction would exist in Knative, but I don't see the value in this being a restriction in Camel-K.
   
   There should be a way to completely bypass this check or force creation of a kubernetes service even if this check fails.  Should I create a new issue for this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org