You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/03/05 01:20:13 UTC
[GitHub] [hadoop] jojochuang opened a new pull request #1877: HADOOP-16908.
Prune jackson 1 code again.
jojochuang opened a new pull request #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877
The PR migrates all jackson 1 code to jackson2. It compiles. Let's see what precommit bot says.
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #1877:
HADOOP-16908. Prune jackson 1 code again.
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#discussion_r388717083
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/DockerClientConfigHandler.java
##########
@@ -103,7 +103,7 @@ public static Credentials readCredentialsFromConfigFile(Path configFile,
Review comment:
In L99-101:
* ObjectMapper instance should be reused.
* Two methods are deprecated.
Should be fixed in a separate jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #1877:
HADOOP-16908. Prune jackson 1 code again.
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#discussion_r388717083
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/DockerClientConfigHandler.java
##########
@@ -103,7 +103,7 @@ public static Credentials readCredentialsFromConfigFile(Path configFile,
Review comment:
In DockerClientConfigHandler L99-101:
* ObjectMapper instance should be reused.
* Two methods are deprecated.
Should be fixed in a separate jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #1877:
HADOOP-16908. Prune jackson 1 code again.
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#discussion_r388715598
##########
File path: hadoop-tools/hadoop-azure/pom.xml
##########
@@ -283,6 +271,14 @@
<artifactId>assertj-core</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-annotations</artifactId>
+ </dependency>
Review comment:
Would you fix the indent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #1877:
HADOOP-16908. Prune jackson 1 code again.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#discussion_r393728614
##########
File path: hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/TestSynthJobGeneration.java
##########
@@ -17,10 +17,11 @@
*/
package org.apache.hadoop.yarn.sls;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.databind.JsonMappingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
Review comment:
needs a blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on issue #1877: HADOOP-16908. Prune
jackson 1 code again.
Posted by GitBox <gi...@apache.org>.
aajisaka commented on issue #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#issuecomment-595603775
AbfsHttpOperations.java
```
final ObjectMapper objectMapper = new ObjectMapper();
this.listResultSchema = objectMapper.readValue(stream, ListResultSchema.class);
```
ObjectMapper instance should be re-used. It can be fixed in a separate jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #1877:
HADOOP-16908. Prune jackson 1 code again.
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#discussion_r388726725
##########
File path: LICENSE-binary
##########
@@ -324,10 +324,6 @@ org.apache.kerby:kerby-xdr:1.0.1
org.apache.kerby:token-provider:1.0.1
org.apache.yetus:audience-annotations:0.5.0
org.apache.zookeeper:zookeeper:3.4.13
-org.codehaus.jackson:jackson-core-asl:1.9.13
-org.codehaus.jackson:jackson-jaxrs:1.9.13
-org.codehaus.jackson:jackson-mapper-asl:1.9.13
-org.codehaus.jackson:jackson-xc:1.9.13
Review comment:
Jersey 1.x has a Jackson1 dependency and the Hadoop binary release contains Jackson1 jars. Therefore the lines cannot be removed for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #1877:
HADOOP-16908. Prune jackson 1 code again.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#discussion_r393728393
##########
File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java
##########
@@ -31,11 +31,11 @@
import javax.net.ssl.HttpsURLConnection;
import javax.net.ssl.SSLSocketFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.core.JsonToken;
+import com.fasterxml.jackson.databind.ObjectMapper;
Review comment:
needs a blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #1877:
HADOOP-16908. Prune jackson 1 code again.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#discussion_r393728174
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/ProvidedVolumeImpl.java
##########
@@ -32,6 +32,10 @@
import java.util.concurrent.atomic.AtomicLong;
import java.util.concurrent.locks.ReentrantReadWriteLock;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.ObjectReader;
+import com.fasterxml.jackson.databind.ObjectWriter;
Review comment:
needs a blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #1877:
HADOOP-16908. Prune jackson 1 code again.
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#discussion_r388717083
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/DockerClientConfigHandler.java
##########
@@ -103,7 +103,7 @@ public static Credentials readCredentialsFromConfigFile(Path configFile,
Review comment:
In DockerClientConfigHandler L99-101:
* ObjectMapper instance should be reused.
* Two methods are deprecated.
Should be fixed in a separate jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #1877:
HADOOP-16908. Prune jackson 1 code again.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#discussion_r393728897
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/runc/RuncContainerExecutorConfig.java
##########
@@ -19,9 +19,9 @@
package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.runc;
+import com.fasterxml.jackson.annotation.JsonRawValue;
+import com.fasterxml.jackson.databind.annotation.JsonSerialize;
Review comment:
needs a blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #1877:
HADOOP-16908. Prune jackson 1 code again.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #1877: HADOOP-16908. Prune jackson 1 code again.
URL: https://github.com/apache/hadoop/pull/1877#discussion_r393728056
##########
File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterClientRejectOverload.java
##########
@@ -37,6 +37,7 @@
import java.util.concurrent.Future;
import java.util.concurrent.atomic.AtomicInteger;
+import com.fasterxml.jackson.databind.ObjectMapper;
Review comment:
needs a blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org