You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "IainHull (via GitHub)" <gi...@apache.org> on 2023/06/12 10:12:32 UTC

[GitHub] [incubator-pekko] IainHull commented on a diff in pull request #385: CVE-2023-31442 Address DNS poisoning vulnerability

IainHull commented on code in PR #385:
URL: https://github.com/apache/incubator-pekko/pull/385#discussion_r1226417525


##########
actor/src/main/scala/org/apache/pekko/io/dns/internal/DnsClient.scala:
##########
@@ -35,12 +35,21 @@ import pekko.pattern.{ BackoffOpts, BackoffSupervisor }
 @InternalApi private[pekko] object DnsClient {
   sealed trait DnsQuestion {
     def id: Short
+    def withId(newId: Short): DnsQuestion = {

Review Comment:
   Enable us to resend questions with a new id when handling duplicates



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org