You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Fedotov (JIRA)" <ji...@apache.org> on 2008/03/24 20:37:26 UTC
[jira] Created: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
[drlvm][jni] using a component manger for VM startup
----------------------------------------------------
Key: HARMONY-5644
URL: https://issues.apache.org/jira/browse/HARMONY-5644
Project: Harmony
Issue Type: Improvement
Components: DRLVM
Reporter: Alexei Fedotov
Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586418#action_12586418 ]
Pavel Pervov commented on HARMONY-5644:
---------------------------------------
Committed create_java_vm_via_compmgr_3.patch at revision 645545. Please, verify.
GC patch is trivial. I'll commit it later.
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Assignee: Pavel Pervov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch, gc.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-5644:
------------------------------------
Attachment: gc.patch
Forgot to attach a related gc patch. May be it is not needed though.
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Assignee: Pavel Pervov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch, gc.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586290#action_12586290 ]
Pavel Pervov commented on HARMONY-5644:
---------------------------------------
Alexei, thanks for your answers.
Re (2): Global_Env is allocated with placement new. So, it is invalid to use 'delete <pointer to Global_Env>', direct call to destructor must be used instead. This is not in your patch, I've just noticed this reading the patch as you've introduced some changes near that place. I'll include the fix for this with your patch if you don't mind.
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Assignee: Pavel Pervov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch, gc.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585514#action_12585514 ]
Alexei Fedotov commented on HARMONY-5644:
-----------------------------------------
Hello Pavel,
1. I'm ok with any naming. The only thing I grok is that "Intel" is no longer valid. :-) Feel free to update as you like.
2. I have not caught Global_Env note: I have not touched it with my changes yet. It is not yet understood how to refactor it since it calls C++ constructors, which a component manger is pure C.
3. VM uses component manger pool in terms of memory allocation. Instead of using a pool kept in a static global variable now the dedicated pool is returned for VM from a component manager.
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Assignee: Pavel Pervov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585272#action_12585272 ]
Alexei Fedotov commented on HARMONY-5644:
-----------------------------------------
The last patch passes tests on four platforms and is ready to be committed. Thank you in advance.
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585422#action_12585422 ]
Pavel Pervov commented on HARMONY-5644:
---------------------------------------
Should the vendor be "Aoache Software Foundation" rather than "Apache Harmony"?
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585425#action_12585425 ]
Pavel Pervov commented on HARMONY-5644:
---------------------------------------
It is long sitting problem: Global_Env is allocated with placement new. So, calling 'delete' for this pointer is invalid, destructor should be called directly, like this 'java_vm->vm_env->~Global_Env()'.
Alexey, please, answer my questions, I'll update the patch myself.
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585515#action_12585515 ]
Alexei Fedotov commented on HARMONY-5644:
-----------------------------------------
Let me describe the change in few words: before the change APR_RING and global pool were used to keep VM instances. Currently the component manager designed for that is used for that purpose.
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Assignee: Pavel Pervov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-5644:
------------------------------------
Attachment: create_java_vm_via_compmgr_1.patch
Fixed a mispaced instnace verification. Moved logger initialization earlier.
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Pervov reassigned HARMONY-5644:
-------------------------------------
Assignee: Pavel Pervov
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Assignee: Pavel Pervov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585423#action_12585423 ]
Pavel Pervov commented on HARMONY-5644:
---------------------------------------
Should we mention "Java" in decription?
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-5644:
------------------------------------
Attachment: create_java_vm_via_compmgr_2.patch
Fixed linux goto errors. Found problems with cunit tests (so this is not a complete patch yet).
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-5644:
------------------------------------
Attachment: create_java_vm_via_compmgr.patch
The patch passes standard loads, may be I should add more tests for stressing VM creation and destruction.
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: create_java_vm_via_compmgr.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-5644:
------------------------------------
Attachment: create_java_vm_via_compmgr_3.patch
Enabled cunit.test
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5644) [drlvm][jni] using a component
manger for VM startup
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585436#action_12585436 ]
Pavel Pervov commented on HARMONY-5644:
---------------------------------------
Well, I've read through the patch but AFAIU VM is still created without the use of component manager. Am I right?
> [drlvm][jni] using a component manger for VM startup
> ----------------------------------------------------
>
> Key: HARMONY-5644
> URL: https://issues.apache.org/jira/browse/HARMONY-5644
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Assignee: Pavel Pervov
> Attachments: create_java_vm_via_compmgr.patch, create_java_vm_via_compmgr_1.patch, create_java_vm_via_compmgr_2.patch, create_java_vm_via_compmgr_3.patch
>
>
> Unifying pool usage on VM startup is a step for providing multi-VM environment and VM internal state serialization. Strangely, massive changes started to work before any runtime fixes, so I'm currently writing a stress test to check the patch in depth.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.