You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Kidcredible300 (via GitHub)" <gi...@apache.org> on 2025/07/02 23:00:12 UTC

[PR] Update to 2.1.4 [accumulo-proxy]

Kidcredible300 opened a new pull request, #86:
URL: https://github.com/apache/accumulo-proxy/pull/86

   While Accumulo is being updated to 2.1.4, this Pull Request will work on updating the Accumulo Proxy to work with it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update to 2.1.4 [accumulo-proxy]

Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on code in PR #86:
URL: https://github.com/apache/accumulo-proxy/pull/86#discussion_r2294398379


##########
pom.xml:
##########
@@ -104,14 +104,14 @@
       <dependency>
         <groupId>io.micrometer</groupId>
         <artifactId>micrometer-bom</artifactId>
-        <version>1.12.2</version>

Review Comment:
   alternatively, we could probably import the accumulo-project bom and then remove a lot of the specific version numbers in this pom as they would inherit the versions from the imported bom. 
   
   Might be a good follow-on issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update to 2.1.4 [accumulo-proxy]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #86:
URL: https://github.com/apache/accumulo-proxy/pull/86#issuecomment-3211720527

   @Kidcredible300  now that 2.1.4 is released this should build.  However I can not see a way to make github actions rerun this build.  Can you push a commit to this branch?  Could be any change, could make two commits locally one to add some white space and a second to remove it and push those.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update to 2.1.4 [accumulo-proxy]

Posted by "Kidcredible300 (via GitHub)" <gi...@apache.org>.
Kidcredible300 commented on code in PR #86:
URL: https://github.com/apache/accumulo-proxy/pull/86#discussion_r2294337790


##########
pom.xml:
##########
@@ -104,14 +104,14 @@
       <dependency>
         <groupId>io.micrometer</groupId>
         <artifactId>micrometer-bom</artifactId>
-        <version>1.12.2</version>

Review Comment:
   Yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update to 2.1.4 [accumulo-proxy]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #86:
URL: https://github.com/apache/accumulo-proxy/pull/86#discussion_r2293918860


##########
pom.xml:
##########
@@ -104,14 +104,14 @@
       <dependency>
         <groupId>io.micrometer</groupId>
         <artifactId>micrometer-bom</artifactId>
-        <version>1.12.2</version>

Review Comment:
   Why were these changed? Were all of the dependency versions updated to be in synch w/ what Accumulo 2.1.4 is using?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update to 2.1.4 [accumulo-proxy]

Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on code in PR #86:
URL: https://github.com/apache/accumulo-proxy/pull/86#discussion_r2298567301


##########
pom.xml:
##########
@@ -104,14 +104,14 @@
       <dependency>
         <groupId>io.micrometer</groupId>
         <artifactId>micrometer-bom</artifactId>
-        <version>1.12.2</version>

Review Comment:
   Created issue #91 for the follow-on work
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update to 2.1.4 [accumulo-proxy]

Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr merged PR #86:
URL: https://github.com/apache/accumulo-proxy/pull/86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update to 2.1.4 [accumulo-proxy]

Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on code in PR #86:
URL: https://github.com/apache/accumulo-proxy/pull/86#discussion_r2294395988


##########
pom.xml:
##########
@@ -104,14 +104,14 @@
       <dependency>
         <groupId>io.micrometer</groupId>
         <artifactId>micrometer-bom</artifactId>
-        <version>1.12.2</version>

Review Comment:
   If the goal is to match accumulo 2.1.4 then spotbugs-annotations should also be updated.
   `<version>4.8.3</version>`to `<version>4.9.3</version> `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org