You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/10/08 22:01:54 UTC
[kudu-CR] tools: return errors when making calls to the master
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14390
Change subject: tools: return errors when making calls to the master
......................................................................
tools: return errors when making calls to the master
Change-Id: Ia49eb7d020dcd0cab4dbe8c79c3d32613ac8432f
---
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_master.cc
2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/14390/1
--
To view, visit http://gerrit.cloudera.org:8080/14390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia49eb7d020dcd0cab4dbe8c79c3d32613ac8432f
Gerrit-Change-Number: 14390
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] tools: return errors when making calls to the master
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14390 )
Change subject: tools: return errors when making calls to the master
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia49eb7d020dcd0cab4dbe8c79c3d32613ac8432f
Gerrit-Change-Number: 14390
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Oct 2019 22:04:39 +0000
Gerrit-HasComments: No
[kudu-CR] tools: return errors when making calls to the master
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14390 )
Change subject: tools: return errors when making calls to the master
......................................................................
Patch Set 3: Code-Review+2
Just rebased.
--
To view, visit http://gerrit.cloudera.org:8080/14390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia49eb7d020dcd0cab4dbe8c79c3d32613ac8432f
Gerrit-Change-Number: 14390
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Oct 2019 23:33:55 +0000
Gerrit-HasComments: No
[kudu-CR] tools: return errors when making calls to the master
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14390 )
Change subject: tools: return errors when making calls to the master
......................................................................
tools: return errors when making calls to the master
Change-Id: Ia49eb7d020dcd0cab4dbe8c79c3d32613ac8432f
---
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_master.cc
2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/14390/3
--
To view, visit http://gerrit.cloudera.org:8080/14390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia49eb7d020dcd0cab4dbe8c79c3d32613ac8432f
Gerrit-Change-Number: 14390
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tools: return errors when making calls to the master
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14390 )
Change subject: tools: return errors when making calls to the master
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia49eb7d020dcd0cab4dbe8c79c3d32613ac8432f
Gerrit-Change-Number: 14390
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Oct 2019 22:41:06 +0000
Gerrit-HasComments: No
[kudu-CR] tools: return errors when making calls to the master
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14390 )
Change subject: tools: return errors when making calls to the master
......................................................................
tools: return errors when making calls to the master
Change-Id: Ia49eb7d020dcd0cab4dbe8c79c3d32613ac8432f
Reviewed-on: http://gerrit.cloudera.org:8080/14390
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_master.cc
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia49eb7d020dcd0cab4dbe8c79c3d32613ac8432f
Gerrit-Change-Number: 14390
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)