You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/05/24 15:10:42 UTC
[GitHub] [echarts] susiwen8 opened a new pull request, #17100: feat(funnel): new funnel style
susiwen8 opened a new pull request, #17100:
URL: https://github.com/apache/echarts/pull/17100
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
The shape of the last piece of funnel should be rect.
### Fixed issues
- #12937 Can't close, cause the second one isn't inclued in this PR
## Details
### Before: What was the problem?
<img width="972" alt="Screen Shot 2022-05-24 at 11 09 26 PM" src="https://user-images.githubusercontent.com/20318608/170069817-70b710a4-40a1-4d58-983a-4910c5365cd5.png">
<img width="904" alt="Screen Shot 2022-05-24 at 11 09 42 PM" src="https://user-images.githubusercontent.com/20318608/170069826-90bd991b-1c27-449f-ad8a-f5970adccd75.png">
### After: How is it fixed in this PR?
<img width="932" alt="Screen Shot 2022-05-24 at 11 04 08 PM" src="https://user-images.githubusercontent.com/20318608/170069428-749cab39-1222-4dcb-b0ea-332b7806f0fd.png">
<img width="961" alt="Screen Shot 2022-05-24 at 11 04 23 PM" src="https://user-images.githubusercontent.com/20318608/170069439-a416b830-851c-430f-8f84-f7ac973a4fba.png">
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pe-2 commented on pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
pe-2 commented on PR #17100:
URL: https://github.com/apache/echarts/pull/17100#issuecomment-1140351779
Why are the last two labels out of place?For me, an ocD, It's too uncomfortable.😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] susiwen8 commented on pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on PR #17100:
URL: https://github.com/apache/echarts/pull/17100#issuecomment-1136099386
Haha, my mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] susiwen8 closed pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
susiwen8 closed pull request #17100: feat(funnel): new funnel style
URL: https://github.com/apache/echarts/pull/17100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] susiwen8 closed pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
susiwen8 closed pull request #17100: feat(funnel): new funnel style
URL: https://github.com/apache/echarts/pull/17100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pe-2 commented on pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
pe-2 commented on PR #17100:
URL: https://github.com/apache/echarts/pull/17100#issuecomment-1140404561
I got it. 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17100:
URL: https://github.com/apache/echarts/pull/17100#issuecomment-1136055466
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] tyn1998 commented on pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
tyn1998 commented on PR #17100:
URL: https://github.com/apache/echarts/pull/17100#issuecomment-1136106976
Thank you! Maybe I can look into this and help implementing the feature later~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] tyn1998 commented on pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
tyn1998 commented on PR #17100:
URL: https://github.com/apache/echarts/pull/17100#issuecomment-1136097729
> @tyn1998 Cool, could you make a PR for it, I can close this one
Haha, I think part of [the project](https://summer-ospp.ac.cn/#/org/prodetail/22ffc0288) listed in OSPP Summer 2022 is resolved BY YOU. Hahaha~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] susiwen8 commented on pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on PR #17100:
URL: https://github.com/apache/echarts/pull/17100#issuecomment-1136092739
> Haha, I think part of [the project](https://summer-ospp.ac.cn/#/org/prodetail/22ffc0288) listed in OSPP Summer 2022 is resolved.
@tyn1998 Cool, could you make a PR for it, I can close this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] tyn1998 commented on pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
tyn1998 commented on PR #17100:
URL: https://github.com/apache/echarts/pull/17100#issuecomment-1140354165
Hi @pe-2~
Maybe @susiwen8 set the option on purpose to test [different label positions](https://echarts.apache.org/zh/option.html#series-funnel.label), I suppose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] mfbaltaza commented on pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
mfbaltaza commented on PR #17100:
URL: https://github.com/apache/echarts/pull/17100#issuecomment-1217009992
How do I make the chart horizontal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] tyn1998 commented on pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
tyn1998 commented on PR #17100:
URL: https://github.com/apache/echarts/pull/17100#issuecomment-1136090828
Haha, I think part of [the project](https://summer-ospp.ac.cn/#/org/prodetail/22ffc0288) listed in OSPP Summer 2022 is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] susiwen8 commented on pull request #17100: feat(funnel): new funnel style
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on PR #17100:
URL: https://github.com/apache/echarts/pull/17100#issuecomment-1136101152
Oh, I see, better close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org