You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "codope (via GitHub)" <gi...@apache.org> on 2023/03/16 12:28:10 UTC

[GitHub] [hudi] codope opened a new pull request, #8206: [HUDI-5891] Fix clustering on bootstrapped tables

codope opened a new pull request, #8206:
URL: https://github.com/apache/hudi/pull/8206

   ### Change Logs
   
   Fixes clustering on bootstrapped tables. There are two issues:
   1. Clustering strategy added bootstrap as well as source paths to the glob paths. This was causing an error, as mentioned in HUDI-5891, while building file index. There is no need to add source path as that is handled in `HoodieBootstrapRDD`.
   2. Sometimes the path will have scheme and sometimes it will be without scheme, so getting the relative partition path based was buggy. Corrected that in `HoodieBootstrapRelation`.
   
   ### Impact
   
   No public API change. A bug fix for the bootstrap path.
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] KnightChess commented on pull request #8206: [HUDI-5891] Fix clustering on bootstrapped tables

Posted by "KnightChess (via GitHub)" <gi...@apache.org>.
KnightChess commented on PR #8206:
URL: https://github.com/apache/hudi/pull/8206#issuecomment-1472938877

   just like this：
   <img width="1172" alt="image" src="https://user-images.githubusercontent.com/20125927/225781792-9559b400-a965-4d82-8abb-2b7dba10d885.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codope commented on pull request #8206: [HUDI-5891] Fix clustering on bootstrapped tables

Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on PR #8206:
URL: https://github.com/apache/hudi/pull/8206#issuecomment-1484166251

   @KnightChess The issue seems to be present in master and this patch does not cover it. I have created HUDI-5987 to track this issue. #8289 attempts to fix this but it only works for Spark 3.2+ versions. @jonvex is investigating it. Would appreciate any inputs on that PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8206: [HUDI-5891] Fix clustering on bootstrapped tables

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8206:
URL: https://github.com/apache/hudi/pull/8206#issuecomment-1471885122

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b62087f28fb5750a013bbccb96eed2fc8f54f79",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0b62087f28fb5750a013bbccb96eed2fc8f54f79",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b62087f28fb5750a013bbccb96eed2fc8f54f79 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8206: [HUDI-5891] Fix clustering on bootstrapped tables

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8206:
URL: https://github.com/apache/hudi/pull/8206#issuecomment-1471895364

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b62087f28fb5750a013bbccb96eed2fc8f54f79",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15753",
       "triggerID" : "0b62087f28fb5750a013bbccb96eed2fc8f54f79",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b62087f28fb5750a013bbccb96eed2fc8f54f79 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15753) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan merged pull request #8206: [HUDI-5891] Fix clustering on bootstrapped tables

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #8206:
URL: https://github.com/apache/hudi/pull/8206


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] jonvex commented on pull request #8206: [HUDI-5891] Fix clustering on bootstrapped tables

Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex commented on PR #8206:
URL: https://github.com/apache/hudi/pull/8206#issuecomment-1472063364

   Tested with the scripts that surfaced this issue and they now succeed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8206: [HUDI-5891] Fix clustering on bootstrapped tables

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8206:
URL: https://github.com/apache/hudi/pull/8206#issuecomment-1472341712

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b62087f28fb5750a013bbccb96eed2fc8f54f79",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15753",
       "triggerID" : "0b62087f28fb5750a013bbccb96eed2fc8f54f79",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b62087f28fb5750a013bbccb96eed2fc8f54f79 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15753) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org