You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by wooliet <gi...@git.apache.org> on 2015/09/04 18:44:36 UTC
[GitHub] usergrid pull request: Update hasNextPage to return boolean
GitHub user wooliet opened a pull request:
https://github.com/apache/usergrid/pull/375
Update hasNextPage to return boolean
The `hasNextPage` method returned evaluation of its `_next` property,
which is either a string or null. Method documentation says it returns a
boolean value.
The result is now `_next` forced to boolean using `!!`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wooliet/usergrid master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/usergrid/pull/375.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #375
----
commit 8f83aa92d1118584144cfcccd3a3dda3648fcc02
Author: William King <wi...@centralite.com>
Date: 2015-09-04T16:37:18Z
Update hasNextPage to return boolean
The `hasNextPage` method returned evaluation of its `_next` property,
which is either a string or null. Method documentation says it returns a
boolean value.
The result is now `_next` forced to boolean using `!!`.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Update hasNextPage to return boolean
Posted by wooliet <gi...@git.apache.org>.
Github user wooliet commented on the pull request:
https://github.com/apache/usergrid/pull/375#issuecomment-140440464
Sorry, I have not signed anything. The readme mentions "For larger PRs" and I didn't think this would be considered a large pull request.
Using `!!` is concise and covers all falsey values, including `_next` set to an empty string. I don't know if that's possible or not with the `fetch` request on line 1760, but it seemed like the safest bet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Update hasNextPage to return boolean
Posted by shawnfeldman <gi...@git.apache.org>.
Github user shawnfeldman commented on the pull request:
https://github.com/apache/usergrid/pull/375#issuecomment-140809169
can you sign and email the icla to the secretary? https://www.apache.org/licenses/icla.txt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Update hasNextPage to return boolean
Posted by shawnfeldman <gi...@git.apache.org>.
Github user shawnfeldman commented on the pull request:
https://github.com/apache/usergrid/pull/375#issuecomment-140809244
secretary@apache.org.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Update hasNextPage to return boolean
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/usergrid/pull/375
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Update hasNextPage to return boolean
Posted by michaelarusso <gi...@git.apache.org>.
Github user michaelarusso commented on the pull request:
https://github.com/apache/usergrid/pull/375#issuecomment-169827910
@wooliet Thanks for the contribution! I'll merge this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Update hasNextPage to return boolean
Posted by shawnfeldman <gi...@git.apache.org>.
Github user shawnfeldman commented on the pull request:
https://github.com/apache/usergrid/pull/375#issuecomment-137789667
why not just say (_next !== null && _next !== undefined)
not sure we want to propagate !! around
also have you signed an apache icla?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---