You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/07/16 03:43:37 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42021: [SPARK-43418][CONNECT][FOLLOWUP] Remove the deprecation warning in `SparkSession.Builder.build`

HyukjinKwon commented on code in PR #42021:
URL: https://github.com/apache/spark/pull/42021#discussion_r1264601261


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -718,7 +718,6 @@ object SparkSession extends Logging {
      *
      * This will always return a newly created session.
      */
-    @deprecated(message = "Please use create() instead.", since = "3.5.0")

Review Comment:
   This is connect library which is relatively fine to deprecate and remove unlike other API that has been years. let's just deprecate this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org