[GitHub] qpid-dispatch issue #82: DISPATCH-184 - Resolve port name to int when applyi...

[jdanekrh <gi...@git.apache.org>]

Github user jdanekrh commented on the issue:

    https://github.com/apache/qpid-dispatch/pull/82
  
    @ganeshmurthy What do you think about my
    
    1. Add a Port type to python/qpid_dispatch_internal/management/schema.py, do the conversion to int as part of validation.
    2. Convert port to int in python/qpid_dispatch_internal/management/agent.py in ListenerEntity and ConnectorEntity, either in validate, create, or init method.
    3. Catch the error code in qdpn_listener and qdpn_connector and do a if strcmp(port, "amqp") ... there, Or call into Url.Port() in Python to avoid code duplication.
    
    dilemma? Is one of these preferable? I went with 2, but other may make more sense. Or surely even other options could be suggested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org