[GitHub] [camel] essobedo commented on a diff in pull request #10821: CAMEL-19651: camel-kafka - Use default partitioning logic as the default

["essobedo (via GitHub)" <gi...@apache.org>]

essobedo commented on code in PR #10821:
URL: https://github.com/apache/camel/pull/10821#discussion_r1273589140


##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConstants.java:
##########
@@ -61,7 +61,7 @@ public final class KafkaConstants {
 
     public static final String KAFKA_DEFAULT_SERIALIZER = "org.apache.kafka.common.serialization.StringSerializer";
     public static final String KAFKA_DEFAULT_DESERIALIZER = "org.apache.kafka.common.serialization.StringDeserializer";
-    public static final String KAFKA_DEFAULT_PARTITIONER = "org.apache.kafka.clients.producer.internals.DefaultPartitioner";
+    public static final String KAFKA_DEFAULT_PARTITIONER = "";

Review Comment:
   About the change itself, I would rather prefer to have it removed instead of keeping a static field with an empty String as value, but we can wait for other points of views



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org