You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by mayank jain <ma...@freestoneinfotech.com> on 2020/03/04 10:07:09 UTC

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/
-----------------------------------------------------------

(Updated March 4, 2020, 10:07 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

UI changes addded for Beta UI and Error handling support added in UI


Bugs: ATLAS-3423
    https://issues.apache.org/jira/browse/ATLAS-3423


Repository: atlas


Description
-------

This patch consists implementation for 2 end points first for template download and other for csv file upload with term details also the Unit Test cases for both the end points.

* The 1st endpoint {glossary/template} return template file this would be type of format of data that shows how the data needs to be populated by user in the file.

http://localhost:21000/api/atlas/v2/glossary/importHeaderRow

Template structure:-

GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"


* The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually parse the Data into AtlasObjects and further create the AtlasGlossaryTerms inside Glossary.

curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F file=@template_6.csv "http://localhost:21000/api/atlas/v2/glossary/import


Note:-

While populating the data in the  csv file each record should be maintained in single Line (enter command within the record would result in parsing the second line as a new record).

The downloaded template needs to be saved as whateverTheFileNameIs.csv explicitly.

If the file is been succefully uploaded then the AtlasGlossaryTerm would be returned or else List of Errors would returned for user to rectify them further.


Diffs (updated)
-----

  common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd5601 
  dashboardv2/gruntfile.js fef4e08c3 
  dashboardv2/package-lock.json 7f25b5752 
  dashboardv2/package.json e90040edb 
  dashboardv2/public/css/scss/theme.scss 0589e0920 
  dashboardv2/public/index.html.tpl a6a999e53 
  dashboardv2/public/js/main.js 75e16c3aa 
  dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html 1fa1e3540 
  dashboardv2/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
  dashboardv2/public/js/utils/UrlLinks.js 6c67e8c37 
  dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 9b386f326 
  dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
  dashboardv3/gruntfile.js f55ff0d5e 
  dashboardv3/package-lock.json 3918eccaa 
  dashboardv3/package.json 5dc05104f 
  dashboardv3/public/css/scss/leftsidebar.scss bbdc5fb26 
  dashboardv3/public/css/scss/theme.scss 2b0c45d6b 
  dashboardv3/public/index.html.tpl 2edbb659d 
  dashboardv3/public/js/main.js 26fd70991 
  dashboardv3/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
  dashboardv3/public/js/templates/search/tree/GlossaryTreeLayoutView_tmpl.html 83da9c57c 
  dashboardv3/public/js/utils/UrlLinks.js 2bbe6796f 
  dashboardv3/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
  dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 28c6a9e4a 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50dca 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 04eb4a08e 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java 660514bc2 
  pom.xml f76c6a05e 
  repository/pom.xml 802d587a8 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d58 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java cdc3f073f 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f9409 
  repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 759dcdf42 
  repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
  repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
  repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
  repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6bce 


Diff: https://reviews.apache.org/r/71482/diff/12/

Changes: https://reviews.apache.org/r/71482/diff/11-12/


Testing
-------

Tested both the endpoint with curl call.

Tested upload term csv with around 100 records from curl.


Thanks,

mayank jain

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

Posted by Sidharth Mishra <si...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review219788
-----------------------------------------------------------



- Sidharth Mishra


On March 4, 2020, 10:07 a.m., mayank jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71482/
> -----------------------------------------------------------
> 
> (Updated March 4, 2020, 10:07 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3423
>     https://issues.apache.org/jira/browse/ATLAS-3423
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch consists implementation for 2 end points first for template download and other for csv file upload with term details also the Unit Test cases for both the end points.
> 
> * The 1st endpoint {glossary/template} return template file this would be type of format of data that shows how the data needs to be populated by user in the file.
> 
> http://localhost:21000/api/atlas/v2/glossary/importHeaderRow
> 
> Template structure:-
> 
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
> 
> 
> * The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually parse the Data into AtlasObjects and further create the AtlasGlossaryTerms inside Glossary.
> 
> curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F file=@template_6.csv "http://localhost:21000/api/atlas/v2/glossary/import
> 
> 
> Note:-
> 
> While populating the data in the  csv file each record should be maintained in single Line (enter command within the record would result in parsing the second line as a new record).
> 
> The downloaded template needs to be saved as whateverTheFileNameIs.csv explicitly.
> 
> If the file is been succefully uploaded then the AtlasGlossaryTerm would be returned or else List of Errors would returned for user to rectify them further.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd5601 
>   dashboardv2/gruntfile.js fef4e08c3 
>   dashboardv2/package-lock.json 7f25b5752 
>   dashboardv2/package.json e90040edb 
>   dashboardv2/public/css/scss/theme.scss 0589e0920 
>   dashboardv2/public/index.html.tpl a6a999e53 
>   dashboardv2/public/js/main.js 75e16c3aa 
>   dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html 1fa1e3540 
>   dashboardv2/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/utils/UrlLinks.js 6c67e8c37 
>   dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 9b386f326 
>   dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/gruntfile.js f55ff0d5e 
>   dashboardv3/package-lock.json 3918eccaa 
>   dashboardv3/package.json 5dc05104f 
>   dashboardv3/public/css/scss/leftsidebar.scss bbdc5fb26 
>   dashboardv3/public/css/scss/theme.scss 2b0c45d6b 
>   dashboardv3/public/index.html.tpl 2edbb659d 
>   dashboardv3/public/js/main.js 26fd70991 
>   dashboardv3/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv3/public/js/templates/search/tree/GlossaryTreeLayoutView_tmpl.html 83da9c57c 
>   dashboardv3/public/js/utils/UrlLinks.js 2bbe6796f 
>   dashboardv3/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 28c6a9e4a 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50dca 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 04eb4a08e 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java 660514bc2 
>   pom.xml f76c6a05e 
>   repository/pom.xml 802d587a8 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d58 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java cdc3f073f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f9409 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 759dcdf42 
>   repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
>   repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6bce 
> 
> 
> Diff: https://reviews.apache.org/r/71482/diff/12/
> 
> 
> Testing
> -------
> 
> Tested both the endpoint with curl call.
> 
> Tested upload term csv with around 100 records from curl.
> 
> 
> Thanks,
> 
> mayank jain
> 
>

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

Posted by Sidharth Mishra <si...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review219787
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Line 74 (original), 83 (patched)
<https://reviews.apache.org/r/71482/#comment307988>

    Remove extra space after entityChangeNotifier



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 89 (patched)
<https://reviews.apache.org/r/71482/#comment307989>

    Align the = with other assignments in constructors



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1094 (patched)
<https://reviews.apache.org/r/71482/#comment307993>

    Remove this extra line



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1099 (patched)
<https://reviews.apache.org/r/71482/#comment307990>

    Remove the extra new line here



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1100 (patched)
<https://reviews.apache.org/r/71482/#comment307992>

    It's better to append the IOExcpetion message to AtlasBaseException for more details of exception



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1101 (patched)
<https://reviews.apache.org/r/71482/#comment307991>

    Template -> template



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1106 (patched)
<https://reviews.apache.org/r/71482/#comment307994>

    Remove this extra line



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1108 (patched)
<https://reviews.apache.org/r/71482/#comment307996>

    please make this as well local to try



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1109 (patched)
<https://reviews.apache.org/r/71482/#comment307995>

    This can be made local to try block and final



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1125 (patched)
<https://reviews.apache.org/r/71482/#comment307997>

    Please remove extra line. Same is present other places as well.



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1127 (patched)
<https://reviews.apache.org/r/71482/#comment307998>

    An Error - Error



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1128 (patched)
<https://reviews.apache.org/r/71482/#comment307999>

    An Error - Error



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1139 (patched)
<https://reviews.apache.org/r/71482/#comment308000>

    remove extrra line



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1143 (patched)
<https://reviews.apache.org/r/71482/#comment308001>

    An Error - Error



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1144 (patched)
<https://reviews.apache.org/r/71482/#comment308002>

    An Error - Error



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 532 (patched)
<https://reviews.apache.org/r/71482/#comment308003>

    We should always try to avoid function argument to be out argument. It will be hard understand and its error prone. Here the second argument failedTermMsgList is an out argument. Please avoid this.



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 555 (patched)
<https://reviews.apache.org/r/71482/#comment308007>

    Please Fix the indentation



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 559 (patched)
<https://reviews.apache.org/r/71482/#comment308006>

    Please Remove extra blank line



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 560 (patched)
<https://reviews.apache.org/r/71482/#comment308004>

    Better change this if else to ->
    
                    if(GlossaryService.isNameInvalid(glossaryName)) {
               // Error
    }else{
          // Success
    }



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 567 (patched)
<https://reviews.apache.org/r/71482/#comment308005>

    Please fix Indentation



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 586 (patched)
<https://reviews.apache.org/r/71482/#comment308009>

    Better use System.getProperty("line.separator") instead of '\n'. Please check the indentation here as well



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 587 (patched)
<https://reviews.apache.org/r/71482/#comment308008>

    It seems failedTermMsgList is not being used outside of this function. We can remove this argument from the function. This will also avoid out argument



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 676 (patched)
<https://reviews.apache.org/r/71482/#comment308010>

    Please take care of indentation at most of the places in your patchl. Like space before and after '+' etc.


- Sidharth Mishra


On March 4, 2020, 10:07 a.m., mayank jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71482/
> -----------------------------------------------------------
> 
> (Updated March 4, 2020, 10:07 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3423
>     https://issues.apache.org/jira/browse/ATLAS-3423
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch consists implementation for 2 end points first for template download and other for csv file upload with term details also the Unit Test cases for both the end points.
> 
> * The 1st endpoint {glossary/template} return template file this would be type of format of data that shows how the data needs to be populated by user in the file.
> 
> http://localhost:21000/api/atlas/v2/glossary/importHeaderRow
> 
> Template structure:-
> 
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
> 
> 
> * The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually parse the Data into AtlasObjects and further create the AtlasGlossaryTerms inside Glossary.
> 
> curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F file=@template_6.csv "http://localhost:21000/api/atlas/v2/glossary/import
> 
> 
> Note:-
> 
> While populating the data in the  csv file each record should be maintained in single Line (enter command within the record would result in parsing the second line as a new record).
> 
> The downloaded template needs to be saved as whateverTheFileNameIs.csv explicitly.
> 
> If the file is been succefully uploaded then the AtlasGlossaryTerm would be returned or else List of Errors would returned for user to rectify them further.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd5601 
>   dashboardv2/gruntfile.js fef4e08c3 
>   dashboardv2/package-lock.json 7f25b5752 
>   dashboardv2/package.json e90040edb 
>   dashboardv2/public/css/scss/theme.scss 0589e0920 
>   dashboardv2/public/index.html.tpl a6a999e53 
>   dashboardv2/public/js/main.js 75e16c3aa 
>   dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html 1fa1e3540 
>   dashboardv2/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/utils/UrlLinks.js 6c67e8c37 
>   dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 9b386f326 
>   dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/gruntfile.js f55ff0d5e 
>   dashboardv3/package-lock.json 3918eccaa 
>   dashboardv3/package.json 5dc05104f 
>   dashboardv3/public/css/scss/leftsidebar.scss bbdc5fb26 
>   dashboardv3/public/css/scss/theme.scss 2b0c45d6b 
>   dashboardv3/public/index.html.tpl 2edbb659d 
>   dashboardv3/public/js/main.js 26fd70991 
>   dashboardv3/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv3/public/js/templates/search/tree/GlossaryTreeLayoutView_tmpl.html 83da9c57c 
>   dashboardv3/public/js/utils/UrlLinks.js 2bbe6796f 
>   dashboardv3/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 28c6a9e4a 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50dca 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 04eb4a08e 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java 660514bc2 
>   pom.xml f76c6a05e 
>   repository/pom.xml 802d587a8 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d58 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java cdc3f073f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f9409 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 759dcdf42 
>   repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
>   repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6bce 
> 
> 
> Diff: https://reviews.apache.org/r/71482/diff/12/
> 
> 
> Testing
> -------
> 
> Tested both the endpoint with curl call.
> 
> Tested upload term csv with around 100 records from curl.
> 
> 
> Thanks,
> 
> mayank jain
> 
>

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review219772
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
Line 66 (original), 66 (patched)
<https://reviews.apache.org/r/71482/#comment307968>

    Empty string as default value for 'atlas.import.temp.directory' is by-design. Why should the default be changed?



intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 171 (patched)
<https://reviews.apache.org/r/71482/#comment307969>

    "File Type" => "file type"



intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 195 (patched)
<https://reviews.apache.org/r/71482/#comment307970>

    "No Data" => "No data"



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1107 (patched)
<https://reviews.apache.org/r/71482/#comment307975>

    Avoid prefix 'atlas' to variables/members.



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1122 (patched)
<https://reviews.apache.org/r/71482/#comment307974>

    Contents of failedTermMsgList don't seem to be used here; how are the failures reported back to the caller?



repository/src/main/java/org/apache/atlas/util/FileUtils.java
Lines 59 (patched)
<https://reviews.apache.org/r/71482/#comment307971>

    - which directory does this file, named 'template', get created? In webapp directory or the directory from which Atlas server was launched?
    - when does this file get cleaned up (i.e. deleted)?
    - if this method is called simultaneously from mutiple threads, the file contents will be overwritten. What is the impact?



repository/src/main/java/org/apache/atlas/util/FileUtils.java
Lines 86 (patched)
<https://reviews.apache.org/r/71482/#comment307972>

    Error message doesn't have enough details to troubleshoot the issue. Please review and update.



webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java
Lines 957 (patched)
<https://reviews.apache.org/r/71482/#comment307973>

    I suggest to use replace '/template' with '/import/template'.


- Madhan Neethiraj


On March 4, 2020, 10:07 a.m., mayank jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71482/
> -----------------------------------------------------------
> 
> (Updated March 4, 2020, 10:07 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3423
>     https://issues.apache.org/jira/browse/ATLAS-3423
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch consists implementation for 2 end points first for template download and other for csv file upload with term details also the Unit Test cases for both the end points.
> 
> * The 1st endpoint {glossary/template} return template file this would be type of format of data that shows how the data needs to be populated by user in the file.
> 
> http://localhost:21000/api/atlas/v2/glossary/importHeaderRow
> 
> Template structure:-
> 
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
> 
> 
> * The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually parse the Data into AtlasObjects and further create the AtlasGlossaryTerms inside Glossary.
> 
> curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F file=@template_6.csv "http://localhost:21000/api/atlas/v2/glossary/import
> 
> 
> Note:-
> 
> While populating the data in the  csv file each record should be maintained in single Line (enter command within the record would result in parsing the second line as a new record).
> 
> The downloaded template needs to be saved as whateverTheFileNameIs.csv explicitly.
> 
> If the file is been succefully uploaded then the AtlasGlossaryTerm would be returned or else List of Errors would returned for user to rectify them further.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd5601 
>   dashboardv2/gruntfile.js fef4e08c3 
>   dashboardv2/package-lock.json 7f25b5752 
>   dashboardv2/package.json e90040edb 
>   dashboardv2/public/css/scss/theme.scss 0589e0920 
>   dashboardv2/public/index.html.tpl a6a999e53 
>   dashboardv2/public/js/main.js 75e16c3aa 
>   dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html 1fa1e3540 
>   dashboardv2/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/utils/UrlLinks.js 6c67e8c37 
>   dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 9b386f326 
>   dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/gruntfile.js f55ff0d5e 
>   dashboardv3/package-lock.json 3918eccaa 
>   dashboardv3/package.json 5dc05104f 
>   dashboardv3/public/css/scss/leftsidebar.scss bbdc5fb26 
>   dashboardv3/public/css/scss/theme.scss 2b0c45d6b 
>   dashboardv3/public/index.html.tpl 2edbb659d 
>   dashboardv3/public/js/main.js 26fd70991 
>   dashboardv3/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv3/public/js/templates/search/tree/GlossaryTreeLayoutView_tmpl.html 83da9c57c 
>   dashboardv3/public/js/utils/UrlLinks.js 2bbe6796f 
>   dashboardv3/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 28c6a9e4a 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50dca 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 04eb4a08e 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java 660514bc2 
>   pom.xml f76c6a05e 
>   repository/pom.xml 802d587a8 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d58 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java cdc3f073f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f9409 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 759dcdf42 
>   repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
>   repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6bce 
> 
> 
> Diff: https://reviews.apache.org/r/71482/diff/12/
> 
> 
> Testing
> -------
> 
> Tested both the endpoint with curl call.
> 
> Tested upload term csv with around 100 records from curl.
> 
> 
> Thanks,
> 
> mayank jain
> 
>

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

Posted by Sidharth Mishra <si...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review219786
-----------------------------------------------------------




common/src/main/java/org/apache/atlas/repository/Constants.java
Lines 205 (patched)
<https://reviews.apache.org/r/71482/#comment307986>

    Please provide comments which will be useful to get some more context or remove the comment. In this case the variable name is more informative than the comment.



common/src/main/java/org/apache/atlas/repository/Constants.java
Lines 207 (patched)
<https://reviews.apache.org/r/71482/#comment307985>

    Please consider renaming GlossaryImportSupportedFileFormats to GlossaryImportSupportedFileExtensions as you have used extensions at other places and comments



dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js
Lines 53 (patched)
<https://reviews.apache.org/r/71482/#comment307987>

    This comment is not adding any useful information as the initialize block is self explanatory.


- Sidharth Mishra


On March 4, 2020, 10:07 a.m., mayank jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71482/
> -----------------------------------------------------------
> 
> (Updated March 4, 2020, 10:07 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3423
>     https://issues.apache.org/jira/browse/ATLAS-3423
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch consists implementation for 2 end points first for template download and other for csv file upload with term details also the Unit Test cases for both the end points.
> 
> * The 1st endpoint {glossary/template} return template file this would be type of format of data that shows how the data needs to be populated by user in the file.
> 
> http://localhost:21000/api/atlas/v2/glossary/importHeaderRow
> 
> Template structure:-
> 
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
> 
> 
> * The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually parse the Data into AtlasObjects and further create the AtlasGlossaryTerms inside Glossary.
> 
> curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F file=@template_6.csv "http://localhost:21000/api/atlas/v2/glossary/import
> 
> 
> Note:-
> 
> While populating the data in the  csv file each record should be maintained in single Line (enter command within the record would result in parsing the second line as a new record).
> 
> The downloaded template needs to be saved as whateverTheFileNameIs.csv explicitly.
> 
> If the file is been succefully uploaded then the AtlasGlossaryTerm would be returned or else List of Errors would returned for user to rectify them further.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd5601 
>   dashboardv2/gruntfile.js fef4e08c3 
>   dashboardv2/package-lock.json 7f25b5752 
>   dashboardv2/package.json e90040edb 
>   dashboardv2/public/css/scss/theme.scss 0589e0920 
>   dashboardv2/public/index.html.tpl a6a999e53 
>   dashboardv2/public/js/main.js 75e16c3aa 
>   dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html 1fa1e3540 
>   dashboardv2/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/utils/UrlLinks.js 6c67e8c37 
>   dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 9b386f326 
>   dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/gruntfile.js f55ff0d5e 
>   dashboardv3/package-lock.json 3918eccaa 
>   dashboardv3/package.json 5dc05104f 
>   dashboardv3/public/css/scss/leftsidebar.scss bbdc5fb26 
>   dashboardv3/public/css/scss/theme.scss 2b0c45d6b 
>   dashboardv3/public/index.html.tpl 2edbb659d 
>   dashboardv3/public/js/main.js 26fd70991 
>   dashboardv3/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv3/public/js/templates/search/tree/GlossaryTreeLayoutView_tmpl.html 83da9c57c 
>   dashboardv3/public/js/utils/UrlLinks.js 2bbe6796f 
>   dashboardv3/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 28c6a9e4a 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50dca 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 04eb4a08e 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java 660514bc2 
>   pom.xml f76c6a05e 
>   repository/pom.xml 802d587a8 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d58 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java cdc3f073f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f9409 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 759dcdf42 
>   repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
>   repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6bce 
> 
> 
> Diff: https://reviews.apache.org/r/71482/diff/12/
> 
> 
> Testing
> -------
> 
> Tested both the endpoint with curl call.
> 
> Tested upload term csv with around 100 records from curl.
> 
> 
> Thanks,
> 
> mayank jain
> 
>

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review219852
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 171 (patched)
<https://reviews.apache.org/r/71482/#comment308099>

    "ATLAS-400-00-9B" => "ATLAS-400-00-098"



intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 229 (patched)
<https://reviews.apache.org/r/71482/#comment308098>

    Duplicate error code - #228 & #229. Update to "ATLAS-500-00-016"



repository/src/main/java/org/apache/atlas/util/FileUtils.java
Lines 96 (patched)
<https://reviews.apache.org/r/71482/#comment308104>

    Is it necessary to write to a file, then read it into List<String[]>? Can't CSVReader (#119) directly read from InputStream?
    
      new CSVReader(new InputStreamReader(uploadedInputStream));



webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java
Lines 962 (patched)
<https://reviews.apache.org/r/71482/#comment308103>

    Is it necessary to return a 'File' here - given the template is not a large string? And, how are the files returned here deleted?
    
    Consider returning javax.ws.rs.core.StreamingOutput, like:
    
      public StreamingOutput produceTemplate() throws AtlasBaseException {
        return new StreamingOutput() {
            @Override
    		public void write(OutputStream output) throws IOException, WebApplicationException {
    			output.write(glossaryService.getGlossaryTermTemplateString());
    		}
        }
      }


- Madhan Neethiraj


On March 9, 2020, 10:07 a.m., mayank jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71482/
> -----------------------------------------------------------
> 
> (Updated March 9, 2020, 10:07 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3423
>     https://issues.apache.org/jira/browse/ATLAS-3423
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch consists implementation for 2 end points first for template download and other for csv file upload with term details also the Unit Test cases for both the end points.
> 
> * The 1st endpoint {glossary/template} return template file this would be type of format of data that shows how the data needs to be populated by user in the file.
> 
> http://localhost:21000/api/atlas/v2/glossary/importHeaderRow
> 
> Template structure:-
> 
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
> 
> 
> * The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually parse the Data into AtlasObjects and further create the AtlasGlossaryTerms inside Glossary.
> 
> curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F file=@template_6.csv "http://localhost:21000/api/atlas/v2/glossary/import
> 
> 
> Note:-
> 
> While populating the data in the  csv file each record should be maintained in single Line (enter command within the record would result in parsing the second line as a new record).
> 
> The downloaded template needs to be saved as whateverTheFileNameIs.csv explicitly.
> 
> If the file is been succefully uploaded then the AtlasGlossaryTerm would be returned or else List of Errors would returned for user to rectify them further.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd56 
>   dashboardv2/gruntfile.js fef4e08 
>   dashboardv2/package-lock.json 7f25b57 
>   dashboardv2/package.json e90040e 
>   dashboardv2/public/css/scss/theme.scss 0589e09 
>   dashboardv2/public/index.html.tpl a6a999e 
>   dashboardv2/public/js/main.js 75e16c3 
>   dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html 1fa1e35 
>   dashboardv2/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/utils/UrlLinks.js 6c67e8c 
>   dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 9b386f3 
>   dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/gruntfile.js f55ff0d 
>   dashboardv3/package-lock.json 3918ecc 
>   dashboardv3/package.json 5dc0510 
>   dashboardv3/public/css/scss/leftsidebar.scss bbdc5fb 
>   dashboardv3/public/css/scss/theme.scss 2b0c45d 
>   dashboardv3/public/index.html.tpl 2edbb65 
>   dashboardv3/public/js/main.js 26fd709 
>   dashboardv3/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv3/public/js/templates/search/tree/GlossaryTreeLayoutView_tmpl.html 83da9c5 
>   dashboardv3/public/js/utils/UrlLinks.js 2bbe679 
>   dashboardv3/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 28c6a9e 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50d 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 04eb4a0 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java 660514b 
>   pom.xml f76c6a0 
>   repository/pom.xml 802d587 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java cdc3f07 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f94 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 759dcdf 
>   repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
>   repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6b 
> 
> 
> Diff: https://reviews.apache.org/r/71482/diff/13/
> 
> 
> Testing
> -------
> 
> Tested both the endpoint with curl call.
> 
> Tested upload term csv with around 100 records from curl.
> 
> 
> Thanks,
> 
> mayank jain
> 
>

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review219893
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/util/FileUtils.java
Lines 78 (patched)
<https://reviews.apache.org/r/71482/#comment308136>

    CSVReader (line #99) reads from Reader; give this, consider avoiding creation of temporary file here. Instead directly read from uploadedInputStream, like this:
    
        fileData = FileUtils.readCSV(uploadedInputStream);
    
      
      public static List<String[]> readCSV(InputStream inputStream) throws IOException {
        List<String[]> ret = new ArrayList<>()
      
        try (CSVReader csvReader = new CSVReader(new InputStreamReader(inputStream))) {
          ...
        }
        
        return ret;
      }
      
    Once this refactoring is done, please remove unused methods from FileUtils.


- Madhan Neethiraj


On March 11, 2020, 12:05 p.m., mayank jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71482/
> -----------------------------------------------------------
> 
> (Updated March 11, 2020, 12:05 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3423
>     https://issues.apache.org/jira/browse/ATLAS-3423
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch consists implementation for 2 end points first for template download and other for csv file upload with term details also the Unit Test cases for both the end points.
> 
> * The 1st endpoint {glossary/template} return template file this would be type of format of data that shows how the data needs to be populated by user in the file.
> 
> http://localhost:21000/api/atlas/v2/glossary/importHeaderRow
> 
> Template structure:-
> 
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
> 
> 
> * The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually parse the Data into AtlasObjects and further create the AtlasGlossaryTerms inside Glossary.
> 
> curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F file=@template_6.csv "http://localhost:21000/api/atlas/v2/glossary/import
> 
> 
> Note:-
> 
> While populating the data in the  csv file each record should be maintained in single Line (enter command within the record would result in parsing the second line as a new record).
> 
> The downloaded template needs to be saved as whateverTheFileNameIs.csv explicitly.
> 
> If the file is been succefully uploaded then the AtlasGlossaryTerm would be returned or else List of Errors would returned for user to rectify them further.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd56 
>   dashboardv2/gruntfile.js fef4e08 
>   dashboardv2/package-lock.json 7f25b57 
>   dashboardv2/package.json e90040e 
>   dashboardv2/public/css/scss/theme.scss aad0dfa 
>   dashboardv2/public/index.html.tpl 7cd86bd 
>   dashboardv2/public/js/main.js 41af465 
>   dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html 1fa1e35 
>   dashboardv2/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/utils/UrlLinks.js 6c67e8c 
>   dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 9b386f3 
>   dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/gruntfile.js f55ff0d 
>   dashboardv3/package-lock.json 3918ecc 
>   dashboardv3/package.json 5dc0510 
>   dashboardv3/public/css/scss/leftsidebar.scss bbdc5fb 
>   dashboardv3/public/css/scss/theme.scss 2b0c45d 
>   dashboardv3/public/index.html.tpl 1baeb12 
>   dashboardv3/public/js/main.js 96ef7ae 
>   dashboardv3/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv3/public/js/templates/search/tree/GlossaryTreeLayoutView_tmpl.html 83da9c5 
>   dashboardv3/public/js/utils/UrlLinks.js 95ca065 
>   dashboardv3/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 28c6a9e 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50d 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 1bd2fd0 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java 660514b 
>   pom.xml a6da9b8 
>   repository/pom.xml 802d587 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java cdc3f07 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f94 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 759dcdf 
>   repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
>   repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6b 
> 
> 
> Diff: https://reviews.apache.org/r/71482/diff/14/
> 
> 
> Testing
> -------
> 
> Tested both the endpoint with curl call.
> 
> Tested upload term csv with around 100 records from curl.
> 
> 
> Thanks,
> 
> mayank jain
> 
>

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

Posted by Sidharth Mishra <si...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review219912
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1124 (patched)
<https://reviews.apache.org/r/71482/#comment308149>

    Remove extra blank line



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 549 (patched)
<https://reviews.apache.org/r/71482/#comment308151>

    Please remove the extra blank lines like this even other places.



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 558 (patched)
<https://reviews.apache.org/r/71482/#comment308150>

    Remove the extra blank line


- Sidharth Mishra


On March 12, 2020, 10:37 a.m., mayank jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71482/
> -----------------------------------------------------------
> 
> (Updated March 12, 2020, 10:37 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3423
>     https://issues.apache.org/jira/browse/ATLAS-3423
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch consists implementation for 2 end points first for template download and other for csv file upload with term details also the Unit Test cases for both the end points.
> 
> * The 1st endpoint {glossary/template} return template file this would be type of format of data that shows how the data needs to be populated by user in the file.
> 
> http://localhost:21000/api/atlas/v2/glossary/importHeaderRow
> 
> Template structure:-
> 
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
> 
> 
> * The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually parse the Data into AtlasObjects and further create the AtlasGlossaryTerms inside Glossary.
> 
> curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F file=@template_6.csv "http://localhost:21000/api/atlas/v2/glossary/import
> 
> 
> Note:-
> 
> While populating the data in the  csv file each record should be maintained in single Line (enter command within the record would result in parsing the second line as a new record).
> 
> The downloaded template needs to be saved as whateverTheFileNameIs.csv explicitly.
> 
> If the file is been succefully uploaded then the AtlasGlossaryTerm would be returned or else List of Errors would returned for user to rectify them further.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd56 
>   dashboardv2/gruntfile.js fef4e08 
>   dashboardv2/package-lock.json 7f25b57 
>   dashboardv2/package.json e90040e 
>   dashboardv2/public/css/scss/theme.scss aad0dfa 
>   dashboardv2/public/index.html.tpl 7cd86bd 
>   dashboardv2/public/js/main.js 41af465 
>   dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html 1fa1e35 
>   dashboardv2/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/utils/UrlLinks.js 6c67e8c 
>   dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 9b386f3 
>   dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/gruntfile.js f55ff0d 
>   dashboardv3/package-lock.json 3918ecc 
>   dashboardv3/package.json 5dc0510 
>   dashboardv3/public/css/scss/leftsidebar.scss bbdc5fb 
>   dashboardv3/public/css/scss/theme.scss 2b0c45d 
>   dashboardv3/public/index.html.tpl 1baeb12 
>   dashboardv3/public/js/main.js 96ef7ae 
>   dashboardv3/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html PRE-CREATION 
>   dashboardv3/public/js/templates/search/tree/GlossaryTreeLayoutView_tmpl.html 83da9c5 
>   dashboardv3/public/js/utils/UrlLinks.js 95ca065 
>   dashboardv3/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
>   dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 28c6a9e 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50d 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 1bd2fd0 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java 660514b 
>   pom.xml a6da9b8 
>   repository/pom.xml 802d587 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java cdc3f07 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f94 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 759dcdf 
>   repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
>   repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6b 
> 
> 
> Diff: https://reviews.apache.org/r/71482/diff/15/
> 
> 
> Testing
> -------
> 
> Tested both the endpoint with curl call.
> 
> Tested upload term csv with around 100 records from curl.
> 
> 
> Thanks,
> 
> mayank jain
> 
>

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

Posted by Sidharth Mishra <si...@gmail.com>.


> On March 18, 2020, 11:55 p.m., Sidharth Mishra wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
> > Lines 570 (patched)
> > <https://reviews.apache.org/r/71482/diff/18/?file=2213646#file2213646line570>
> >
> >     Please remove these kind of extra blank lines from here as well all other places

I can still see the extra blank lines other places. Kindly let me know if there is any specific reason you add them?


> On March 18, 2020, 11:55 p.m., Sidharth Mishra wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
> > Lines 690 (patched)
> > <https://reviews.apache.org/r/71482/diff/18/?file=2213646#file2213646line690>
> >
> >     Instead of \n use System.lineSeparator(). Please do this at all other places in entire patch

Please mention the reason for drop.


> On March 18, 2020, 11:55 p.m., Sidharth Mishra wrote:
> > repository/src/main/java/org/apache/atlas/util/FileUtils.java
> > Lines 99 (patched)
> > <https://reviews.apache.org/r/71482/diff/18/?file=2213648#file2213648line99>
> >
> >     Try to create a const for 0 explaining what does the position contains

Please mention the reason for drop.


- Sidharth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review219988
-----------------------------------------------------------


On March 19, 2020, 5:38 a.m., mayank jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71482/
> -----------------------------------------------------------
> 
> (Updated March 19, 2020, 5:38 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3423
>     https://issues.apache.org/jira/browse/ATLAS-3423
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch consists implementation for 2 end points first for template download and other for csv file upload with term details also the Unit Test cases for both the end points.
> 
> * The 1st endpoint {glossary/template} return template file this would be type of format of data that shows how the data needs to be populated by user in the file.
> 
> http://localhost:21000/api/atlas/v2/glossary/import/template
> 
> Template structure:-
> 
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
> 
> 
> * The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually parse the Data into AtlasObjects and further create the AtlasGlossaryTerms inside Glossary.
> 
> curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F file=@template_6.csv "http://localhost:21000/api/atlas/v2/glossary/import
> 
> 
> Note:-
> 
> While populating the data in the  csv file each record should be maintained in single Line (enter command within the record would result in parsing the second line as a new record).
> 
> The downloaded template needs to be saved as whateverTheFileNameIs.csv explicitly.
> 
> If the file is been succefully uploaded then the AtlasGlossaryTerm would be returned or else List of Errors would returned for user to rectify them further.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd56 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 1bd2fd0 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java 660514b 
>   pom.xml a6da9b8 
>   repository/pom.xml 802d587 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java cdc3f07 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f94 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 759dcdf 
>   repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
>   repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6b 
> 
> 
> Diff: https://reviews.apache.org/r/71482/diff/19/
> 
> 
> Testing
> -------
> 
> Tested both the endpoint with curl call.
> 
> Tested upload term csv with around 100 records from curl.
> 
> 
> Thanks,
> 
> mayank jain
> 
>

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

Posted by Sidharth Mishra <si...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review219988
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 570 (patched)
<https://reviews.apache.org/r/71482/#comment308221>

    Please remove these kind of extra blank lines from here as well all other places



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 649 (patched)
<https://reviews.apache.org/r/71482/#comment308223>

    Do something like:
    
    Set ret = null;
    
    if (StringUtils.isNotBlank(csvRecord)) {
      ...
      ret = new HashSet();
      ...
    }
    
    return ret;



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 672 (patched)
<https://reviews.apache.org/r/71482/#comment308224>

    there is on extra space after system msg and then you are again doing + " ". Please remove one. Same is there at other places. please take care of this at all other locations



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 682 (patched)
<https://reviews.apache.org/r/71482/#comment308222>

    you are already passing atlasGlossaryTerm as input to this function where you are using set of this object and then retunring the same object atlasGlossaryTerm and assigning it to same atlasGlossaryTerm at 573. Please revisit the design and rename the function accordingly. The function should always do one thing and should be named accordingly. Depending on that you should design the input and output arguments



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 690 (patched)
<https://reviews.apache.org/r/71482/#comment308225>

    Instead of \n use System.lineSeparator(). Please do this at all other places in entire patch



repository/src/main/java/org/apache/atlas/util/FileUtils.java
Lines 50 (patched)
<https://reviews.apache.org/r/71482/#comment308226>

    Please call readCSV function directly instead of using class name as its in the same class



repository/src/main/java/org/apache/atlas/util/FileUtils.java
Lines 99 (patched)
<https://reviews.apache.org/r/71482/#comment308227>

    Try to create a const for 0 explaining what does the position contains



repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java
Lines 960 (patched)
<https://reviews.apache.org/r/71482/#comment308228>

    Please remove the extra space:
    
    assertEquals(e.getMessage(), "No Data found in the uploaded file!");


- Sidharth Mishra


On March 13, 2020, 1 p.m., mayank jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71482/
> -----------------------------------------------------------
> 
> (Updated March 13, 2020, 1 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3423
>     https://issues.apache.org/jira/browse/ATLAS-3423
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch consists implementation for 2 end points first for template download and other for csv file upload with term details also the Unit Test cases for both the end points.
> 
> * The 1st endpoint {glossary/template} return template file this would be type of format of data that shows how the data needs to be populated by user in the file.
> 
> http://localhost:21000/api/atlas/v2/glossary/importHeaderRow
> 
> Template structure:-
> 
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
> 
> 
> * The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually parse the Data into AtlasObjects and further create the AtlasGlossaryTerms inside Glossary.
> 
> curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F file=@template_6.csv "http://localhost:21000/api/atlas/v2/glossary/import
> 
> 
> Note:-
> 
> While populating the data in the  csv file each record should be maintained in single Line (enter command within the record would result in parsing the second line as a new record).
> 
> The downloaded template needs to be saved as whateverTheFileNameIs.csv explicitly.
> 
> If the file is been succefully uploaded then the AtlasGlossaryTerm would be returned or else List of Errors would returned for user to rectify them further.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd56 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 1bd2fd0 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java 660514b 
>   pom.xml a6da9b8 
>   repository/pom.xml 802d587 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java cdc3f07 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f94 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 759dcdf 
>   repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
>   repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6b 
> 
> 
> Diff: https://reviews.apache.org/r/71482/diff/18/
> 
> 
> Testing
> -------
> 
> Tested both the endpoint with curl call.
> 
> Tested upload term csv with around 100 records from curl.
> 
> 
> Thanks,
> 
> mayank jain
> 
>

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

Posted by Sarath Subramanian <sa...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review220053
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On March 20, 2020, 7:06 a.m., mayank jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71482/
> -----------------------------------------------------------
> 
> (Updated March 20, 2020, 7:06 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3423
>     https://issues.apache.org/jira/browse/ATLAS-3423
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch consists implementation for 2 end points first for template download and other for csv file upload with term details also the Unit Test cases for both the end points.
> 
> * The 1st endpoint {glossary/template} return template file this would be type of format of data that shows how the data needs to be populated by user in the file.
> 
> http://localhost:21000/api/atlas/v2/glossary/import/template
> 
> Template structure:-
> 
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
> 
> 
> * The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually parse the Data into AtlasObjects and further create the AtlasGlossaryTerms inside Glossary.
> 
> curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F file=@template_6.csv "http://localhost:21000/api/atlas/v2/glossary/import
> 
> 
> Note:-
> 
> While populating the data in the  csv file each record should be maintained in single Line (enter command within the record would result in parsing the second line as a new record).
> 
> The downloaded template needs to be saved as whateverTheFileNameIs.csv explicitly.
> 
> If the file is been succefully uploaded then the AtlasGlossaryTerm would be returned or else List of Errors would returned for user to rectify them further.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd56 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 1bd2fd0 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java 660514b 
>   pom.xml a6da9b8 
>   repository/pom.xml 802d587 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java cdc3f07 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f94 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 759dcdf 
>   repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
>   repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
>   repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6b 
> 
> 
> Diff: https://reviews.apache.org/r/71482/diff/20/
> 
> 
> Testing
> -------
> 
> Tested both the endpoint with curl call.
> 
> Tested upload term csv with around 100 records from curl.
> 
> 
> Thanks,
> 
> mayank jain
> 
>