You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/31 08:05:08 UTC
[GitHub] [pulsar] gaoran10 opened a new pull request #7708: [Issue] Fix get schemaName by partitioned topic name
gaoran10 opened a new pull request #7708:
URL: https://github.com/apache/pulsar/pull/7708
Fixes #7676
### Motivation
Currently, there is an error that gets schemaName by partitioned topic name.
### Modifications
Add partitioned check in method `topicName.getSchameName()`.
### Verifying this change
Add a new unit test.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (yes)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #7708: [Issue] Fix get schemaName by partitioned topic name
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7708:
URL: https://github.com/apache/pulsar/pull/7708#issuecomment-667715139
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #7708: [Issue] Fix get schemaName by partitioned topic name
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7708:
URL: https://github.com/apache/pulsar/pull/7708#issuecomment-667818053
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #7708: [Issue] Fix get schemaName by partitioned topic name
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #7708:
URL: https://github.com/apache/pulsar/pull/7708#discussion_r463688469
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##########
@@ -342,7 +342,9 @@ public boolean isGlobal() {
public String getSchemaName() {
return getTenant()
+ "/" + getNamespacePortion()
- + "/" + getEncodedLocalName();
+ + "/" + (isPartitioned() ?
Review comment:
Ok, I could reuse it, but the method getPartitionedTopicName will return a complete topic name with the domain. Maybe I could get the encodedLocalName in this way.
```
TopicName.get(getPartitionedTopicName()).getEncodedLocalName()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #7708: [Issue] Fix get schemaName by partitioned topic name
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7708:
URL: https://github.com/apache/pulsar/pull/7708#issuecomment-667682174
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7708: [Issue] Fix get schemaName by partitioned topic name
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7708:
URL: https://github.com/apache/pulsar/pull/7708
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on a change in pull request #7708: [Issue] Fix get schemaName by partitioned topic name
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #7708:
URL: https://github.com/apache/pulsar/pull/7708#discussion_r463478316
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##########
@@ -342,7 +342,9 @@ public boolean isGlobal() {
public String getSchemaName() {
return getTenant()
+ "/" + getNamespacePortion()
- + "/" + getEncodedLocalName();
+ + "/" + (isPartitioned() ?
Review comment:
getPartitionedTopicName already implemented the functionality
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #7708: [Issue] Fix get schemaName by partitioned topic name
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7708:
URL: https://github.com/apache/pulsar/pull/7708#issuecomment-667461480
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #7708: [Issue] Fix get schemaName by partitioned topic name
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #7708:
URL: https://github.com/apache/pulsar/pull/7708#discussion_r463688469
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##########
@@ -342,7 +342,9 @@ public boolean isGlobal() {
public String getSchemaName() {
return getTenant()
+ "/" + getNamespacePortion()
- + "/" + getEncodedLocalName();
+ + "/" + (isPartitioned() ?
Review comment:
Ok, I could reuse it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #7708: [Issue] Fix get schemaName by partitioned topic name
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7708:
URL: https://github.com/apache/pulsar/pull/7708#issuecomment-667689798
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #7708: [Issue] Fix get schemaName by partitioned topic name
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7708:
URL: https://github.com/apache/pulsar/pull/7708#issuecomment-667685608
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org