You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/06/25 07:25:18 UTC
[kudu-CR] [mini ranger] search for bound port at loopback and wildcard addresses
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16111
Change subject: [mini_ranger] search for bound port at loopback and wildcard addresses
......................................................................
[mini_ranger] search for bound port at loopback and wildcard addresses
This patch updates the set of candidate bind addresses for MiniRanger.
There is an evidence that in some environments it's bound to the
wildcard IP address, sometimes on a loopback IP address. The easiest
way to address the issue is to specify both loopback and wildcard
addresses as candidates when searching for the bound Ranger's port.
The motivation for this patch was seeing the following test failures
when running RangerClientTestBase.TestLogging test scenario on
Ubuntu 14.04:
src/kudu/ranger/ranger_client-test.cc:345: Failure
Failed
Bad status: Runtime error: unexpected lsof output: p158341
f58
n127.0.0.1:60001
f243
n127.0.0.1:47896->127.0.0.1:44711
f244
n127.0.0.1:47894->127.0.0.1:44711
f245
n127.0.0.1:47898->127.0.0.1:44711
f246
n127.0.0.1:47920->127.0.0.1:44711
f247
n127.0.0.1:47922->127.0.0.1:44711
I verified that with this patch the RangerClientTestBase.TestLogging
test scenario successfully completes.
Change-Id: Idcc6835f035fa1af1aeed171a14197e03a60f547
---
M src/kudu/ranger/mini_ranger.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/16111/1
--
To view, visit http://gerrit.cloudera.org:8080/16111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcc6835f035fa1af1aeed171a14197e03a60f547
Gerrit-Change-Number: 16111
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini ranger] search for bound port at loopback and wildcard addresses
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16111 )
Change subject: [mini_ranger] search for bound port at loopback and wildcard addresses
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcc6835f035fa1af1aeed171a14197e03a60f547
Gerrit-Change-Number: 16111
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Jun 2020 17:41:56 +0000
Gerrit-HasComments: No
[kudu-CR] [mini ranger] search for bound port at loopback and wildcard addresses
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16111 )
Change subject: [mini_ranger] search for bound port at loopback and wildcard addresses
......................................................................
[mini_ranger] search for bound port at loopback and wildcard addresses
This patch updates the set of candidate bind addresses for MiniRanger.
There is an evidence that in some environments it's bound to the
wildcard IP address, sometimes on a loopback IP address. The easiest
way to address the issue is to specify both loopback and wildcard
addresses as candidates when searching for the bound Ranger's port.
The motivation for this patch was seeing the following test failures
when running RangerClientTestBase.TestLogging test scenario on
Ubuntu 14.04:
src/kudu/ranger/ranger_client-test.cc:345: Failure
Failed
Bad status: Runtime error: unexpected lsof output: p158341
f58
n127.0.0.1:60001
f243
n127.0.0.1:47896->127.0.0.1:44711
f244
n127.0.0.1:47894->127.0.0.1:44711
f245
n127.0.0.1:47898->127.0.0.1:44711
f246
n127.0.0.1:47920->127.0.0.1:44711
f247
n127.0.0.1:47922->127.0.0.1:44711
I verified that with this patch the RangerClientTestBase.TestLogging
test scenario successfully completes.
Change-Id: Idcc6835f035fa1af1aeed171a14197e03a60f547
Reviewed-on: http://gerrit.cloudera.org:8080/16111
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/ranger/mini_ranger.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Attila Bukor: Looks good to me, approved
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcc6835f035fa1af1aeed171a14197e03a60f547
Gerrit-Change-Number: 16111
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [mini ranger] search for bound port at loopback and wildcard addresses
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16111 )
Change subject: [mini_ranger] search for bound port at loopback and wildcard addresses
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcc6835f035fa1af1aeed171a14197e03a60f547
Gerrit-Change-Number: 16111
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Jun 2020 13:06:12 +0000
Gerrit-HasComments: No