You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Dirk Verbeeck <di...@pandora.be> on 2003/08/10 22:16:37 UTC
[DBCP][Pool] Volunteering to fix some issues / apply patches
Hi guys
There are a lot of small issues for DBCP and Pool, simple ones or with
solution already included.
Lately the committer activity has been low and the issue list is growing.
I have some time and can/want to fix/merge/commit the following issues:
Pool issue:
- 21838 Weird HTML makes the pool example doc hard to read
DBCP issues:
- 16987 race condition in PoolableConnection.close()
=> solution 2: synchronized close() in PoolableConnection
- 19374 Potential for DelegateStatement, DelegateResultSet to be left open
=> reallyClose() { super.close() }
- 21229 ConnectionFactory throws SQLException but implementations don't
=> remove DBCPException (it is a RuntimeException)
- 21273 Memory-leak like behaviour in DBCP due to warnings chained to
connections in the pool
=> apply suggested fix: add conn.clearWarnings(); in
passivateObject(Object obj)
- 21418 Example code
=> add Class.forName to example code
- 21458 Statements and connections don't implement equals()/hashCode
=> add methods to Delegating*
- 21748 BasicDataSource.close() throws NPE
=> trivial fix: test not null
- 22078 testOnBorrow fails if setAutoCommit() throws an exception
=> try/catch around activate in borrow method in GenericObjectPool
=> rethrow only when newlyCreated==true
- 22214 Delegating ResultSet causing NPE
=> fixed but no official release yet
- 22229 Foul connection causes livelock of all pool operations
=> remove AbandonedObjectPool and its heavy synchronized methods
There are only 2 issues that may require a vote/discussion.
- remove DBCPException (issue 21229)
- remove AbandonedConfig, AbandonedObjectPool, AbandonedTrace (issue 22229)
Im working on a event based replacement to trace abandoned pool objects
and maybe even something to cleanup them.
Anyway, can I start or is a vote needed?
I'm already committer to jakarta-commons and have some paches ready for
commit.
Best Regards
Dirk
RE: [DBCP][Pool] Volunteering to fix some issues / apply patches
Posted by Rodney Waldhoff <rw...@apache.org>.
On Sun, 10 Aug 2003, Noel J. Bergman wrote:
> Dirk,
>
> If you've got patches for the bug fixes, go for it. :-)
+1
- Rod <http://radio.weblogs.com/0122027/>
> --- Noel
>
RE: [DBCP][Pool] Volunteering to fix some issues / apply patches
Posted by Rodney Waldhoff <rw...@apache.org>.
On Sun, 10 Aug 2003, Noel J. Bergman wrote:
> Dirk,
>
> If you've got patches for the bug fixes, go for it. :-)
+1
- Rod <http://radio.weblogs.com/0122027/>
> --- Noel
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [DBCP][Pool] Volunteering to fix some issues / apply patches
Posted by Glenn Nielsen <gl...@mail.more.net>.
+ 1 to fix existing bugs and then release DBCP 1.0.2,
leaving Abandoned changes for a 1.1 or 2.0 release.
GLenn
Noel J. Bergman wrote:
> Dirk,
>
> If you've got patches for the bug fixes, go for it. :-)
>
> With respect to the AbandonedConfig changes, IMO leave that be until someone
> has time to introduce a solution that satisfies both camps.
>
> My thinking is to refactor the code down so that someone who wants it can
> introduce a sub-class that implements recovery. And some of the code is
> necessary when Connection.close() is called to handle its outstanding
> children.
>
> --- Noel
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
Re: [DBCP][Pool] Volunteering to fix some issues / apply patches
Posted by Glenn Nielsen <gl...@mail.more.net>.
+ 1 to fix existing bugs and then release DBCP 1.0.2,
leaving Abandoned changes for a 1.1 or 2.0 release.
GLenn
Noel J. Bergman wrote:
> Dirk,
>
> If you've got patches for the bug fixes, go for it. :-)
>
> With respect to the AbandonedConfig changes, IMO leave that be until someone
> has time to introduce a solution that satisfies both camps.
>
> My thinking is to refactor the code down so that someone who wants it can
> introduce a sub-class that implements recovery. And some of the code is
> necessary when Connection.close() is called to handle its outstanding
> children.
>
> --- Noel
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
RE: [DBCP][Pool] Volunteering to fix some issues / apply patches
Posted by "Noel J. Bergman" <no...@devtech.com>.
Dirk,
If you've got patches for the bug fixes, go for it. :-)
With respect to the AbandonedConfig changes, IMO leave that be until someone
has time to introduce a solution that satisfies both camps.
My thinking is to refactor the code down so that someone who wants it can
introduce a sub-class that implements recovery. And some of the code is
necessary when Connection.close() is called to handle its outstanding
children.
--- Noel
RE: [DBCP][Pool] Volunteering to fix some issues / apply patches
Posted by "Noel J. Bergman" <no...@devtech.com>.
Dirk,
If you've got patches for the bug fixes, go for it. :-)
With respect to the AbandonedConfig changes, IMO leave that be until someone
has time to introduce a solution that satisfies both camps.
My thinking is to refactor the code down so that someone who wants it can
introduce a sub-class that implements recovery. And some of the code is
necessary when Connection.close() is called to handle its outstanding
children.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org