You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/06 16:23:13 UTC
[GitHub] [incubator-superset] bearcage opened a new pull request #7461:
[WIP] Live query validation, where supported
bearcage opened a new pull request #7461: [WIP] Live query validation, where supported
URL: https://github.com/apache/incubator-superset/pull/7461
### CATEGORY
Choose one
- [ ] Bug Fix
- [X] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
This builds on #7422 to build check-as-you-type sql
query validation in Sql Lab. This closes #6707 too.
It adds a (debounced) call to the validate_sql_json
API endpoint with the querytext, and on Lyft infra is
able to return feedback to the user (end to end) in
$TBD seconds.
At present feedback is provided only through the
"annotations" mechanism build in to ACE, although
I'd be open to adding full text elsewhere on the
page if there's interest.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Server error reporting:
<img width="921" alt="Screen Shot 2019-05-05 at 7 19 38 PM" src="https://user-images.githubusercontent.com/596042/57239184-663ed380-6fe8-11e9-93e0-c00883f3579b.png">
Query error reporting:
<img width="543" alt="Screen Shot 2019-05-05 at 7 21 08 PM" src="https://user-images.githubusercontent.com/596042/57239186-68089700-6fe8-11e9-8845-6dbbd6e3a810.png">
### TEST PLAN
1. Start a development instance
2. Follow the instructions in INSTALLING to enable the presto validator
3. Connect to a prestodb instance
4. Try writing some queries against it!
You can verify the unhappy paths by:
* Injecting 5xx into your communications with presto
* Using a database which does not support validation (like the built-in sqlite). Note that no validation attempts will even be made in this case.
### ADDITIONAL INFORMATION
- [X] Has associated issue: #6707
- [X] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [X] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@xtinec @DiggidyDave @khtruong @betodealmeida
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org