You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/06/24 23:24:27 UTC
Review Request 35845: DRILL-3345: TestWindowFrame fails to properly
check cases involving multiple batches
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35845/
-----------------------------------------------------------
Review request for drill, Aman Sinha and Steven Phillips.
Bugs: DRILL-3345
https://issues.apache.org/jira/browse/DRILL-3345
Repository: drill-git
Description
-------
Updated MSorter and SelectionVector4 to allow setting a desired record batch count
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/DefaultFrameTemplate.java ada068b
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java 6686fbe
exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java 69bc78f
Diff: https://reviews.apache.org/r/35845/diff/
Testing
-------
ongoing...
Thanks,
abdelhakim deneche
Re: Review Request 35845: DRILL-3345: TestWindowFrame fails to
properly check cases involving multiple batches
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35845/#review89264
-----------------------------------------------------------
Ship it!
Ship It!
- Aman Sinha
On June 24, 2015, 9:24 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35845/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 9:24 p.m.)
>
>
> Review request for drill, Aman Sinha and Steven Phillips.
>
>
> Bugs: DRILL-3345
> https://issues.apache.org/jira/browse/DRILL-3345
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Updated MSorter and SelectionVector4 to allow setting a desired record batch count
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/DefaultFrameTemplate.java ada068b
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java 6686fbe
> exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java 69bc78f
>
> Diff: https://reviews.apache.org/r/35845/diff/
>
>
> Testing
> -------
>
> ongoing...
>
>
> Thanks,
>
> abdelhakim deneche
>
>
Re: Review Request 35845: DRILL-3345: TestWindowFrame fails to
properly check cases involving multiple batches
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35845/#review89263
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/DefaultFrameTemplate.java (line 245)
<https://reviews.apache.org/r/35845/#comment141855>
If you are going to leave this commented-out line in the code, it would be good to add a comment to indicate that the WF computation of a partition can only start after all batches of that partition have been received, not enough to have the last peer row.
- Aman Sinha
On June 24, 2015, 9:24 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35845/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 9:24 p.m.)
>
>
> Review request for drill, Aman Sinha and Steven Phillips.
>
>
> Bugs: DRILL-3345
> https://issues.apache.org/jira/browse/DRILL-3345
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Updated MSorter and SelectionVector4 to allow setting a desired record batch count
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/DefaultFrameTemplate.java ada068b
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java 6686fbe
> exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java 69bc78f
>
> Diff: https://reviews.apache.org/r/35845/diff/
>
>
> Testing
> -------
>
> ongoing...
>
>
> Thanks,
>
> abdelhakim deneche
>
>